This is a port of sirc, an excellent perl-based IRC client. Many thanks to all who helped me with the tricky issues in the port Makefile. I'm happy to say that the port installs, deinstalls, packages, unpackages, slices, dices, etc. :) The only warning from 'portlint -a -c -N' is: WARN: dependency to perl5 listed in RUN_DEPENDS. consider using USE_PERL5. which seems harmless to me since it's doing what I want it to do as is. If there is a reason to make a change in this port please let me know the reasoning behind the change since it will assist me greatly as I move on to my next porting project. :) Fix: Commit this bad boy! (Please :) How-To-Repeat: DNA
State Changed From-To: open->feedback Looks good in general, but regarding: do-install: ${MKDIR} -m 775 ${PREFIX}/libexec/sirc Does it need to be 775? Unless there's a reason otherwise, I think we expect directories to be 755.
Responsible Changed From-To: freebsd-ports->mph I am reviewing this port.
On Wed, May 06, 1998 at 03:04:06AM -0700, Studded@dal.net wrote: > WARN: dependency to perl5 listed in RUN_DEPENDS. consider using > USE_PERL5. > > which seems harmless to me since it's doing what I want it to do as > is. If there is a reason to make a change in this port please let me > know the reasoning behind the change since it will assist me greatly > as I move on to my next porting project. :) (I've taken responsibility for this PR.) I've changed it to USE_PERL5 in the copy I'm working on. There's almost no difference; /usr/share/mk/bsd.port.mk says: .if defined(USE_PERL5) BUILD_DEPENDS+= perl5.00404:${PORTSDIR}/lang/perl5 RUN_DEPENDS+= perl5.00404:${PORTSDIR}/lang/perl5 .endif It's basically just a convenient shorthand we have, but since we have it, it's nice to use it for consistency. Matt -- Matthew Hunt <mph@pobox.com> * Stay close to the Vorlon. http://mph124.rh.psu.edu/~mph/pgp.key for PGP public key 0x67203349.
State Changed From-To: feedback->closed Imported, thanks! I believe you're up-to-date regarding the minor changes to this port.
On Wed, 6 May 1998 Studded@dal.net wrote: > XNO_CONFIGURE= "There is no configure or makefile in the source" This probably isn't necessary. -- This .sig is not innovative, witty, or profund.
On Thu, May 07, 1998 at 02:40:03PM -0700, Tim Vanderhoek wrote: > > XNO_CONFIGURE= "There is no configure or makefile in the source" > > This probably isn't necessary. Agreed, I've removed it. -- Matthew Hunt <mph@pobox.com> * Stay close to the Vorlon. http://mph124.rh.psu.edu/~mph/pgp.key for PGP public key 0x67203349.