Bug 65622 - audio/jack make describe breaks with old make
Summary: audio/jack make describe breaks with old make
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Tilman Keskinoz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-04-16 14:40 UTC by Scott Lipcon
Modified: 2004-04-16 15:52 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Lipcon 2004-04-16 14:40:18 UTC
make describe in /usr/ports/audio/jack fails, causing index build to fail.

Fix: 

Older versions of make are getting confused with the number/string conversion of the OSVERSIONS - it sees "500000)" as a string and can't use >.  If you put a space after the version numbers in the comparison on line 34 the old make can tell that 500000 and 502102 are numbers not strings and make describe works fine.
How-To-Repeat: mercea# cd /usr/ports/audio/jack/
mercea# make describe
"Makefile", line 34: warning: String comparison operator should be either == or !=
"Makefile", line 34: Malformed conditional ((${OSVERSION} > 500000) && (${OSVERSION} < 502102))
"Makefile", line 34: Missing dependency operator
"Makefile", line 36: if-less endif
"Makefile", line 36: Need an operator
make: fatal errors encountered -- cannot continue
Comment 1 Kirill Ponomarev freebsd_committer 2004-04-16 15:48:18 UTC
Responsible Changed
From-To: freebsd-ports-bugs->arved

Over to maintainer.
Comment 2 Tilman Keskinoz freebsd_committer 2004-04-16 15:52:29 UTC
State Changed
From-To: open->closed

committed, thanks