Bug 68252 - [PATCH] astro/celestia: point to correct full complete source tarball
Summary: [PATCH] astro/celestia: point to correct full complete source tarball
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Trevor Johnson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-23 20:30 UTC by Paul Seniura
Modified: 2004-12-27 05:56 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (350 bytes, patch)
2004-06-23 20:30 UTC, Paul Seniura
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Seniura 2004-06-23 20:30:18 UTC
The astro/celestia port Makefile v1.17 is currently pointing
to a known incomplete source tarball.  A gmake error will
eventually show up during the build:
==snip==
gmake[5]: *** No rule to make target `eclipsefinderdlg.cpp', needed by `eclipsefinderdlg.o'.  Stop.
==snip==

I've documented further compile problems on the ports@
maillist here:
<http://docs.FreeBSD.org/cgi/mid.cgi?20040623155459.5873F5C9B>

Fix: Change MASTER_SITES to point to SourceForge's repositories
for Celestia.  Change distinfo to correlate.

===cut-here===
The SF sites can be quite slow, but they do have the
official tarball, and the updated distinfo matches it.


I would like to suggest we not alter the gcc optimization
parms that are set in the original project's Makefiles. 
This app needs every tweak it can get.  ;)  To illustrate,
after applying the above Makefile patch, the patch below
will keep the original project's parms intact (I'm striving
to test this patch running -Current on a puny pentium2 box):

===cut-here===


We still have a remaining issue when WITH_KDE=yes is in
effect, explained further in the ports@ maillist post
mentioned above.  I believe other platforms are seeing
the KDE bug, too, and will investigate further.


For now, tho, we really should change the Makefile &
distinfo to point to the correct full source tarball,
at the very least, please.  :)


  --  thx, Paul Seniura
           System Specialist
           State of Okla. D.O.T.--knQdgH9Xzu6wBH9H55zZKtTbTtaLtXJSgaJMZvQVW244RyUM
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- Makefile_orig	Mon Jun 21 16:54:31 2004
+++ Makefile	Wed Jun 23 13:29:41 2004
@@ -8,8 +8,7 @@
 PORTNAME=		celestia
 PORTVERSION=		1.3.1
 CATEGORIES=		astro
-MASTER_SITES=		http://fresh.t-systems-sfr.com/unix/src/misc/
-# ${MASTER_SITE_SOURCEFORGE}
+MASTER_SITES=		${MASTER_SITE_SOURCEFORGE}
 MASTER_SITE_SUBDIR=	celestia
 
 MAINTAINER=	trevor@FreeBSD.org
--- distinfo_orig	Mon Jun 14 00:53:39 2004
+++ distinfo	Tue Jun 22 15:12:38 2004
@@ -1,2 +1,2 @@
-MD5 (celestia-1.3.1.tar.gz) = 6b5fd597e497b951228c83d4e756a340
-SIZE (celestia-1.2.4.tar.gz) = 10280646
+MD5 (celestia-1.3.1.tar.gz) = fcb73c43f5899f8f7e6d0c619a818a8b
+SIZE (celestia-1.3.1.tar.gz) = 13291363
===cut-here===
How-To-Repeat: Use the v1.17 Makefile to try building the app.
Comment 1 Pav Lucistnik freebsd_committer freebsd_triage 2004-06-23 20:45:33 UTC
Responsible Changed
From-To: freebsd-ports-bugs->trevor

Over to maintainer.
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2004-09-03 00:46:52 UTC
State Changed
From-To: open->feedback

To maintainer: do you approve of this change?
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2004-12-27 05:54:58 UTC
State Changed
From-To: feedback->closed

Looks like this one is commited but forgotten to be closed: 
http://www.freebsd.org/cgi/cvsweb.cgi/ports/astro/celestia/Makefile