Bug 80777 - [request] usb_rem_task() should wait for callback to complete?
Summary: [request] usb_rem_task() should wait for callback to complete?
Status: Open
Alias: None
Product: Base System
Classification: Unclassified
Component: usb (show other bugs)
Version: 6.0-CURRENT
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-usb (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-08 14:50 UTC by Hans Petter Selasky
Modified: 2018-05-28 19:41 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Petter Selasky 2005-05-08 14:50:07 UTC 
In the file "/sys/dev/usb/usb.c", the function "usb_rem_task" should wait for 
the "usb_task_thread()" to finish execution of the callback function. Though 
this might be impossible due to the contexts from which this function is 
called. At least one place (see if_udav.c) "usb_rem_task" is called from 
detach, and the code expects that the callback has returned or is not called, 
after that "usb_rem_task" returns. Else the callback will access freed 
memory.

Fix: 

Maybe "usb_xxxx_task" should not be used by if_udav.c, like suggested 
in another PR?
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2008-01-29 10:15:11 UTC 
State Changed
From-To: open->suspended

Mark suspended awaiting patches.
Comment 2 Eitan Adler freebsd_committer freebsd_triage 2018-05-28 19:41:30 UTC 
batch change:

For bugs that match the following
-  Status Is In progress 
AND
- Untouched since 2018-01-01.
AND
- Affects Base System OR Documentation

DO:

Reset to open status.


Note:
I did a quick pass but if you are getting this email it might be worthwhile to double check to see if this bug ought to be closed.