Bug 81203 - mail/mutt-devel -- MUTT_LITE should not include WITHOUT_NLS
Summary: mail/mutt-devel -- MUTT_LITE should not include WITHOUT_NLS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-18 15:20 UTC by Jeremy Chadwick
Modified: 2005-05-18 16:14 UTC (History)
0 users

See Also:


Attachments
file.diff (520 bytes, patch)
2005-05-18 15:20 UTC, Jeremy Chadwick
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Chadwick 2005-05-18 15:20:02 UTC
	The addition of the MUTT_LITE knob is fantastic; however, use of this
	knob no longer allows an administrator to build a "lite" version of
	mutt _with_ support for multiple character sets (such as on our
	systems).

	I propose the WITHOUT_NLS=yes definition inside of the MUTT_LITE
	knob be removed; administrators can then say MUTT_LITE=true WITHOUT_NLS=true
	when building, which is consistent with nearly every other port in ports.

	I must stress this point, since MUTT_LITE breaks the "norm" in this respect.

	Most administrators who do not want multiple character set support define
	WITHOUT_NLS=true in /etc/make.conf anyways, i.e. every port on the system
	will not use iconv/gettext.  :-)

	Either way, it's up for discussion.  The port maintainer should be the
	one to make the call.

Fix: If maintainer agrees, apply below patch.

How-To-Repeat: 	n/a
Comment 1 Udo.Schweigert 2005-05-18 15:37:58 UTC
On Wed, May 18, 2005 at 07:19:15 -0700, Jeremy Chadwick wrote:
> I must stress this point, since MUTT_LITE breaks the "norm" in this respect.
>
> Most administrators who do not want multiple character set support define
> WITHOUT_NLS=true in /etc/make.conf anyways, i.e. every port on the system
> will not use iconv/gettext.  :-)
> 
> Either way, it's up for discussion.  The port maintainer should be the
> one to make the call.


You're absolutely right. I approve the patch and a similar one for the mutt
port will be submitted soon.


Best regards

-- 
Udo Schweigert, Siemens AG   | Voice      : +49 89 636 42170
CT IC CERT, Siemens CERT     | Fax        : +49 89 636 41166
D-81730 Muenchen / Germany   | email      : udo.schweigert@siemens.com
Comment 2 Volker Stolz freebsd_committer 2005-05-18 16:14:45 UTC
State Changed
From-To: open->closed

Committed, thanks!