Bug 85922 - [patch] Fix tcl dependancy and remove SOCK5 support (which has never worked)
Summary: [patch] Fix tcl dependancy and remove SOCK5 support (which has never worked)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-09 19:50 UTC by Josh Paetzel <josh@tcbug.org>
Modified: 2005-09-10 23:27 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Josh Paetzel <josh@tcbug.org> 2005-09-09 19:50:17 UTC 

Fix dependancy errors in regards to tcl support

epic4 has options to use WITH_SOCKS5 in the Makefile.  According to the epic
developers epic4 has never worked with SOCKS5 support and agree that the SOCKS5
option should be removed from the port.

Fix: Apply the following patch:  (essentially the same as the irc/epic5 patch that just got committed)



-##  WITH_TCL:       enable Tcl support
+##  WITHOUT_TCL:        disable Tcl support
 #
-.if defined(WITH_TCL)
+.if !defined(WITHOUT_TCL)
 LIB_DEPENDS+=          tcl84:${PORTSDIR}/lang/tcl84
 CONFIGURE_ARGS+=       --with-tcl
-.endif
-
-##  WITH_SOCKS5:    enable SOCKS5 support
-#
-.if defined(WITH_SOCKS5)
-LIB_DEPENDS+=          socks5:${PORTSDIR}/net/socks5
-CONFIGURE_ARGS+=       --with-socks5
+.else
+CONFIGURE_ARGS+=       --without-tcl
 .endif

 ##  WITH_PERL:      enable perl5 support (requires perl 5.6.1 or newer)--pJy1gFIOyrrClhF0qfVyu5Zh1edVlsBAdsOvLMy51xtwdR7R
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- Makefile.old        Fri Sep  9 13:02:35 2005
+++ Makefile    Fri Sep  9 13:08:41 2005
@@ -34,18 +34,13 @@
 CONFIGURE_ARGS+=       --without-ipv6
 .endif
How-To-Repeat: 

cd /usr/ports/irc/epic4 && make WITH_SOCK5=yes install

Depending on whether tcl is installed or not gives you inconsistant behavior
regarding the Makefile switches to use tcl support or not.
Comment 1 Pav Lucistnik freebsd_committer freebsd_triage 2005-09-10 23:27:04 UTC 
State Changed
From-To: open->closed

Committed, thanks!