Bug 87518 - [patch] multimedia/pvr250: Does not build on amd64
Summary: [patch] multimedia/pvr250: Does not build on amd64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Edwin Groothuis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-10-16 14:40 UTC by Šimun Mikecin
Modified: 2005-12-03 02:19 UTC (History)
1 user (show)

See Also:

Attachments
file.diff (295 bytes, patch)
2005-10-16 14:40 UTC, Šimun Mikecin 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Šimun Mikecin 2005-10-16 14:40:16 UTC 
On FreeBSD/amd64 bus_space_handle_t and bus_space_tag_t are defined as
64-bit (see sys/amd64/include/_bus.h). cxm_i2c.c calls BUS_READ_IVAR macro
using 'unsigned int' (which is 32-bit on amd64) as the last parameter, where
it should be bus_space_handle_t.
On FreeBSD 6.x warning is emitted and compilation stops (6.x has implicit
-Werror).
Current multimedia/pvr250 port doesn't build on FreeBSD 6.x at all. That
problem is already addressed in ports/85433 which is still not commited as
of this writing. All testing was done with patches from that PR already
applied.

How-To-Repeat: Try this on FreeBSD/amd64:
	cd /usr/ports/multimedia/pvr250 && make
Comment 1 Marcus Alves Grando freebsd_committer freebsd_triage 2005-10-16 19:25:17 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->edwin

Over to maintainer.
Comment 2 edwin 2005-10-17 00:14:56 UTC 
John,

Do you have a newer version of the CXM driver after the 20050412 version?

Edwin

-- 
Edwin Groothuis      |            Personal website: http://www.mavetju.org
edwin@mavetju.org    |          Weblog: http://weblog.barnet.com.au/edwin/
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2005-10-20 12:36:03 UTC 
Responsible Changed
From-To: edwin->erwin

Over to maintainer.
Comment 4 Edwin Groothuis freebsd_committer freebsd_triage 2005-10-20 12:36:11 UTC 
Responsible Changed
From-To: erwin->edwin

Over to maintainer.
Comment 5 Edwin Groothuis freebsd_committer freebsd_triage 2005-10-21 12:27:17 UTC 
Class Changed
From-To: sw-bug->update
Comment 6 Edwin Groothuis freebsd_committer freebsd_triage 2005-10-21 12:27:58 UTC 
Class Changed
From-To: update->sw-bug
Comment 7 Edwin Groothuis freebsd_committer freebsd_triage 2005-10-21 12:28:18 UTC 
Class Changed
From-To: sw-bug->change-request
Comment 8 Edwin Groothuis freebsd_committer freebsd_triage 2005-10-21 12:28:27 UTC 
Class Changed
From-To: change-request->sw-bug
Comment 9 Edwin Groothuis freebsd_committer freebsd_triage 2005-11-26 01:42:15 UTC 
State Changed
From-To: open->feedback

Can you try the 2005-10-30 version of the ultimedia/pvr250 which 
has just been updated?
Comment 10 Šimun Mikecin 2005-12-02 22:37:03 UTC 
Minor patching is needed for the port Makefile since
'make patch && make patch-iicbb' is broken with this
commit on FreeBSD >=5.x cause patching is now for
three instead of one file (iicbb.c)
This line in the port makefile:
   
${PATCH} /usr/src/sys/dev/iicbus/iicbb.c
${WRKDIR}/dev/cxm/Patch.iicbb-fbsd5; \
   
Should be replaced with something like:
   
${PATCH} -d/sys <${WRKDIR}/dev/cxm/Patch.iicbb-fbsd5;
\
    
With the Makefile patched I have successfully tested
cxm device on the FreeBSD/amd64 6.0-STABLE, so I think
both PR/85433 and PR/87518 should be closed once this
patch is commited.



		
__________________________________________ 
Yahoo! DSL  Something to write home about. 
Just $16.99/mo. or less. 
dsl.yahoo.com
Comment 11 Edwin Groothuis freebsd_committer freebsd_triage 2005-12-03 02:18:57 UTC 
State Changed
From-To: feedback->closed

Should be fixed now, thanks!