Bug 90147 - [MAINTAINER UPDATE] games/quake2-data: redesign, patch dependant ports
Summary: [MAINTAINER UPDATE] games/quake2-data: redesign, patch dependant ports
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-09 16:10 UTC by Alejandro Pulver
Modified: 2005-12-28 21:16 UTC (History)
0 users

See Also:

Attachments
quake2_all.diff (2.24 KB, patch)
2005-12-09 16:10 UTC, Alejandro Pulver 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alejandro Pulver 2005-12-09 16:10:03 UTC 

- Changed quake2-data/Makefile.include to be more similar to bsd.*.mk files, also it doesn't override port's variables.
- Change dependant ports.
Comment 1 Renato Botelho freebsd_committer freebsd_triage 2005-12-09 17:09:53 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->garga

I'll take it.
Comment 2 Renato Botelho freebsd_committer freebsd_triage 2005-12-14 09:16:31 UTC 
Responsible Changed
From-To: garga->freebsd-ports-bugs

My vacation is comming and i don't have time to finnish tests 
accordingly, so, back to the pool.
Comment 3 Tim Bishop freebsd_committer freebsd_triage 2005-12-14 10:01:53 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->tdb

I'll look at this.
Comment 4 Tim Bishop freebsd_committer freebsd_triage 2005-12-16 11:38:10 UTC 
State Changed
From-To: open->feedback

Waiting on response from maintainer of games/quake2lnx (danfe@).
Comment 5 Alejandro Pulver 2005-12-20 14:15:05 UTC 
>Submitter-Id:	current-users 
>Originator:	Alejandro Pulver 
>Organization:	 
>Confidential:	no 
>Synopsis:	Re: ports/90147: [MAINTAINER UPDATE] games/quake2-data: redesign, patch dependant ports 
>Severity:	non-critical 
>Priority:	low 
>Category:	ports 
>Class:		maintainer-update 
>Release:	FreeBSD 5.4-RELEASE i386 
>Environment:


System: FreeBSD 5.4-RELEASE #0: Sat May 21 12:14:47 ART 2005
    root@ale.varnet.bsd:/usr/src/sys/i386/compile/ATHLON-ALE



>Description:


This patch replaces the previous one for "games/quake2lnx". The problem is that DATADIR was added to MAKE_ENV twice (the second time in quake2-data/Makefile.include).


>How-To-Repeat:





>Fix:


--- quake2lnx.diff begins here ---
diff -urN /usr/ports/games/quake2lnx/Makefile quake2lnx/Makefile
--- /usr/ports/games/quake2lnx/Makefile	Fri Nov 18 07:02:24 2005
+++ quake2lnx/Makefile	Mon Dec 12 16:18:57 2005
@@ -45,8 +45,10 @@
 		X11		"Build X11 software driver" on \
 		X86_ASM		"Enable use of x86 assembly code" on
 
+DATADIR=	${Q2DIR}
+
 ALL_TARGET=	build_release
-MAKE_ENV=	DATADIR="${DATADIR}" LIBDIR="${LIBDIR}"
+MAKE_ENV=	LIBDIR="${LIBDIR}"
 
 PLIST_SUB+=	LIBDIR="${LIBDIR:S/${PREFIX}\///}"
 
--- quake2lnx.diff ends here ---
Comment 6 Tim Bishop freebsd_committer freebsd_triage 2005-12-21 12:50:26 UTC 
Responsible Changed
From-To: tdb->freebsd-ports-bugs

I'll be mostly offline for the next couple of weeks, so returning 
this to the pool so somebody else can pick it up.
Comment 7 Edwin Groothuis freebsd_committer freebsd_triage 2005-12-28 21:15:39 UTC 
State Changed
From-To: feedback->closed

Third time lucky! 
Committed, thanks!GNATS: Lines beginning with "GNATS:" will be deleted.