FreeBSD 4.x does not have SIZE_MAX in stdint.h, so define it if not already defined in xheader.c Port maintainer (naddy@FreeBSD.org) is cc'd. Generated with FreeBSD Port Tools 0.63
Responsible Changed From-To: freebsd-ports-bugs->naddy Over to maintainer
Tod McQuillin wrote: > [...] > FreeBSD 4.x does not have SIZE_MAX in stdint.h, so define it if > not already defined in xheader.c Instead of 'SIZE_MAX', wouldn't it be more consistent with the other calls of decode_num() if we used 'TYPE_MAXIMUM (size_t)'? This would be in line with the structure definitions in gtar's 'tar.h', and it ought to work on all branches and architectures. It certainly does on 4.x. Uwe -- Uwe Doering | EscapeBox - Managed On-Demand UNIX Servers gemini@geminix.org | http://www.escapebox.net
On Fri, 10 Mar 2006, Uwe Doering wrote: > Tod McQuillin wrote: >> [...] >> FreeBSD 4.x does not have SIZE_MAX in stdint.h, so define it if >> not already defined in xheader.c > > Instead of 'SIZE_MAX', wouldn't it be more consistent with the other > calls of decode_num() if we used 'TYPE_MAXIMUM (size_t)'? This would be > in line with the structure definitions in gtar's 'tar.h', and it ought > to work on all branches and architectures. It certainly does on 4.x. Sure, either way is fine with me. -- Tod
Uwe Doering: > Instead of 'SIZE_MAX', wouldn't it be more consistent with the other > calls of decode_num() if we used 'TYPE_MAXIMUM (size_t)'? This would be > in line with the structure definitions in gtar's 'tar.h', and it ought > to work on all branches and architectures. It certainly does on 4.x. Well, the SIZE_MAX use is verbatim from 1.15.90 (alpha), and #define SIZE_MAX is used all over lib/*.c, so it's just as consistent. -- Christian "naddy" Weisgerber naddy@mips.inka.de
State Changed From-To: open->closed Tod's fix committed, thanks.