Bug 96273 - [MAINTAINER]: Unbreak net/bittwist on 5.x.
[MAINTAINER]: Unbreak net/bittwist on 5.x.
Status: Closed FIXED
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s)
Any Any
: Normal Affects Only Me
Assigned To: FreeBSD ports mailing list
Depends on:
  Show dependency treegraph
Reported: 2006-04-24 19:20 UTC by wxs
Modified: 2006-04-25 12:29 UTC (History)
0 users

See Also:

file.diff (1.22 KB, patch)
2006-04-24 19:20 UTC, wxs
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description wxs 2006-04-24 19:20:18 UTC
net/bittwist uses round() which is only available in 5.3 and higher.  It
also depends upon a relatively recent version of libpcap which only
exists in the base of 6.0 and up[1].  The attached patch marks it as
broken on 5.2 and lower, and depends on net/libpcap for 5.3 up to 6.0.

While I'm here it also incorporates a patch to fix up the hardcoding of
CFLAGS and CC in the port's Makefile[2].

I guess this will teach me to keep a 5.x VM handy.  :(

[1]: Pointed out to me by Kris Kennaway via pointyhat.
[2]: Pointed out to me by Kris Kennaway.

How-To-Repeat: N/A
Comment 1 vs freebsd_committer 2006-04-25 12:28:26 UTC
State Changed
From-To: open->closed

Committed with minor modification: through MAKE_ARGS it's possible 
to avoid patching the Makefile. 

You might want to consider droppping pkg-plist in favour of 
PLIST_FILES on a future update ("Save an inode today"-campaign :)