Bug 96451 - update 7 ports - chase MASTER_SITE_MOZDEV
Summary: update 7 ports - chase MASTER_SITE_MOZDEV
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Renato Botelho
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-28 08:30 UTC by Andrew Pantyukhin
Modified: 2006-05-12 12:09 UTC (History)
0 users

See Also:

Attachments
mozdev.diff (4.37 KB, patch)
2006-04-28 08:30 UTC, Andrew Pantyukhin 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Pantyukhin 2006-04-28 08:30:13 UTC 
Use MASTER_SITE_MOZDEV where appropriate
Consequences tested in each case manually
Comment 1 Renato Botelho freebsd_committer freebsd_triage 2006-04-28 12:15:39 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->garga

I'll take it.
Comment 2 Renato Botelho freebsd_committer freebsd_triage 2006-04-28 12:30:10 UTC 
Dear maintainers,

One of your ports is involved in this PR:

http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/96451

It's a simple change just using new ${MASTER_SITE_MOZDEV} entry
created in bsd.sites.mk.

Could you please take a look and tell me if you approve this change?

Thanks
-- 
Renato Botelho <garga @ FreeBSD.org>
               <freebsd @ galle.com.br>
GnuPG Key: http://www.FreeBSD.org/~garga/pubkey.asc
Comment 3 Renato Botelho freebsd_committer freebsd_triage 2006-04-28 12:33:47 UTC 
State Changed
From-To: open->feedback

Ask for maintainer approval.
Comment 4 mjl 2006-04-29 10:20:09 UTC 
> One of your ports is involved in this PR:
> 
> http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/96451

My port is mail/thunderbird-dictionaries.

The change to my port included in the PR is incorrect.  It should be as
below.  I approve this change.

--- Makefile.orig       Fri Feb 24 08:42:02 2006
+++ Makefile    Sat Apr 29 21:03:47 2006
@@ -9,14 +9,8 @@
 PORTNAME=      thunderbird-dictionaries
 PORTVERSION=   20060220
 CATEGORIES=    mail
-MASTER_SITES=  http://mozdev.dns4.com/dictionaries/ \
-               http://ftp.heanet.ie/pub/mozdev/dictionaries/ \
-               http://mozdev.oregonstate.edu/dictionaries/ \
-               http://mirror.meisterwerk.net/rmozdev/dictionaries/ \
-               http://ftp.ntua.gr/pub/www/mozdev/dictionaries/ \
-               http://www.devlib.org/mozdev/dictionaries/ \
-               http://ftp.iasi.roedu.net/mirrors/mozdev.org/dictionaries/ \
-               http://mozdev.archive.hk/dictionaries/
+MASTER_SITES=  ${MASTER_SITE_MOZDEV}
+MASTER_SITE_SUBDIR=    dictionaries
 DISTFILES=     # filled in later after options
 DIST_SUBDIR=   thunderbird
Comment 5 mjl 2006-04-29 12:07:57 UTC 
> I'm sorry if I'm being blind, I can't see a difference between
> your diff and mine. Please do tell me what's wrong.

my mistake, for some reason i read the MASTER_SITE_SUBDIR as

MASTER_SITE_SUBDIR=     ${PORTNAME}/src

when in fact you had it right and i was stupid.

sorry about that

Matthew
Comment 6 Andrew Pantyukhin 2006-04-29 12:17:40 UTC 
On 4/29/06, Matthew Luckie <mjl@luckie.org.nz> wrote:
> > I'm sorry if I'm being blind, I can't see a difference between
> > your diff and mine. Please do tell me what's wrong.
>
> my mistake, for some reason i read the MASTER_SITE_SUBDIR as

I thought so, too. I probably should have formatted it in a
different way, it's hard to read it right.

Thanks for your approval anyway!
Comment 7 Renato Botelho freebsd_committer freebsd_triage 2006-05-12 12:09:17 UTC 
State Changed
From-To: feedback->closed

Committed. Thanks!