Bug 97178 - lang/ruby18 improperly sets PKGNAMESUFFIX
Summary: lang/ruby18 improperly sets PKGNAMESUFFIX
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-12 17:40 UTC by Coleman Kane
Modified: 2006-05-15 13:43 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Coleman Kane freebsd_committer freebsd_triage 2006-05-12 17:40:12 UTC
	When building lang/ruby18, there are two tunables:
WITH_PTHREADS and WITH_ONIGURUMA
When WITH_ONIGURUMA=yes and WITH_PTHREADS=no (or unset), the 
PKGNAMESUFFIX is set to +oniguruma. When WITH_PTHREADS=yes, regardless of
the setting of WITH_ONIGURUMA, the PKGNAMESUFFIX is set to -pthreads.

	Firstly, the PKGNAMESUFFIX for WITH_PTHREADS should be set to
"+pthreads". In addition, the support for oniguruma should not be hidden by
WITH_PTHREADS.

	I think that the following naming is more reflective of the package's
tunables:
WITHOUT_PTHREADS && WITHOUT_ONIGURUMA -->  ruby-1.8.x_y,z
WITH_PTHREADS && WITHOUT_ONIGURUMA ----->  ruby+pthreads-1.8.x_y,z
WITHOUT_PTHREADS && WITH_ONIGURUMA ----->  ruby+oniguruma-1.8.x_y,z
WITH_PTHREADS && WITH_ONIGURUMA -------->  ruby+pthreads+oniguruma-1.8.x_y,z

Fix: 

Not 100% sure, but I think that where:
PKGNAMESUFFIX=	+oniguruma
...
PKGNAMESUFFIX=	-pthreads
        it should be:
PKGNAMESUFFIX+=	+oniguruma
...
PKGNAMESUFFIX+=	+pthreads

I do not know if the decision to make the above is a maintainer mistake, or
a limitation in the ports/pkg system.
How-To-Repeat: cd /usr/ports/lang/ruby18
make 
<look at package name>
make clean
make WITH_ONIGURUMA=yes
<look at package name>
make clean
make WITH_ONIGURUMA=yes WITH_PTHREADS=yes
<look at package name>
make clean
make WITH_PTHREADS=yes
<look at package name>
make clean
Comment 1 Pav Lucistnik freebsd_committer freebsd_triage 2006-05-15 13:42:50 UTC
State Changed
From-To: open->closed

Fixed in a different manner. Thank you!