Summary: | net/mosquitto: Update to 1.4.9 | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Iblis Lin <iblis.dif01> | ||||
Component: | Individual Port(s) | Assignee: | Olli Hauer <ohauer> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | CC: | joe, ler, ohauer | ||||
Priority: | --- | Keywords: | patch | ||||
Version: | Latest | Flags: | koobs:
maintainer-feedback?
(joe) |
||||
Hardware: | Any | ||||||
OS: | Any | ||||||
See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=208606 | ||||||
Bug Depends on: | 211189 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Iblis Lin
2016-07-18 09:34:02 UTC
A couple of requests: 1. Would you mind reviewing another patch for possibly merging your patch onto? It is referenced here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=208606 2. To ensure the patch is OK for commit, a build log from Poudriere is required. If you wouldn't mind, please attach this log to expedite your submission. Best Regards, -Joseph Benden Without the websocket option the patch looks good! Until now there is no port for net/libwebsockets ... Anyone Interested in maintaining the libwebsocket port? (I have an updated but not polished version flying around in my local tree, but not using it myself) I would love to see websocket support for mosquitto. I don't do a lot with it, but probably will do more. If no one else wants it, I can maintain it. Link to a current libwebsocket port http://people.freebsd.org/~ohauer/diffs/libwebsockets.shar (Build on 10.3 (amd64) OK, but not tested with what's wrong with https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211189? @Larry Oh, I haven't seen bug 211189. Will do some quick tests. Found a small issue in the new libwebsocket port bug #211189. vanilla@ is already working on the new port lets wait the work is committed. (In reply to joe from comment #1) poudriere testport: 10.3 release WS=off pass (https://gist.githubusercontent.com/iblis17/1f196d439e74c55cbf41111eff71a5c4/raw/1c1492444f5ab9930cc61b6ac26282afa10f4fc7/10.3-no-ws-mosquitto-1.4.9.log) 10.3 release WS=on pass (https://gist.githubusercontent.com/iblis17/1f196d439e74c55cbf41111eff71a5c4/raw/1c1492444f5ab9930cc61b6ac26282afa10f4fc7/10.3-with-ws-mosquitto-1.4.9.log) 9.3 release WS=off pass (https://gist.githubusercontent.com/iblis17/1f196d439e74c55cbf41111eff71a5c4/raw/a1661c411acd1e69573781db6e59c69868056b7f/9.3-no-ws-mosquitto-1.4.9.log) 9.3 release WS=on pass (https://gist.githubusercontent.com/iblis17/1f196d439e74c55cbf41111eff71a5c4/raw/0bdef07c702fcaecfcd6d8217a49f58e296d637f/9.3-with-ws-mosquitto-1.4.9.log) @Joe, can we close bug 208606 as superseded by this issue? Please also: * Set maintainer-approval to + on attachments for ports you are maintainer of: Attachment -> Details -> maintainer-approval [+] Attachment 172635 [details] currently requires your approval in order for this issue to proceed @All, QA logs are no longer required as attachments, nor as external links (links go stale). Feel free to mention that the changes in an issue pass QA as follows after testing: portlint: OK (looks fine.) testport: OK (poudriere: <archs>, <versions>, <options> tested) (In reply to Kubilay Kocak from comment #9) Okay! portlint: looks fine. testport: OK - amd64, 10.3-RELEASE-p5, WS=off, tested - amd64, 10.3-RELEASE-p5, WS=on, tested - amd64, 9.3-RELEASE-p44, WS=off, tested - amd64, 9.3-RELEASE-p44, WS=on, tested A commit references this bug: Author: ohauer Date: Wed Jul 20 18:27:21 UTC 2016 New revision: 418845 URL: https://svnweb.freebsd.org/changeset/ports/418845 Log: - update to 1.4.9 - add optional websocket support Changelog: https://raw.githubusercontent.com/eclipse/mosquitto/master/ChangeLog.txt PR: 211190 Submitted by: Iblis Lin (iblis_at_hs.ntnu.edu.tw) Approved by: maintainer (joe_at_thrallingpenguin.com) Changes: head/net/mosquitto/Makefile head/net/mosquitto/distinfo head/net/mosquitto/files/patch-CMakeLists.txt Committed, Thanks for the work on mosquitto and websocket support! |