Summary: | games/anki: Missing dependency lame when installed from official package repositories | ||
---|---|---|---|
Product: | Ports & Packages | Reporter: | Pau Amma <pauamma> |
Component: | Individual Port(s) | Assignee: | Kai Knoblich <kai> |
Status: | Closed FIXED | ||
Severity: | Affects Only Me | Flags: | kai:
maintainer-feedback+
kai: merge-quarterly? |
Priority: | --- | ||
Version: | Latest | ||
Hardware: | Any | ||
OS: | Any | ||
See Also: |
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230034 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228441 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=242529 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=257457 |
Description
Pau Amma
2019-12-09 20:06:44 UTC
(In reply to PauAmma from comment #0) Thank you for the report. Unfortunately the audio/lame port isn't available as a binary package due licensing concerns (see also bug #228441) thus one has to compile/install that port manually. Last year the audio/lame port was available as binary package for a short period of time but it was unintentional (see also bug #230034). Maybe a short pkg-message for games/anki would be useful which gives some advice regarding the issue with audio/lame? (In reply to Kai Knoblich from comment #1) > Maybe a short pkg-message for games/anki would be useful which gives some > advice regarding the issue with audio/lame? You mean, something like: [ { type: install message: <<EOM games/anki needs audio/lame, which cannot be provided as a package for licensing reasons. To complete installation, install audio/lame from ports. EOM } { type: remove message: <<EOM games/anki needed audio/lame installed as a port, even when itself installed as a package. If audio/lame is no longer needed by anything else, you can safely remove it from ports. EOM } ] ? (In reply to PauAmma from comment #2) Indeed, that looks pretty good! I'm going to commit it later that evening. A commit references this bug: Author: kai Date: Wed Dec 11 19:26:20 UTC 2019 New revision: 519830 URL: https://svnweb.freebsd.org/changeset/ports/519830 Log: games/anki: Add pkg-message with installation instructions * Improve the user experience by adding a pkg-message which gives some advice that audio/lame needs to be installed manually afterwards when installing from the official FreeBSD package repositories. * Bump PORTREVISION to include the pkg-message. PR: 242528 Submitted by: PauAmma <pauamma@gundo.com> (based on) MFH: 2019Q4 Changes: head/games/anki/Makefile head/games/anki/pkg-message Committed to the head branch, thank you for reporting the issue and the first draft of the pkg-message! I edited the pkg-message a bit to make it clearer under what circumstances the audio/lame port needs to be manually installed and why FreeBSD's official package repositories don't provide a binary package for it. I also omitted the "remove" section as it's mostly used to remind people which files/directories should be deleted when a package is uninstalled. By setting audio/lame as automatic via "pkg set -A1 lame" (as described in the pkg-message) one can remove that port after uninstall of games/anki with "pkg autoremove". Once I get the approval from the ports-secteam I'll MFH'ing it to the 2019Q4 branch. (In reply to Kai Knoblich from comment #5) Thanks for taking the time to explain why the changes from my draft. A commit references this bug: Author: kai Date: Sat Dec 14 11:42:06 UTC 2019 New revision: 520114 URL: https://svnweb.freebsd.org/changeset/ports/520114 Log: MFH: r519830 games/anki: Add pkg-message with installation instructions * Improve the user experience by adding a pkg-message which gives some advice that audio/lame needs to be installed manually afterwards when installing from the official FreeBSD package repositories. * Bump PORTREVISION to include the pkg-message. PR: 242528 Submitted by: PauAmma <pauamma@gundo.com> (based on) Approved by: ports-secteam (joneum) Changes: _U branches/2019Q4/ branches/2019Q4/games/anki/Makefile branches/2019Q4/games/anki/pkg-message (In reply to PauAmma from comment #6) Pleasure, you're welcome. Closing this PR now as all changes were committed. |