Bug 172149 - textproc/aspell ignores NLS option
Summary: textproc/aspell ignores NLS option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: FreeBSD Office Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-28 19:30 UTC by Gennady Proskurin
Modified: 2012-09-28 20:20 UTC (History)
0 users

See Also:


Attachments
file.diff (482 bytes, patch)
2012-09-28 19:30 UTC, Gennady Proskurin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gennady Proskurin 2012-09-28 19:30:08 UTC
textproc/aspell always depends on gettext, ignoring NLS option

Bug was introduced in revision 1.102
See also 1.86-1.87 patch

Fix: patch attached


Patch attached with submission follows:
How-To-Repeat: Turn off NLS option, and then:
/usr/ports/textproc/aspell % make depends
===>   aspell-0.60.6.1_2 depends on file: /usr/local/bin/perl5.14.2 - found
===>   aspell-0.60.6.1_2 depends on file: /usr/local/bin/perl5.14.2 - found
===>   aspell-0.60.6.1_2 depends on shared library: iconv.3 - found
===>   aspell-0.60.6.1_2 depends on shared library: intl - found
===>   aspell-0.60.6.1_2 depends on executable: gmake - found
===>   aspell-0.60.6.1_2 depends on file: /usr/local/bin/perl5.14.2 - found

You see intl dependency
Comment 1 Edwin Groothuis freebsd_committer 2012-09-28 19:30:21 UTC
Responsible Changed
From-To: freebsd-ports-bugs->office

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer 2012-09-28 20:10:19 UTC
Author: bapt
Date: Fri Sep 28 19:10:04 2012
New Revision: 305008
URL: http://svn.freebsd.org/changeset/ports/305008

Log:
  Do not depend on gettext if NLS is off
  
  PR:		ports/172149
  Submitted by:	Gennady Proskurin <gpr@mail.ru>

Modified:
  head/textproc/aspell/Makefile

Modified: head/textproc/aspell/Makefile
==============================================================================
--- head/textproc/aspell/Makefile	Fri Sep 28 18:45:58 2012	(r305007)
+++ head/textproc/aspell/Makefile	Fri Sep 28 19:10:04 2012	(r305008)
@@ -39,7 +39,6 @@ SUB_LIST=		VERINST=${VERINST}
 USE_GETTEXT=		yes
 PLIST_SUB+=		NLS=""
 .else
-USE_GETTEXT=	yes
 CONFIGURE_ARGS+=	--disable-nls
 PLIST_SUB+=		NLS="@comment "
 .endif
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Baptiste Daroussin freebsd_committer 2012-09-28 20:17:23 UTC
State Changed
From-To: open->closed

Committed. Thanks!