Update port mail/assp to 14040 build. These are slow coming because I have to bake the software for a few weeks to ensure there are no bugs and I found some in some previous versions.
Class Changed From-To: update->maintainer-update Fix category (submitter is maintainer) (via the GNATS Auto Assign Tool)
Any word on if this can be committed? :) Thanks! Rusty Nejdl
Following up again. Can this please be committed? Thanks! Rusty
Stumbling upon this .... Comments: 1) The fixes don't include stage support, which is mandatory now 2) The patch set includes several files that aren't actually changed: - files/510.assp.in - files/assp.in - files/patch-assp.pl - files/pkg-install.in 3) the assp.pl patch doesn't end in a new line (see patchset) 4) :U is used, that's got to be changed to :tu now In this case, the use of git hurt. The patchset was blindly generated without noticing either the non-function svnid changes or the missing carriage return. I would fix these problems, then submit a new PR that has the words "support stage" in the title, with a new patch and then ask for the old PR to be closed. I suggest this approach because ports that support stage will be noticed first.
On 2014-05-13 01:31, John Marino wrote: > Stumbling upon this .... > > Comments: > 1) The fixes don't include stage support, which is mandatory now > 2) The patch set includes several files that aren't actually changed: > - files/510.assp.in > - files/assp.in > - files/patch-assp.pl > - files/pkg-install.in > 3) the assp.pl patch doesn't end in a new line (see patchset) > 4) :U is used, that's got to be changed to :tu now > > In this case, the use of git hurt. The patchset was blindly generated > without noticing either the non-function svnid changes or the missing > carriage return. > > I would fix these problems, then submit a new PR that has the words > "support stage" in the title, with a new patch and then ask for the old > PR to be closed. I suggest this approach because ports that support > stage will be noticed first. Marino, I'm working on this today since I have a quiet moment. Any suggestions on #3? Rusty
#3 just means that the very last character of the file is not a carriage return. Just go to the end, add a carriage return, and resave the file. John
This PR should be closed as it will be superceded by another PR that includes a further update, staging support, and a MySQL include fix. Rusty Nejdl
Superseded by 191635 *** This bug has been marked as a duplicate of bug 191635 ***