Created attachment 147238 [details] Patch to update net/miniupnpd to latest upstream version 1.8.20140906 Attached patch updates net/miniupnpd to latest upstream revision 1.8.20140906.
Created attachment 147293 [details] Fixes miniupnpd on -HEAD (r270870+) Due to rearrangements in the base miniupnpd fails to compile without this patch. This was fixed by glebius@ This should replace the source file ./bsd Maintainer is also notified
Should that maybe go into a separate PR?
Per request by glebius@ and razzfazz I've made a new PR https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193633
HEAD fix-up is now being tracked in PR 193633. Looks like it's not possible to remove attachments from a PR, but just to be clear, for this PR here (193577), please only consider the first patch (update to latest upstream).
miniupnc is at version 1.9 already.
It's true that miniupnp*c* is at 1.9; however, miniupnp*d* is a completely separate port, and upstream for that is still at 1.8.
That said, this issue has now been waiting for maintainer approval for a month and a half. I believe this satisfies the criterion for maintainer timeout, so can we get this moved forward?
I'll move to maintainer timeout if you explain why there are two attachments. The patch is obvious but I don't know what to do with the other one.
please only let freebsd@ people move to patch ready. I'm surprised you had the ability to do it.
Sorry about that. Not sure how that happened, either; right now, I only see "open", "issue resolved" and "timeout" as options in the status drop-down.
In any case, the second patch ("Fixes miniupnpd on -HEAD (r270870+)") was attached to this issue by someone else, who then proceeded to open a separate issue for it. It really should just be removed, but I haven't found a way to delete it.
(The PR for the other patch is 193633.)
Comment on attachment 147293 [details] Fixes miniupnpd on -HEAD (r270870+) Unwanted; added by 3rd party. Hide to avoid confusion.
Okay, so are you saying patches on both bug 193633 and this one (bug 193577) have to be committed? If so, can you just combine them to one new patch and withdraw one PR (probably 193633) ?
See my comment in the other thread; the patch in PR 193633 was already upstreamed, so I don't think it needs to (or should) be committed to the port any more.
I assume that I can't withdraw the other PR since I'm not the one who created it?!
I just noticed that a new version of miniupnpd (1.8.20141022) has been released in the meantime. That version should contain the changes requested in PR 193633. Do you want me to rebase my patch to that version?
please do.
*** Bug 193633 has been marked as a duplicate of this bug. ***
Created attachment 148824 [details] Patch to update net/miniupnpd to latest upstream version 1.8.20141022
Update to miniupnpd-1.8.20141022,1 looks good to me.
approved by maintainer, move to patch-ready pool.
I did submit a new patch (194812) to update net/miniupnpd to 1.9 (released five days after 1.8.20141022) against what was in the ports tree an hour ago. Sorry for the unnecessary work that may have generated. Just submit this one first and I can submit a new patch in that bug, against what will be in the ports tree after this one is submitted.
A commit references this bug: Author: marino Date: Tue Nov 4 21:11:13 UTC 2014 New revision: 372172 URL: https://svnweb.freebsd.org/changeset/ports/372172 Log: net/miniupnpd: Upgrade version 1.8.20140523 => 1.8.20141022 PR: 193577 Submitted by: razzfazz (gmail) Approved by: maintainer (Tor Halvard Furulund) Changes: head/net/miniupnpd/Makefile head/net/miniupnpd/distinfo head/net/miniupnpd/files/patch-Makefile
Okay, done!