Created attachment 148494 [details] ports tar Please, add new port prepared by Horst Leitenmueller with me as maintainer. Thanks!
please resubmit as a shar file as outlined here: https://www.freebsd.org/doc/en/books/porters-handbook/porting-submitting.html
Created attachment 148865 [details] Shar with port
two problems: 1) the @dirrm lines are obsolete. The latest portlint probably confirms this. 2) this line: X ${MKDIR} ${STAGEDIR}${PREFIX}/wildfly-${PORTVERSION} && cd ${WRKSRC} && ${FIND} . | ${CPIO} -pdmu -R ${USER}:${GROUP} ${STAGEDIR}${PREFIX}/wildfly-${PORTVERSION} That needs to be split up. We assume each line is successful. It would probably be something like: @${MKDIR} ${STAGEDIR}${PREFIX}/wildfly-${PORTVERSION} (cd ${WRKSRC} && ${FIND} . | ${CPIO} -pdmu -R ${USER}:${GROUP} ${STAGEDIR}${PREFIX}/wildfly-${PORTVERSION}) Except that second line is wrong too. You need to use ${COPYTREE_SHAR} macro, not $CPIO with roll-your-own permissions settings also, do you have the ability to provide poudriere logs proving this port is fully tested with stage-qa checks? (e.g. poudriere bulk -t or poudriere testport commands). If yes, please attach the log. This is really important for new ports.
No, don't have logs, tested this port manually. If they are mandatory - will provide in a week probably.
(In reply to yerenkow from comment #4) > No, don't have logs, tested this port manually. > If they are mandatory - will provide in a week probably. A week is fine. I can't claim they are "mandatory" (yet), but it is in your very best interest to provide those logs. Often you find problems with your port in the process, so when you finally submit it, it's in really good shape. FYI: if you don't do it, a committer is going to and he's just going to kick it back if there are problems so you might as well know first.
Created attachment 149325 [details] Poudriere log
(In reply to yerenkow from comment #6) > Created attachment 149325 [details] > Poudriere log Hmmm. Thanks, but why didn't you upload the updated shar first? I pointed out several problems to address in comment 3. Also, you have PORTREVISION=1 which is wrong for a new port. It shouldn't be defined at all. Please remove it, the dirrmtry lines, use COPYTREE_SHARE, etc, and then upload a new poudriere log to prove it still works, thanks.
Created attachment 149360 [details] Shar with fixed port
Created attachment 149361 [details] Poudriere log for fixed port
Comment on attachment 149360 [details] Shar with fixed port set MIMI to text/plain instead of application/x-shar
X@dir %%APP_HOME%%/.installation X@dir %%APP_HOME%%/appclient/configuration X@dir %%APP_HOME%%/appclient X@dir %%APP_HOME%%/bin/client X@dir %%APP_HOME%%/bin X@dir %%APP_HOME%%/docs/examples/configs no. I said remove the lines, not replace them. Why did you put @dir lines here? Do you know what @dir is used for? Read /usr/ports/CHANGES if you are not sure.
Created attachment 149362 [details] Port without @dir
But when I removed @dir I got check-plist phase error
Comment on attachment 149362 [details] Port without @dir Please set MIME type to text/plain!
(In reply to yerenkow from comment #13) > But when I removed @dir I got check-plist phase error Where? %%APP_HOME%% is in the PREFIX so it doesn't need it.
Created attachment 149364 [details] Log file with error
Error: Orphaned: @dir %%APP_HOME%%/.installation Error: Orphaned: @dir %%APP_HOME%%/domain/data/content Error: Orphaned: @dir %%APP_HOME%%/domain/tmp/auth Error: Orphaned: @dir %%APP_HOME%%/standalone/lib/ext Error: Orphaned: @dir %%APP_HOME%%/standalone/tmp/auth This means you have empty directories in STAGEDIR that you don't have in your pkg-plist. If you really want to install empty directories, you need to use @dir. I doubt this is the case for .installation, so you need to remove the directories, e.g.. post-install: ${RM} -f ${STAGEDIR}${APP_HOME}/.installation \ ${STAGEDIR}${APP_HOME}/domain/tmp/auth
Except for .installation, this dirs are required, I'll add four @dir and one rm then
Created attachment 149371 [details] Latest shar with port
Created attachment 149372 [details] Latest success build
Comment on attachment 149371 [details] Latest shar with port This is the third time I've asked you to properly set the MIME type when you upload a shar as an attachment. __PLEASE__ be careful.
Comment on attachment 149372 [details] Latest success build log MIME is text/plain too.
I only see one minor issue. You have both do-install and post-install targets. You only need one. CHANGE: Xdo-install: X ${MKDIR} ${STAGEDIR}${PREFIX}/wildfly-${PORTVERSION} X cd ${WRKSRC} && ${COPYTREE_SHARE} . ${STAGEDIR}${PREFIX}/wildfly-${PORTVERSION} X chmod +x ${STAGEDIR}${PREFIX}/wildfly-${PORTVERSION}/bin/*.sh X Xpost-install: X ${RMDIR} ${STAGEDIR}${PREFIX}/wildfly-${PORTVERSION}/.installation TO: Xdo-install: X ${MKDIR} ${STAGEDIR}${PREFIX}/wildfly-${PORTVERSION} X cd ${WRKSRC} && ${COPYTREE_SHARE} . ${STAGEDIR}${PREFIX}/wildfly-${PORTVERSION} X chmod +x ${STAGEDIR}${PREFIX}/wildfly-${PORTVERSION}/bin/*.sh X ${RMDIR} ${STAGEDIR}${PREFIX}/wildfly-${PORTVERSION}/.installation Make that change, upload a new shar (text/plain MIME type please) and then I'll promote the PR. You don't need to upload a new poudriere test log.
ah, quick hit change: cd ${WRKSRC} && ${COPYTREE_SHARE} . ${STAGEDIR}${PREFIX}/wildfly-${PORTVERSION} to: (cd ${WRKSRC} && ${COPYTREE_SHARE} . ${STAGEDIR}${PREFIX}/wildfly-${PORTVERSION}) (parentheses)
Sorry for Mime, filed bug based on your comments: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194990
Created attachment 149373 [details] Latest shar with port
okay, this looks good, thus I will promote the PR to the patch-ready pool.
A commit references this bug: Author: pi Date: Sat Nov 22 17:29:52 UTC 2014 New revision: 373081 URL: https://svnweb.freebsd.org/changeset/ports/373081 Log: New port: java/wildfly81 WildFly is a flexible, lightweight, managed application runtime that helps you build amazing applications. WildFly - new name for JBoss Application Server Fast Startup Small Footprint Modular Design Unified Configuration and Management And of course Java EE! WWW: http://wildfly.org PR: 194478 Submitted by: yerenkow@gmail.com Changes: head/java/Makefile head/java/wildfly81/ head/java/wildfly81/Makefile head/java/wildfly81/distinfo head/java/wildfly81/files/ head/java/wildfly81/files/patch-bin-add-user.sh head/java/wildfly81/files/wildfly81.in head/java/wildfly81/pkg-descr head/java/wildfly81/pkg-message head/java/wildfly81/pkg-plist
Committed, thanks. Can java/wildfly80 be removed (soonish) ?