Bug 200764 - [patch] emulators/virtualbox-ose: various dependency / bug fixes, convert USE(S) to OPTIONS helpers
Summary: [patch] emulators/virtualbox-ose: various dependency / bug fixes, convert USE...
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Virtualbox Team (Nobody)
URL:
Keywords: patch
Depends on:
Blocks: 187030 188982 195365 201946
  Show dependency tree / graph
 
Reported: 2015-06-10 13:41 UTC by Andriy Voskoboinyk
Modified: 2020-10-05 00:08 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (vbox)

Attachments
Makefile.diff (478 bytes, patch)
2015-06-10 13:41 UTC, Andriy Voskoboinyk 		no flags Details | Diff
poudriere-10.1-amd64.log.txz (65.96 KB, application/x-xz)
2015-06-10 13:46 UTC, Andriy Voskoboinyk 		no flags Details
Patch.diff (6.84 KB, patch)
2015-08-08 13:51 UTC, Andriy Voskoboinyk 		no flags Details | Diff
portlint.log (14.10 KB, text/plain)
2015-08-08 13:54 UTC, Andriy Voskoboinyk 		no flags Details
poudriere.txz (127.75 KB, application/x-xz)
2015-08-08 13:55 UTC, Andriy Voskoboinyk 		no flags Details
Patch2.diff (6.98 KB, patch)
2015-08-09 15:36 UTC, Andriy Voskoboinyk 		no flags Details | Diff
Patch3.diff (5.89 KB, patch)
2018-01-06 21:28 UTC, Andriy Voskoboinyk 		no flags Details | Diff
portlint.log (9.70 KB, text/plain)
2018-01-06 21:29 UTC, Andriy Voskoboinyk 		no flags Details
poudriere.txz (298.19 KB, application/x-xz)
2018-01-06 21:30 UTC, Andriy Voskoboinyk 		no flags Details
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andriy Voskoboinyk freebsd_committer 2015-06-10 13:41:30 UTC 
Created attachment 157612 [details]
Makefile.diff

This change significantly reduces number of build dependencies.
Comment 1 Andriy Voskoboinyk freebsd_committer 2015-06-10 13:46:48 UTC 
Created attachment 157613 [details]
poudriere-10.1-amd64.log.txz
Comment 2 Andriy Voskoboinyk freebsd_committer 2015-06-10 13:53:47 UTC 
Is there any runtime dependency on libIDL?
Comment 3 Andriy Voskoboinyk freebsd_committer 2015-08-08 13:51:51 UTC 
Created attachment 159668 [details]
Patch.diff

- Move libIDL and libxslt to build-time dependencies (binaries have no references to them).
- Add libxml2 to LIB_DEPENDS.
- Fix bug 187030:
-- Remove check_xrandr from configure - it is not used here.
-- Remove GL/glu.h header check.
-- Add dependency for libGL (X11).
-- Add an additional check for SDL (x11 field is used by src/VBox/Frontends/VBoxSDL/VBoxSDL.cpp).
- Add a workaround for bug 201946, bug 188982 and bug 195365 (field for padding in src/VBox/Devices/Graphics/DevVGA.h (i386 only)).
- Use option helpers for *_USE / USES.
- Strip shared libraries when DEBUG=off.
- Install sdk symbolic link only when PYTHON or WEBSERVICE option is used.
- Bump PORTREVISION.
Comment 4 Andriy Voskoboinyk freebsd_committer 2015-08-08 13:54:13 UTC 
Created attachment 159669 [details]
portlint.log
Comment 5 Andriy Voskoboinyk freebsd_committer 2015-08-08 13:55:50 UTC 
Created attachment 159670 [details]
poudriere.txz
Comment 6 Andriy Voskoboinyk freebsd_committer 2015-08-09 15:36:51 UTC 
Created attachment 159694 [details]
Patch2.diff

- Fix staging as non-root.
Comment 7 Andriy Voskoboinyk freebsd_committer 2018-01-06 21:28:45 UTC 
Created attachment 189473 [details]
Patch3.diff

Rebase the patch (+ drop unneeded workaround)
Comment 8 Andriy Voskoboinyk freebsd_committer 2018-01-06 21:29:37 UTC 
Created attachment 189474 [details]
portlint.log
Comment 9 Andriy Voskoboinyk freebsd_committer 2018-01-06 21:30:17 UTC 
Created attachment 189475 [details]
poudriere.txz
Comment 10 Andriy Voskoboinyk freebsd_committer 2018-01-06 21:35:46 UTC 
> - Add a workaround for bug 201946, bug 188982 and bug 195365 (field for padding > in src/VBox/Devices/Graphics/DevVGA.h (i386 only)).

I cannot reproduce this issue with current VirtualBox version (5.2.4); other fixes are still here.
Comment 11 Gleb Popov freebsd_committer 2020-04-25 14:46:23 UTC 
Can this be rebased once more and take into account committed fixes?