I got this email, which suggests that commit hook for ports commit would make changes to the state, but they are (at least currently) supposed to add additional comments based on the commit messages only. ======= https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200537 Xin LI <delphij@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |Closed Resolution|--- |FIXED commit-hook@freebsd.org changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|Closed |New --- Comment #9 from Xin LI <delphij@FreeBSD.org> --- Got maintainer approval and fix committed. --- Comment #10 from commit-hook@freebsd.org --- A commit references this bug: Author: delphij Date: Wed Jun 10 20:29:40 UTC 2015 New revision: 389144 URL: https://svnweb.freebsd.org/changeset/ports/389144 Log: MFH: r389143 Security update to 1.5.5, while there also move the upstream to github. PR: 200537 Approved by: ports-secteam Changes: _U branches/2015Q2/ branches/2015Q2/databases/pgbouncer/Makefile branches/2015Q2/databases/pgbouncer/distinfo branches/2015Q2/databases/pgbouncer/pkg-descr -- You are receiving this mail because: You are on the CC list for the bug. ======
Add portmgr@ to Cc per suggestion from bugmeister.
@Xin, am I understanding correctly that this is a bug, defined by: "post-commit hook re-opens issue if referenced in commit log (PR: <id>), if the issue is already closed" Or is the report more general than that? My understanding at the moment is that the bug is this bit only: ======================= Resolution: FIXED → --- Status: Closed → New ======================= I'm trying to reconcile the statement in this issue summary that bugzilla 'should only make comments'. Do you mean it should *never* change state, or only *if* the issue is already closed, OR *already* in the state it was going to be in if bugzilla were to change it.
Found what appears to be another example of this in bug 211681
It's strange, I usually work on stuff, close the PR as I commit in git and dcommit when I'm done for the session/day, I never saw that happen.
Just hit this in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245098#c3 (commit-hook).
The three reported cases: with commit comment: Resolution: FIXED → --- Status: Closed → New with commit comment: Resolution: FIXED → --- Status: Closed → Open without commit comment: Resolution: FIXED → --- Status: Closed → Open
MARKED AS SPAM