Bug 201396 - [NEW PORT] databases/py-pysqlcipher: Python bindings for SQLCipher from https://leap.se
Summary: [NEW PORT] databases/py-pysqlcipher: Python bindings for SQLCipher from https...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Martin Wilke
URL:
Keywords: feature, needs-patch, patch
Depends on:
Blocks:
 
Reported: 2015-07-07 08:43 UTC by Yuri Victorovich
Modified: 2016-03-14 02:35 UTC (History)
2 users (show)

See Also:
yuri: maintainer-feedback+


Attachments
shar archive (3.72 KB, application/shar)
2015-07-07 08:43 UTC, Yuri Victorovich
no flags Details
poudriere log (24.67 KB, text/plain)
2015-07-07 08:43 UTC, Yuri Victorovich
no flags Details
Updated shar (3.81 KB, text/plain)
2015-07-07 08:53 UTC, Yuri Victorovich
no flags Details
Updated shar (3.45 KB, text/plain)
2015-07-07 11:19 UTC, Yuri Victorovich
no flags Details
Updated shar (1.78 KB, text/plain)
2015-07-14 09:11 UTC, Yuri Victorovich
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2015-07-07 08:43:03 UTC
Created attachment 158481 [details]
shar archive
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2015-07-07 08:43:57 UTC
Created attachment 158482 [details]
poudriere log
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2015-07-07 08:45:13 UTC
Github https://github.com/leapcode/pysqlcipher is an upstream maintained by the original author.

This is why I set it as a source instead of CHEESESHOP.
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2015-07-07 08:53:06 UTC
Created attachment 158483 [details]
Updated shar

Fixed stripping problem.
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2015-07-07 10:06:17 UTC
Review changes needed:

 * LICENSE is ZLIB/LIBPNG (See upstream setup.py and licence file)
 * Needs to use databases/sqlcipher, not a downloaded or bundled amalgamation (like the SQLite port)

Additionally:

 * Poudriere log is for Python 2.7 but USES=python is set (allowing 3.x). Please confirm this builds/runs with Python 3.x or limit use of python with :2.7

Regarding which MASTER_SITE to use, in this case the name/version is correct no matter which is used, but CHEESESHOP is preferred by default, as stated in bug 201384 comment 5
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2015-07-07 10:18:46 UTC
> * Needs to use databases/sqlcipher, not a downloaded or bundled amalgamation
(like the SQLite port)

This is the known issue, has been discussed many times with them. This is the way how this package is defined. We can't use databases/sqlcipher because database/py-pysqlcipher compiles it from sources, and databases/sqlcipher doesn't come with sources. This will be a significant change in the build process, inappropriate for port. Hopefully they will fix this.

https://github.com/leapcode/pysqlcipher/issues/21
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2015-07-07 10:29:10 UTC
(In reply to yuri from comment #5)

I understand both the need and the frustration. There are however quite a number of other ports (including Python ones) that have been required to patch out, or be modified to ignore the use of bundled libraries, and use system provided libraries instead.

It should be possible to have this port compile with the system/port version, given that the databases/sqlcipher port installs library and headers (and .pc file, likely not relevant here)
Comment 7 Yuri Victorovich freebsd_committer freebsd_triage 2015-07-07 11:19:50 UTC
Created attachment 158489 [details]
Updated shar
Comment 8 Yuri Victorovich freebsd_committer freebsd_triage 2015-07-14 09:11:26 UTC
Created attachment 158740 [details]
Updated shar

Update to lower version 1.5.5 because of some incompatibilities of 1.5.6 with existing application.
Comment 9 Martin Wilke freebsd_committer freebsd_triage 2015-12-05 09:22:04 UTC
Take.
Comment 10 Martin Wilke freebsd_committer freebsd_triage 2015-12-31 13:38:41 UTC
Was committed in Revision 402990
Comment 11 Yuri Victorovich freebsd_committer freebsd_triage 2016-01-01 00:13:58 UTC
Martin,

I don't see it was committed. r402990 is something else:

> # svn diff -r402989:402990 | grep ^+++
> +++ security/py-pyelliptic/Makefile     (revision 402990)
> +++ security/py-pyelliptic/distinfo     (revision 402990)
> +++ security/py-pyelliptic/pkg-descr    (revision 402990)
> +++ security/Makefile   (revision 402990)

Yuri
Comment 12 Martin Wilke freebsd_committer freebsd_triage 2016-01-01 04:10:17 UTC
Sorry my fault, was yesterday really not my day :(
Comment 13 Yuri Victorovich freebsd_committer freebsd_triage 2016-01-01 04:16:12 UTC
No problem!