Created attachment 162342 [details]
multimedia/Makefile, multimedia/qmmp, multimedia/qmmp-plugin-pack, multimedia/qmmp-qt4, and multimedia/qmmp-plugin-pack-qt4
qmmp-1.0.1, qmmp-plugin-pack-1.0.1, and
new ports qmmp-qt4-0.9.3, qmmp-plugin-pack-qt4-0.9.2
The qmmp series (multimedia/qmmp, and multimedia/qmmp-plugin-pack) had been
splitted in two branches of Qt4-based and Qt5-based products by the upstream
developers. Unfortunately these staffs has the same paths and filenames in
destinated file system trees.
This report suggests to append PKGNAMESUFFIX with "-qt4" on the old Qt4-based
series, like as qmmp-qt4-0.* or qmmp-plugin-pack-qt4-0.*, then move them to
newly created ports that have the same pathnames of ports as before but added
"-qt4" suffix, and let new Qt5-based series, that are qmmp-1.* and
qmmp-plugin-pack-1.*, reside on the current pathnames of ports. CONFLICT
term is set.
Created attachment 163352 [details]
new port & update
qmmp-1.0.2 and qmmp-0.9.4 are released
@Liangtai Can you please confirm this passes QA (portlint, poudriere)
I am sorry but I can test the ports report only at my old pentium2 PC.
It will take a half of week to get a result of i386 system setting
though I did start the inspection in a jailed virtual FreeBSD 10.1-
RELEASE machine last evening. If I must take more examination in
other platforms, tell me please.
Created attachment 163795 [details]
new port & update (ok for 10.1preR)
Difference with the previous attachment 163352 [details]:
At multimedia/qmmp/Makefile, add missing dependency on Qt5X11Extras
as USE_QT5+= x11extras.
At multimedia/qmmp/Makefile and multimedia/qmmp-qt4/Makefile, replace
OPTIONS_MULTI with OPTIONS_GROUP to allow to disable all options as
the original product does.
Created attachment 163796 [details]
testcase log for multimedia/qmmp-qt4 on 10.1preR
Created attachment 163797 [details]
testcase log for multimedia/qmmp-plugin-pack-qt4 on 10.1preR
Created attachment 163798 [details]
testcase log for multimedia/qmmp on 10.1preR
Created attachment 163799 [details]
testcase log for multimedia/qmmp-plugin-pack on 10.1preR
Created attachment 164492 [details]
qmmp-1.0.4, qmmp-qt4-0.9.5, qmmp-plugin-pack-1.0.2, and qmmp-plugin-pack-qt4-0.9.3
Every product has been updated. The latest released
qmmp-qt4-0.9.5, and qmmp-plugin-pack-qt4-0.9.3 .
All tests for these port are also done successfully by
portlint and poudriere(10.1preR on i386). I will submit
poudriere logs of them again if they are needed.
@Liangtai, you're ok, if Qmmp (multimedia/qmmp) keeps Qt4 support and new port will be renamed to multimedia/qmmp-qt5. I think it's better for users.
Created attachment 164538 [details]
qmmp-0.9.5, qmmp-qt5-1.0.4, qmmp-plugin-pack-0.9.3, and qmmp-plugin-pack-qt5-1.0.2
(In reply to Olivier Duchateau from comment #10)
Thank you for your immediate inspection on my report.
I agree your plan, and submit a patch here that creates new
ports with '-qt5' suffix for adding Qt5-based versions, and
updates the current existing ports for following the latest
Qt4-based versions. Probably this patch is safe too, I hope,
though the poudriere tests of these changes did not generates
Thanks, for update. However I didn't tested each option, but MPLAYER option seems wrong.
I mean, we can set/unset MPLAYER, but even if we unset MPLAYER, we must install one player, I think it's not correct, or I don't understand logic.
So I suggest this fix:
MISC_DESC= Other features
OPTIONS_RADIO_MPLAYER= MPLAYER1 MPLAYER2
MPLAYER1_DESC= mplayer-1.1.x (multimedia/mplayer)
MPLAYER2_DESC= mplayer-2.0.x (multimedia/mplayer2)
Instead to use OPTIONS_SINGLE, we can use OPTIONS_RADIO, and MPLAYER1/MPLAYER2 requires MPLAYER (*_IMPLIES variable), so even user unset MPLAYER, and if a player is selected MPLAYER option will be selected.
On my 9.3 poudriere, I get this error with multimedia/qmmp 0.9.5
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: lib/qmmp/Effect/libsrconverter.so
===> Error: Plist issues found.
*** [check-plist] Error code 1
Stop in /usr/ports/multimedia/qmmp.
====>> Error: check-plist failures detected
Full log here . However SRCONV is enabled, perhaps it requires an another option (I don't use default list) .
(In reply to Olivier Duchateau from comment #13)
Error is due to lack of audio/libsamplerate, fixed on my pousdriere machine.
(In reply to Olivier Duchateau from comment #12)
That is useful and sounds important. My code was wrong.
PS: PORTS/audio/wildmidi/Makefile, that is one of
ports I maintain, also should be fixed by replacing
OPTIONS_SINGLE with OPTIONS_RADIO too.
A commit references this bug:
Date: Fri Dec 25 17:39:13 UTC 2015
New revision: 404443
- Update multimedia/qmmp to 0.9.5
- Update multimedia/qmmp-plugin-pack to 0.9.3
- Add multimedia/qmmp-qt5 (1.0.4)
- Add multimedia/qmmp-plugin-pack-qt5 (1.0.2)
Qmmp 0.9.x works only with Qt4, whereas 1.x switched to Qt5
Submitted by: <firstname.lastname@example.org> (maintainer)
Committed with minor changes, thanks.