Created attachment 170869 [details] patch to fix PID issue - Fix default path to PID - Fix rc.d scripts to correct use PID file
Created attachment 171538 [details] patch to 3.0.3 - update to 3.0.3
# grep failure zabbix3-*-3.0.3.log #
poudriere log does not contain errors: # grep failure zabbix3-*-3.0.3.log #
*** Bug 210366 has been marked as a duplicate of this bug. ***
There is now a USES=ssl. Could you update the port Makefile to use this? Also, please re-generate the patches with "make makepatch". When introducing new patches, portlint should not complain.
Created attachment 173226 [details] patch to 3.0.4 - Update to 3.0.4 - Fix default path to PID - Fix rc.d scripts to correct use PID file - Fix some error on Makefile - Fix OPENSSL_USE -> USES=ssl - Fix WANT_PHP_WEB -> USES=php:web - Change default options for -server and -frontend poudriere log does not contain errors: # grep failure zabbix3-*-3.0.4.log # portlint: 0 fatal errors
In zabbix3-*/files/zabbix_*.in you have 'Location of the asterisk pid file' -> s/asterisk/zabbix/ Are there any reasons to not use FIND and REINPLACE_CMD to patch all the Makefile.in?
Created attachment 173279 [details] patch to 3.0.4 fix comments in startup script
mikael, because patches are needed only for certain Makefile.in files.
Created attachment 173341 [details] patch to 3.0.4 - Update to 3.0.4 - Fix default path to PID - Fix rc.d scripts to correct use PID file - Fix some error on Makefile - Fix OPENSSL_USE -> USES=ssl - Fix WANT_PHP_WEB -> USES=php:web - Fix MYSQL_USE -> USES+= mysql - Fix PGSQL_USES -> USES+= pgsql - Fix SQLITE_USES -> USES+= sqlite - Change default options for -server and -frontend
Created attachment 173342 [details] patch to 3.0.4 - Update to 3.0.4 - Fix default path to PID - Fix rc.d scripts to correct use PID file - Fix some error on Makefile - Fix OPENSSL_USE -> USES=ssl - Fix WANT_PHP_WEB -> USES=php:web - Fix MYSQL_USE -> USES+= mysql - Fix PGSQL_USES -> USES+= pgsql - Fix SQLITE_USES -> USES+= sqlite - Change default options for -server and -frontend - Fix CONFLICTS
testbuilds@work
*** Bug 212460 has been marked as a duplicate of this bug. ***
Just a friendly reminder that 3.0.2 is exploitable. A pkg audit is still missing afaict.
When this update will be commited? POC of password hash leak exploit published about 3 weeks ago. And i'm receiving everyday email, that my packages are all ok and not vulnerable. Is there anything that can speedup commit process?
Testbuilds done. Two questions: 1) net-mgmt/zabbix3-frontend has per default the MSYQL option -- in php7, there's only MYSQLI. Would it be possible to set MYSQLI as the default ? This would unbreak the build if php7 is the default. 2) net-mgmt/zabbix3-server there are a lot of patches that add @LIBCURL_CFLAGS@ to the Makefile.in files. It builds in poudriere without those flags, too. So why are those patches needed ?
Created attachment 174819 [details] patch to 3.0.4 + change MYSQLI as the default and remove patches that add @LIBCURL_CFLAGS@
thanks, testbuilds@work. Btw, in the meantime, there was a small commit to the tree for -server, see https://lists.freebsd.org/pipermail/svn-ports-all/2016-September/131836.html But I think this can be committed, stay tuned.
testbuilds are OK
A commit references this bug: Author: pi Date: Fri Sep 16 19:10:50 UTC 2016 New revision: 422263 URL: https://svnweb.freebsd.org/changeset/ports/422263 Log: net-mgmt/zabbix3-{server|agent|proxy|frontend}: update to 3.0.4 and many fixes - Fix default path to PID - Fix rc.d scripts to correct use PID file - Fix some error in the Makefile - Fix OPENSSL_USE -> USES=ssl - Fix WANT_PHP_WEB -> USES=php:web - Fix MYSQL_USE -> USES+= mysql - Fix PGSQL_USES -> USES+= pgsql - Fix SQLITE_USES -> USES+= sqlite - Change default options for -server and -frontend - Fix CONFLICTS - fixed SQL injection vulnerability in "Latest data" page; thanks to 1N3 at Early Warning Services, LLC PR: 209893 MFH: 2016Q3 Security: https://support.zabbix.com/browse/ZBX-11023 Changes: http://www.zabbix.com/rn3.0.4.php Submitted by: Pakhom Golynga <pg@pakhom.spb.ru> (maintainer) Changes: head/net-mgmt/zabbix3-frontend/Makefile head/net-mgmt/zabbix3-server/Makefile head/net-mgmt/zabbix3-server/distinfo head/net-mgmt/zabbix3-server/files/zabbix_agentd.in head/net-mgmt/zabbix3-server/files/zabbix_proxy.in head/net-mgmt/zabbix3-server/files/zabbix_server.in head/net-mgmt/zabbix3-server/pkg-plist.frontend
Created attachment 174890 [details] Patch to fix database selection The last update broke the database selection options; all databases are now declared as dependencies. At least it will still actually build with the selected option.
Created attachment 174891 [details] Patch to fix database selection Apologies, I should have left the keyword alone.
A commit references this bug: Author: pi Date: Sun Sep 18 12:58:02 UTC 2016 New revision: 422386 URL: https://svnweb.freebsd.org/changeset/ports/422386 Log: net-mgmt/zabbix3-server: fix database selection - stop having all databases as dependencies all the time PR: 209893 Submitted by: chris@chrullrich.net Changes: head/net-mgmt/zabbix3-server/Makefile
A commit references this bug: Author: pi Date: Mon Sep 19 15:27:32 UTC 2016 New revision: 422446 URL: https://svnweb.freebsd.org/changeset/ports/422446 Log: net-mgmt/zabbix3-server: merge several changes to quarterly MFH: r422063 r422263 r422386 - Simplify FreeBSD 9 SSL check, ignore LibreSSL - update to 3.0.4 and add many fixes PR: 209893 Security: https://support.zabbix.com/browse/ZBX-11023 Changes: http://www.zabbix.com/rn3.0.4.php Submitted by: Pakhom Golynga <pg@pakhom.spb.ru> (maintainer), chris@chrullrich.net Approved by: ports-secteam (feld) Changes: _U branches/2016Q3/ branches/2016Q3/net-mgmt/zabbix3-frontend/Makefile branches/2016Q3/net-mgmt/zabbix3-server/Makefile branches/2016Q3/net-mgmt/zabbix3-server/distinfo branches/2016Q3/net-mgmt/zabbix3-server/files/zabbix_agentd.in branches/2016Q3/net-mgmt/zabbix3-server/files/zabbix_proxy.in branches/2016Q3/net-mgmt/zabbix3-server/files/zabbix_server.in branches/2016Q3/net-mgmt/zabbix3-server/pkg-plist.frontend
Hi, you for some reason got rid of zabbix_agentd_paths in that patch, which is used for the search path of server/proxy externals and agent userparams.
A commit references this bug: Author: pi Date: Tue Sep 20 17:02:54 UTC 2016 New revision: 422524 URL: https://svnweb.freebsd.org/changeset/ports/422524 Log: net-mgmt/zabbix3-server: unbreak build PR: 209893 Submitted by: antoine MFH: 2016Q3 Changes: head/net-mgmt/zabbix3-server/Makefile
A commit references this bug: Author: pi Date: Wed Sep 21 15:52:17 UTC 2016 New revision: 422570 URL: https://svnweb.freebsd.org/changeset/ports/422570 Log: net-mgmt/zabbix3-server: unbreak build MFH: r422524 PR: 209893 Submitted by: antoine Approved by: ports-secteam (feld) Changes: _U branches/2016Q3/ branches/2016Q3/net-mgmt/zabbix3-server/Makefile
I updated my Q3 port to zabbix3-server-3.0.4 (agentd and frontend as well) and found that the ports init scripts are semi broken: <pts/1|*****|FreeBSD|root|~ > service zabbix_server status zabbix_server is not running. <pts/1|*****|FreeBSD|root|~ > service zabbix_server start Starting zabbix_server. <pts/1|*****|FreeBSD|root|~ > service zabbix_server start zabbix_server already running? (pid=28747 28748 28749 28750 28751 28752 28753 28754 28755 28756 28757 28758 28759 28760 28761 28762 28763 28764 28765 28766 28767 28768 28769 28770 28771 28772 28773 28774). <pts/1|*****|FreeBSD|root|~ > service zabbix_server status zabbix_server is not running. For whatever reason, it does actually start then, but appears to be messing up with the PID check. I wasn't sure if this was just from Q3 missing the very latest patch? Any ideas?
Tomorrow I will fix this issue.
(In reply to Dan McGrath from comment #28) This problem is because the patch (https://bz-attachments.freebsd.org/attachment.cgi?id=174819) does not fully applied (no files files/patch-src-zabbix_agent_zabbix_agentd.c, files/patch-src-zabbix_proxy_proxy.c, files/patch-src-zabbix_server_server.c). As a workaround, you can set PidFile in the zabbix_server.conf or fully apply the patches from this PR. pi@ promised to fix this as the return from eurobsdcon.
A commit references this bug: Author: pi Date: Mon Oct 3 09:36:20 UTC 2016 New revision: 423179 URL: https://svnweb.freebsd.org/changeset/ports/423179 Log: net-mgmt/zabbix3: add missing patches for the PID fix PR: 209893 Pointy hat to: pi Submitted by: pg@pakhom.spb.ru (maintainer) MFH: 2016Q3 Changes: head/net-mgmt/zabbix3-server/Makefile head/net-mgmt/zabbix3-server/files/patch-src_zabbix_agent_zabbix_agentd.c head/net-mgmt/zabbix3-server/files/patch-src_zabbix_proxy_proxy.c head/net-mgmt/zabbix3-server/files/patch-src_zabbix_server_server.c
*** Bug 210152 has been marked as a duplicate of this bug. ***