Bug 211468 - graphics/zathura: Can't handle -x option
Summary: graphics/zathura: Can't handle -x option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Kurt Jaeger
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-07-30 20:04 UTC by freebsd
Modified: 2016-08-27 17:05 UTC (History)
4 users (show)

See Also:
pi: maintainer-feedback-
koobs: merge-quarterly?

Attachments
oatch-zathura (680 bytes, patch)
2016-07-31 15:43 UTC, Walter Schwarzenfeld 		no flags Details | Diff
svn-diff_graphics_zathura (756 bytes, patch)
2016-07-31 20:21 UTC, Walter Schwarzenfeld 		no flags Details | Diff
svn-diff_zathura_correct_depency (543 bytes, patch)
2016-08-27 16:29 UTC, Walter Schwarzenfeld 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description freebsd 2016-07-30 20:04:18 UTC 
zathura errors out with

error: Error parsing command line arguments: Unknown option -x

when using the -x option for synctex. This makes it e.g. unable to work with the "vimtex" plugin (for editing TeX files in NeoVim) which uses the -x option. According to the man page this option should be supported.
I'm using zathura 0.3.6 on FreeBSD-10.3. Tried rebuilding from ports, didn't change anything.

Might be related to bug #209501
Comment 1 freebsd 2016-07-31 12:55:27 UTC 
Update:
compiling it from its original sources makes it work again, so this seems to be a Ports problem.
Comment 2 Walter Schwarzenfeld 2016-07-31 15:43:47 UTC 
Created attachment 173140 [details]
oatch-zathura
Comment 3 Walter Schwarzenfeld 2016-07-31 15:44:10 UTC 
Please, try this patch, seems to work.
Comment 4 freebsd 2016-07-31 20:10:12 UTC 
That patch seems to work
Comment 5 Walter Schwarzenfeld 2016-07-31 20:21:36 UTC 
Created attachment 173142 [details]
svn-diff_graphics_zathura
Comment 6 Walter Schwarzenfeld 2016-07-31 20:22:51 UTC 
Portlint ok.
Testbuilds with  poudriere  103amd64, 93amd64 compiles without problem..
Comment 7 Walter Schwarzenfeld 2016-08-01 05:34:39 UTC 
Testbuilds poudriere: 103i386,  93i386, 11amd64 ok.
Comment 8 Walter Schwarzenfeld 2016-08-20 10:56:48 UTC 
maintainer timeout  ??
Comment 9 Kurt Jaeger freebsd_committer freebsd_triage 2016-08-20 11:47:44 UTC 
testbuilds@work
Comment 10 Kubilay Kocak freebsd_committer freebsd_triage 2016-08-20 13:16:22 UTC 
Is the quarterly branch version of the port affected?
Comment 11 Kurt Jaeger freebsd_committer freebsd_triage 2016-08-21 19:45:46 UTC 
Testbuilds are fine, committed, thanks!
Comment 12 commit-hook freebsd_committer freebsd_triage 2016-08-21 19:45:59 UTC 
A commit references this bug:

Author: pi
Date: Sun Aug 21 19:45:30 UTC 2016
New revision: 420581
URL: https://svnweb.freebsd.org/changeset/ports/420581

Log:
  graphics/zathura: fix -x option

  - fix it by adding some additional LIB_DEPENDS and a CPP flag for SYNCTEX

  PR:		211468
  Submitted by:	Walter Schwarzenfeld <w.schwarzenfeld@utanet.at>
  Reported by:	freebsd@schukraft.org
  Approved by:	quentin.stievenart@gmail.com (maintainer timeout)

Changes:
  head/graphics/zathura/Makefile
Comment 13 Kurt Jaeger freebsd_committer freebsd_triage 2016-08-21 19:46:13 UTC 
(In reply to Kubilay Kocak from comment #10)

The quarterly is at 0.3.4. Untested, if it's affected.
Comment 14 commit-hook freebsd_committer freebsd_triage 2016-08-26 16:21:40 UTC 
A commit references this bug:

Author: pi
Date: Fri Aug 26 16:21:37 UTC 2016
New revision: 420930
URL: https://svnweb.freebsd.org/changeset/ports/420930

Log:
  graphics/zathura: bump portrevision after r420581

  - dependencies added require a bump of portrevision

  PR:		211468
  Reported by:	marino

Changes:
  head/graphics/zathura/Makefile
Comment 15 John Marino freebsd_committer freebsd_triage 2016-08-27 14:26:31 UTC 
There's another serious flaw with this patch:

https://lists.freebsd.org/pipermail/freebsd-ports/2016-August/104569.html


I should have seen it but I was focus on something else.


There are 2 possibilities here:
1) base libmagic should be used.  (remove sysutils/file from list and revbump)
2) sysutils/file needs to be specified with libmagic.so.4:sysutils/file (and revbump).  Grep the tree to see other examples of this.

Reopening the PR!
Comment 16 Walter Schwarzenfeld 2016-08-27 16:29:58 UTC 
Created attachment 174130 [details]
svn-diff_zathura_correct_depency
Comment 17 John Marino freebsd_committer freebsd_triage 2016-08-27 16:45:01 UTC 
I'm build testing now
Comment 18 John Marino freebsd_committer freebsd_triage 2016-08-27 17:01:23 UTC 
I put the wrong PR on the commit message, I committed this though.
Comment 19 Walter Schwarzenfeld 2016-08-27 17:05:57 UTC 
Ok, thanks.