Bug 212729 - [PATCH] net/freeswitch: Update to 1.6.11
Summary: [PATCH] net/freeswitch: Update to 1.6.11
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Many People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: needs-qa, patch
Depends on: 215063
Blocks:
  Show dependency tree / graph
 
Reported: 2016-09-16 14:08 UTC by Šimun Mikecin
Modified: 2016-12-24 11:53 UTC (History)
3 users (show)

See Also:
numisemis: maintainer-feedback+

Attachments
svn diff (8.35 KB, patch)
2016-09-16 14:08 UTC, Šimun Mikecin 		no flags Details | Diff
svn diff (9.39 KB, patch)
2016-09-21 11:15 UTC, Šimun Mikecin 		no flags Details | Diff
svn diff (6.68 KB, patch)
2016-09-21 11:45 UTC, Šimun Mikecin 		no flags Details | Diff
svn diff (8.03 KB, patch)
2016-09-22 13:10 UTC, Šimun Mikecin 		numisemis: maintainer-approval+
Details | Diff
svn diff for version 1.6.11 (10.66 KB, patch)
2016-10-11 08:07 UTC, Šimun Mikecin 		koobs: maintainer-approval+
Details | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Šimun Mikecin 2016-09-16 14:08:11 UTC 
Update from 1.6.8 to 1.6.10.
Added missing dependencies.
Comment 1 Šimun Mikecin 2016-09-16 14:08:54 UTC 
Created attachment 174832 [details]
svn diff
Comment 2 Šimun Mikecin 2016-09-16 14:11:45 UTC 
Passes Q/A.
Comment 3 Šimun Mikecin 2016-09-21 11:15:36 UTC 
Created attachment 175030 [details]
svn diff

svn diff against version 1.6.8.
Passes Q/A on FreeBSD/amd64 10.3-RELEASE and 11.0-RC3.
Comment 4 Šimun Mikecin 2016-09-21 11:45:51 UTC 
Created attachment 175033 [details]
svn diff

svn diff against version 1.6.8.
Fixed from previous attachment: distinfo was missing optional distfiles.
Passes Q/A on FreeBSD/amd64 10.3-RELEASE and 11.0-RC3.

FYI: I'm ready to take maintainership of this port if current maintainer is busy keeping this port update.
Comment 5 Šimun Mikecin 2016-09-22 13:10:23 UTC 
Created attachment 175059 [details]
svn diff

svn diff against version 1.6.8.
Fixed from previous attachment: added missing files, improved rc.d script.
Passes Q/A on FreeBSD/amd64 10.3-RELEASE and 11.0-RC3.

FYI: I'm ready to take maintainership of this port if current maintainer is busy keeping this port update.
Comment 6 corsmith 2016-09-27 08:20:59 UTC 
I Verified clean poudriere build on 11.0-RELEASE.

Patch is maintainer approved.  Please commit.
Comment 7 Šimun Mikecin 2016-10-11 08:07:26 UTC 
Created attachment 175612 [details]
svn diff for version 1.6.11

Passes Q/A.
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2016-10-11 08:54:33 UTC 
@Šimun Please don't (re)modify issue fields once they have been changed by triagers/committers unless they are semantically incorrectly or a mistake has been made. 

Summary tags are deprecated by more structured fields in Bugzilla, and their use only creates more work for triagers. 

The presence of an attachment (attachment 175612 [details]) that is approved by the maintainer using the maintainer-approval flag (as is the case here) along with confirmation that QA passes (as you have done), is all that is required

Finally, thank you for continuing to contribute to FreeBSD
Comment 9 Šimun Mikecin 2016-10-11 09:44:06 UTC 
(In reply to Kubilay Kocak from comment #8)

I didn't realize that you changed the summary just minutes before. Sorry.

How about commiting this patch?
Comment 10 Kubilay Kocak freebsd_committer freebsd_triage 2016-10-11 09:50:39 UTC 
(In reply to Šimun Mikecin from comment #9)

Unfortunately I don't have the time to QA this thoroughly at the moment, particularly due to the complex/extensive nature of freeswitch's dependencies (X11/graphics mostly).

I did note however that (a conditional?) USE_OPENSSL was replaced by what appears to be an unconditional USES=ssl ?

If so, it probably needs to be replaced by an ALL_MODULES_USES=ssl instead (that is, conditional on the ALL_OPTIONS option being enabled, as it was prior.

Other than that, it would be good to switch all .if ${PORT_OPTIONS:MOPTION} blocks to options helpers as well. See Porters Handbook: 5.12.3. Options Helpers for more details
Comment 11 Wen Heping freebsd_committer freebsd_triage 2016-12-24 11:53:17 UTC 
net/freeswitch had been updated to 1.6.13