Bug 214765 - [NEW PORT] sysutils/qsudo: Qt sudo front-end
Summary: [NEW PORT] sysutils/qsudo: Qt sudo front-end
Status: Closed DUPLICATE of bug 222759
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Many People
Assignee: Yuri Victorovich
URL:
Keywords: feature, needs-qa
Depends on:
Blocks:
 
Reported: 2016-11-23 02:49 UTC by Pavel Nedoshivkin
Modified: 2018-01-04 08:25 UTC (History)
3 users (show)

See Also:
koobs: maintainer-feedback? (nedoshivkin)

Attachments
new ports (1.62 KB, text/plain)
2016-11-23 02:49 UTC, Pavel Nedoshivkin 		no flags Details
corrected ports (1.57 KB, text/plain)
2017-08-09 01:21 UTC, Pavel Nedoshivkin 		no flags Details
portlint log (9.04 KB, text/plain)
2017-08-09 01:22 UTC, Pavel Nedoshivkin 		no flags Details
poudriere log (39.07 KB, text/x-log)
2017-08-09 01:22 UTC, Pavel Nedoshivkin 		no flags Details
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Nedoshivkin 2016-11-23 02:49:25 UTC 
Created attachment 177309 [details]
new ports
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2017-08-03 17:06:05 UTC 
* You have spaces after "var =" instead of tabs.
* USE_xxx should follow USES, all USExxx statements should be in one section.
* No need for GH_ACCOUNT when the project name is the same as port.
* USE_QT5=network xml aren't needed
* USE_GL=gl isn't needed
* In the bug report, please list what QAs did it pass: portlint? poudriere? runs?
* Also, please update to the latest commit.

Also, please run 'portlint -A' to check the new port is correctly formatted.
Comment 2 Pavel Nedoshivkin 2017-08-09 01:21:41 UTC 
Created attachment 185177 [details]
corrected ports
Comment 3 Pavel Nedoshivkin 2017-08-09 01:22:20 UTC 
Created attachment 185178 [details]
portlint log
Comment 4 Pavel Nedoshivkin 2017-08-09 01:22:47 UTC 
Created attachment 185179 [details]
poudriere log
Comment 5 Richard Gallamore freebsd_committer freebsd_triage 2017-08-14 20:45:26 UTC 
Hello Pavel, thank you for your contributions. There are some items that should be addressed, can you please check the following:

* Is the port actually on version 1.0? I can't find this version anywhere on github. If there are no versioning and will be only specifying tagname, this should have versioning like so,  g20170814. Make sure the g is under DISTVERSIONPREFIX and change the PORTVERSION to DISTVERSION.

* Add LICENSE_FILE
* Please sort the port out a bit more following [1], sections of concern are 14.5, 14.6, 14.7, and 14.8.
* MAKE_JOBS_UNSAFE= yes, is this actually necessary?


Once these are addressed I'll start more testing.


[1] https://www.freebsd.org/doc/en/books/porters-handbook/book.html#porting-order
Comment 6 Yuri Victorovich freebsd_committer freebsd_triage 2018-01-04 08:25:41 UTC 
This port is already committed.

*** This bug has been marked as a duplicate of bug 222759 ***