Bug 219406 - graphics/mesa-dri: fails to build on armv6 and aarch64 after r440699 enabled FREEDRENO and VC4 without unbreaking them
Summary: graphics/mesa-dri: fails to build on armv6 and aarch64 after r440699 enabled ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm64 Any
: --- Affects Some People
Assignee: freebsd-x11 mailing list
URL: https://lists.freebsd.org/pipermail/f...
Keywords: regression
Depends on: 219441
Blocks: 201763
  Show dependency treegraph
 
Reported: 2017-05-19 17:47 UTC by Andrew Turner
Modified: 2017-05-21 22:33 UTC (History)
2 users (show)

See Also:
rezny: maintainer-feedback+


Attachments
fix (4.19 KB, patch)
2017-05-19 21:15 UTC, Jan Beich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Turner freebsd_committer 2017-05-19 17:47:44 UTC
While building messa-dri on arm64 the build fails in the freedreno driver. It looks like it depends on textproc/py-mako.

The error is as follows:

Making all in drivers/freedreno
gmake[5]: Entering directory '/wrkdirs/usr/ports/graphics/mesa-dri/work/mesa-17.0.4/src/gallium/drivers/freedreno'
/bin/mkdir -p ir3
PYTHONPATH=../../../../src/compiler/nir python2.7  ./ir3/ir3_nir_trig.py > ir3/ir3_nir_trig.c || (rm -f ir3/ir3_nir_trig.c; false)
Traceback (most recent call last):
  File "./ir3/ir3_nir_trig.py", line 24, in <module>
    import nir_algebraic
  File "/wrkdirs/usr/ports/graphics/mesa-dri/work/mesa-17.0.4/src/compiler/nir/nir_algebraic.py", line 32, in <module>
    import mako.template
ImportError: No module named mako.template
gmake[5]: *** [Makefile:1395: ir3/ir3_nir_trig.c] Error 1
gmake[5]: Leaving directory '/wrkdirs/usr/ports/graphics/mesa-dri/work/mesa-17.0.4/src/gallium/drivers/freedreno'
gmake[4]: *** [Makefile:605: all-recursive] Error 1
gmake[4]: Leaving directory '/wrkdirs/usr/ports/graphics/mesa-dri/work/mesa-17.0.4/src/gallium'
gmake[3]: *** [Makefile:859: all-recursive] Error 1
gmake[3]: Leaving directory '/wrkdirs/usr/ports/graphics/mesa-dri/work/mesa-17.0.4/src'
gmake[2]: *** [Makefile:650: all] Error 2
gmake[2]: Leaving directory '/wrkdirs/usr/ports/graphics/mesa-dri/work/mesa-17.0.4/src'
gmake[1]: *** [Makefile:647: all-recursive] Error 1
gmake[1]: Leaving directory '/wrkdirs/usr/ports/graphics/mesa-dri/work/mesa-17.0.4'
Comment 1 Matthew Rezny freebsd_committer 2017-05-19 21:04:07 UTC
src/gallium/drivers/freedreno/ir3/ir3_nir_trig.py should not have been added to SHEBANG_FILES in the last update as that triggers a regen which would need mako. This issue has already been reported and will be corrected in the next update.
Comment 2 Jan Beich freebsd_committer 2017-05-19 21:15:43 UTC
Created attachment 182747 [details]
fix

Extracted from bug 219247.
Comment 3 commit-hook freebsd_committer 2017-05-21 19:32:04 UTC
A commit references this bug:

Author: rezny
Date: Sun May 21 19:30:56 UTC 2017
New revision: 441424
URL: https://svnweb.freebsd.org/changeset/ports/441424

Log:
  Update the Mesa ports to 17.1.0

  * restrict use of LLVM for Gallium to platforms with LLVM in base to fix
    runtime errors when Gallium is built with a mix of GCC and LLVM
  * make LLVM only a BUILD_DEPEND for mesa-libs, which needs it to build EGL
  * add pkg-plist entries for freedreno and vc4 drivers [1]
  * remove extraneous SHEBANG_FILES entry to fix build of freedreno [2,3]
  * correct typo in libosmesa, which may have affected the Gallium build [4]

  PR:		219247 [1], 219406 [3]
  Submitted by:	jbeich [1] (2 patches, pkg-plist fix), strejda (vc4 CFLAGS)
  Reported by:	strejda [2], andrew [3], linimon [4]
  Approved by:	swills (mentor)
  Differential Revision:	https://reviews.freebsd.org/D10842

Changes:
  head/graphics/libosmesa/Makefile
  head/graphics/mesa-dri/Makefile
  head/graphics/mesa-dri/Makefile.common
  head/graphics/mesa-dri/Makefile.targets
  head/graphics/mesa-dri/distinfo
  head/graphics/mesa-dri/files/configure.ac
  head/graphics/mesa-dri/files/patch-configure
  head/graphics/mesa-dri/files/patch-src_egl_drivers_dri2_platform__x11.c
  head/graphics/mesa-dri/files/patch-src_gallium_auxiliary_pipe-loader_pipe__loader__drm.c
  head/graphics/mesa-dri/files/patch-src_gallium_drivers_vc4_Makefile.in
  head/graphics/mesa-dri/files/patch-src_gallium_drivers_vc4_vc4__bufmgr.c
  head/graphics/mesa-dri/files/patch-src_intel_tools_aubinator.c
  head/graphics/mesa-dri/files/patch-src_intel_tools_aubinator__error__decode.c
  head/graphics/mesa-dri/files/patch-src_mapi_glapi_gen_gl__gentable.py
  head/graphics/mesa-dri/files/patch-src_mesa_main_compiler.h
  head/graphics/mesa-dri/files/patch-src_util_build__id.c
  head/graphics/mesa-dri/files/patch-src_util_ralloc.c
  head/graphics/mesa-dri/pkg-plist
  head/graphics/mesa-libs/Makefile
  head/lang/clover/Makefile