Created attachment 184225 [details] Complete poudriere build log checking for gmsgfmt... no configure: error: GNU gettext tools not found; required for intltool ===> Script "configure" failed unexpectedly. Please report the problem to gnome@FreeBSD.org [maintainer] and attach the "/wrkdirs/usr/ports/deskutils/gucharmap/work/gucharmap-9.0.4/config.log" including the output of the failure of your make command. Also, it might be a good idea to provide an overview of all packages installed on your system (e.g. a /usr/local/sbin/pkg-static info -g -Ea). *** Error code 1 Stop. make: stopped in /usr/ports/deskutils/gucharmap
This prevents from building x11/mate, so it's kind of important.
deskutils/gucharmap error with intltool NLS=off NLS option is turned off on most ports. Compile breaks with checking for xgettext... no checking for msgmerge... no checking for msgfmt... no checking for gmsgfmt... no configure: error: GNU gettext tools not found; required for intltool Add to USES gettext-tools -@22 pathfix pkgconfig tar:xz +@22 pathfix pkgconfig tar:xz gettext-tools But thorws out a new problem, as textproc/UCD is compiled with option HAN=NO. textproc/UCD with option HAN=NO builds normally, but deskutils/gucharmap breaks because it's unable to locate Unihan PROG_UNZIP=/usr/bin/unzip ./gen-guch-unicode-tables.pl 9.0.0 /usr/local/share/unicode/ucd && \ echo timestamp > stamp-unicode-data Did not find /usr/local/share/unicode/ucd/Unihan.zip at ./gen-guch-unicode-tables.pl line 65.
(In reply to Beeblebrox from comment #2) I confirm, "USES += gettext-tools" fixes the problem for me.
Problem still exists! Could someone fix this simple problem?
Sorry, forgot one word: Please!
Created attachment 191187 [details] svn diff for deskutils/gucharmap : fixes NLS=off build failure OK here's a proven fix for deskutils/gucharmap build problem with option: NLS=off Please see attached svn diff (patch) for all the gory details. :-) --Chris keywords: easy, patch, patch-ready
Has the patch still not made it into the ports tree? The build still fails.
Created attachment 194549 [details] A very recent build log
(In reply to vas from comment #7) > Has the patch still not made it into the ports tree? The build still fails. Wow, see this never got committed. :-( I don't have a commit bit. So it's out of my hands at this point. Thanks for the heads-up!
(In reply to vas from comment #8) > Created attachment 194549 [details] > A very recent build log Oh. Seems it's broken again. :-( I'll whip up a new patch, and submit it sometime today. Thanks vas! --Chris
Can you also provide a patch to upgrade, as mentioned in: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228830#c5
Created attachment 194569 [details] svn-diff-gucharmap-10.0.0.4 This is an update patch to 10.0.0.4. This fixes the gettest error. Kurt: I was not able to make the changes from the link. I was not able to patch Makefile.am, find no reason why (no such line 203, the patch starts at line 204 ???).
I think if you agree commit the update and we do the other changes later.
(In reply to Kurt Jaeger from comment #11) > Can you also provide a patch to upgrade, as mentioned in: > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228830#c5 Sure. But I don't think it *now* applies. Given that deskutils/gucharmap has been updated upstream. :-) I'll test Walters patch against -CURRENT, and report my findings. :-) --Chris
(In reply to w.schwarzenfeld from comment #12) > Created attachment 194569 [details] > svn-diff-gucharmap-10.0.0.4 > > This is an update patch to 10.0.0.4. This fixes the gettest error. > > Kurt: I was not able to make the changes from the link. I was not able to > patch Makefile.am, find no > reason why (no such line 203, the patch starts at line 204 ???). Houston, we have a problem... ====> Compressing man pages (compress-man) ====> Running Q/A tests (stage-qa) Warning: you may not need USES=desktop-file-utils Error: /usr/local/bin/gucharmap is linked to /usr/local/lib/libfreetype.so.6 from print/freetype2 but it is not declared as a dependency Warning: you need LIB_DEPENDS+=libfreetype.so:print/freetype2 ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: share/help/C/gucharmap/figures/gucharmap_window.png Error: Orphaned: share/help/bg/gucharmap/figures/gucharmap_window.png Error: Orphaned: share/help/cs/gucharmap/figures/gucharmap_window.png Error: Orphaned: share/help/de/gucharmap/figures/gucharmap_window.png Error: Orphaned: share/help/el/gucharmap/figures/gucharmap_window.png Error: Orphaned: share/help/es/gucharmap/figures/gucharmap_window.png Error: Orphaned: share/help/fi/gucharmap/figures/gucharmap_window.png Error: Orphaned: share/help/fr/gucharmap/figures/gucharmap_window.png Error: Orphaned: share/help/hu/gucharmap/figures/gucharmap_window.png Error: Orphaned: share/help/ko/gucharmap/figures/gucharmap_window.png Error: Orphaned: share/help/pl/gucharmap/figures/gucharmap_window.png Error: Orphaned: share/help/pl/gucharmap/index.docbook Error: Orphaned: share/help/pl/gucharmap/legal.xml Error: Orphaned: share/help/pt_BR/gucharmap/figures/gucharmap_window.png Error: Orphaned: share/help/sv/gucharmap/figures/gucharmap_window.png Error: Orphaned: share/help/zh_CN/gucharmap/figures/gucharmap_window.png Error: Orphaned: @dir share/help/ca/gucharmap/figures Error: Orphaned: @dir share/help/en_GB/gucharmap/figures Error: Orphaned: @dir share/help/gl/gucharmap/figures Error: Orphaned: @dir share/help/oc/gucharmap/figures Error: Orphaned: @dir share/help/ru/gucharmap/figures Error: Orphaned: @dir share/help/sl/gucharmap/figures Error: Orphaned: @dir share/help/vi/gucharmap/figures ===> Checking for items in pkg-plist which are not in STAGEDIR ===> Error: Plist issues found. *** Error code 1 Stop. make: stopped in /usr/ports/deskutils/gucharmap I'll correct the issue, and submit an updated svn diff in a couple minutes. :-) --Chris
Created attachment 194613 [details] svn-diff-gucharap_10.0.4_v2 Thanks! .... but it configures ;-)) The cavalry is on the way....
Created attachment 194614 [details] svn diff for deskutils_gucharmap Well, since I already announced that I was doing it, and went through all the time, and trouble to do it. Here's my copy, that corrects the problems indicated. I will also be attaching the build session against this patch. --Chris
Created attachment 194615 [details] build log -- QA LOG for deskutils/gucharmap Build session in a clean 12-CURRENT/amd64 jail, against the patch I also attached to this pr(1). --Chris
I change maintainer approval to +. Gnome has not look in it more than a year. I see it as maintainer timeout. Kurt: do you agree?
Thanks Chris, we take your patch.
(In reply to w.schwarzenfeld from comment #20) > Thanks Chris, we take your patch. Thanks for everything Walter! --Chris
Testbuilds with NLS=on: fine Testbuilds with NLS=off: failed in configure with: checking for gmsgfmt... no configure: error: GNU gettext tools not found; required for intltool ===> Script "configure" failed unexpectedly. I suggest to remove the NLS option.
Or try change NLS_USES= gettext to NLS_USES= gettext-tools
(In reply to w.schwarzenfeld from comment #23) > Or try change > NLS_USES= gettext > > to > NLS_USES= gettext-tools Good catch Kurt! From my personal experiences with other ports bombing with the same error, under the same circumstances. NLS_USES= gettext-tools turned out to be the better choice. --Chris
Created attachment 194624 [details] svn diff for deskutils_gucharmap v.2 Corrects failure caused by: NLS_USES= gettext when NLS option off replaces with NLS_USES= gettext-tools Thats it!
Tried, no change.
P.S. Sorry I didn't catch that. I already *knew* better. :-(
Created attachment 194625 [details] svn diff for deskutils_gucharmap v.3 OK Just remembered what *extera* I had to perform to get it to work. hint; intlhack --Chris
no change, sorry. I'm going to travel now, I'll be back on wednesday evening. I suggest to poudriere-test any additional attempt to fix this.
https://wiki.gnome.org/Initiatives/GnomeGoals/GettextMigration somewhere down: => gucharmap - todo
Try add +--- configure.ac.orig 2018-06-25 08:45:17 UTC ++++ configure.ac +@@ -55,7 +55,6 @@ AC_USE_SYSTEM_EXTENSIONS + + AC_DISABLE_STATIC + AC_PROG_LIBTOOL +-IT_PROG_INTLTOOL([0.40.0]) + + AM_PROG_CC_C_O + +@@ -228,7 +227,8 @@ fi + GETTEXT_PACKAGE=gucharmap + AC_SUBST([GETTEXT_PACKAGE]) + AC_DEFINE_UNQUOTED([GETTEXT_PACKAGE],["$GETTEXT_PACKAGE"],[The gucharmap gettext domain]) +-AM_GLIB_GNU_GETTEXT ++AM_GNU_GETTEXT_VERSION([0.19.8.1]) ++AM_GNU_GETTEXT([external]) + + ########################################################## + # Check for -Bsymbolic-functions linker flag used to avoid and --- files/patch-autogen.sh (nonexistent) +++ files/patch-autogen.sh (working copy) @@ -0,0 +1,10 @@ +--- autogen.sh.orig 2018-06-25 08:45:25 UTC ++++ autogen.sh +@@ -10,7 +10,6 @@ cd "$srcdir" + mkdir -p m4 >/dev/null 2>&1 || true + gtkdocize --copy --flavour no-tmpl + autoreconf --verbose --force --install +-intltoolize --force + cd - + + test -n "$NOCONFIGURE" || "$srcdir/configure" "$@" to your patch.
No, also does not work. In the meantime I also think it is better to remove the NLS option.
(In reply to Kurt Jaeger from comment #29) > no change, sorry. I'm going to travel now, I'll be back on wednesday evening. > I suggest to poudriere-test any additional attempt to fix this. Sorry, Kurt. It was late (12:30 am), and I should have left this for morning (after sleep, morning). --Chris
Created attachment 194630 [details] svn diff for deskutils_gucharmap v.4 OPTION NLS OFF OK this patch *actually* fixes it. I have the QA LOG to prove it. :-) GNOME_USES adds intlhack NLS_USES gettext-runtime That's it! See additional QA LOG, also attached --Chris
Created attachment 194631 [details] QA LOG for deskutils/gucharmap -- NONLS build QA LOG for: svn diff for deskutils_gucharmap v.4 OPTION NLS OFF Build log on fresh 12-current/amd64 jail OPTION NLS off That's it! Thanks Kurt, and Walter! --Chris
No, fails with poudriere on 10.4.
Pfff.... a simple NLS_CONFIGURE_OFF= --disable-gettext does it on 10.4 with port and poudriere. I cannot test in the moment with 11.X, please can you do it.
(In reply to w.schwarzenfeld from comment #37) > Pfff.... a simple > NLS_CONFIGURE_OFF= --disable-gettext > > does it on 10.4 with port and poudriere. > > I cannot test in the moment with 11.X, please can you do it. Sure. Not right at the moment, but soon. :-) --Chris
It's great that you are fixing this, there is hope :-) In the meanwhile I had to set "deskutils_gucharmap_SET= NLS" in /usr/local/etc/poudriere.d/make.conf
Created attachment 194642 [details] svn diff for deskutils_gucharmap v.5 FINAL -- OPTION NLS OFF OK here's the patch for deskutils/gucharmap Tested (by me) with/without NLS on 12-current/amd64 and 11/amd64 -- both (finally) work fine. Adds only to my last version NLS_CONFIGURE_OFF= --disable-gettext as per Walter. That's it! :-) --Chris
Comment on attachment 191187 [details] svn diff for deskutils/gucharmap : fixes NLS=off build failure Thanks, Chris. I obsolete the old patch.
(In reply to w.schwarzenfeld from comment #41) > Comment on attachment 191187 [details] > svn diff for deskutils/gucharmap : fixes NLS=off build failure > > Thanks, Chris. I obsolete the old patch. Thank *you* :-) That (finally) covers it. Doesn't it? I've tested this now on 12,11, and you've tested on 10.4. Is there anything left? Thanks! --Chris
I think not for the moment, I think we do the changes from the link in comment11 in an extra commit.
This is a strange thing With the port configure states configure: WARNING: unrecognized options: --disable-gettext does not find the line in the poudriere build.log. But it works (??), but builds the *. po files.
And you cannot patch configure.ac: Every try endet up with ./configure: 12810: Syntax error: word unexpected (expecting ")") ===> Script "configure" failed unexpectedly. Please report the problem to gnome@FreeBSD.org [maintainer] and attach the "/ram/home/ngorx/temp/gucharmap/work/gucharmap-10.0.4/config.log" including the output of the failure of your make command. Also, it might be a good idea to provide an overview of all packages installed on your system (e.g. a /usr/local/sbin/pkg-static info -g -Ea). *** Error code 1 I only added to configure.ac only for test one "#" on start of one line, ended with above result.
Ok, the warning was my fault. NLS_CONFIGURE_OFF= --disable-nls throws no warning.
(In reply to w.schwarzenfeld from comment #44) > This is a strange thing > With the port configure states > configure: WARNING: unrecognized options: --disable-gettext > > does not find the line in the poudriere build.log. But it works (??), but > builds the *. po files. Heh. --disable-gettext was *your* idea. ;-) I added it, because you indicated it was needed, when you tried to build it (10.4?). FWIW, I never received any errors on 12, or 11 without that addition. Not saying you're wrong. Just sharing my experience. :-)
(In reply to w.schwarzenfeld from comment #46) > Ok, the warning was my fault. > NLS_CONFIGURE_OFF= --disable-nls > > throws no warning. WooHoo! You're *brilliant* Walter. :-) Good news! --Chris P.S. and seeing it here. It now seems so obvious. :-P
Sorry, but you can forget it. "--disable-nls" has no effect. Every try to change it via configure.ac or Makefile.am/in was without success. (configure hangs in the line with YELP_HELP_INIT([no-lc-media-links no-lc-dist]) if you use autoreconf). Let's remove die NLS option and the references to UCD.
UCD was wrong, that is needed.
(In reply to w.schwarzenfeld from comment #49) > Sorry, but you can forget it. "--disable-nls" has no effect. > Every try to change it via configure.ac or Makefile.am/in was without > success. > (configure hangs in the line with YELP_HELP_INIT([no-lc-media-links > no-lc-dist]) if you use > autoreconf). > > Let's remove die NLS option and the references to UCD. I agree. NLS option should go away. Not because of any difficulty here. But because it need *not* be an option. Just leave it in, and as default, and be done with it. :-) --Chris
Created attachment 194664 [details] svn-diff-full-gucharmap The svn includes also the changes from the link in comment11. Found a way to solve the configure problems (I know it is ugly).
Created attachment 194665 [details] svn-diff-full-gucharmapt_v2 This version is more "nice".
(In reply to w.schwarzenfeld from comment #53) > Created attachment 194665 [details] > svn-diff-full-gucharmapt_v2 > > This version is more "nice". Looks promising, Walter. It's late here. But I'll spin it up first thing in the morning, and let you know how it works here. Thanks! --Chris
(In reply to w.schwarzenfeld from comment #49) YELP_HELP_INIT is provided by yelp-tools, so you have to put it in BUILD_DEPENDS if you modify configure.ac.
The autotools complain about the automake version. So I use autoreconf. But autoreconf complete change the lines for YELP_HELP_INIT in configure.ac. I don't want to play with configure.ac and the Makefiles. But as you see I found another way.
Comment on attachment 194665 [details] svn-diff-full-gucharmapt_v2 >Index: Makefile >=================================================================== >--- Makefile (revision 473314) >+++ Makefile (working copy) >@@ -2,7 +2,7 @@ > # $FreeBSD$ > > PORTNAME= gucharmap >-PORTVERSION= 9.0.4 >+PORTVERSION= 10.0.4 The latest gucharmap release is 11.0.1. The version number of gucharmap is intended to match the version number of Unicode. Since our UCD has version 11, it will be better to update to gucharmap 11 instead of backporting patches from 11 to 10. However, gucharmap developers haven't published source tarballs for version 11 because they want to find a way for GitLab to upload tarballs automatically: https://gitlab.gnome.org/GNOME/gucharmap/issues/3. We may have to switch to USE_GITLAB in the mean time and this will require autoreconf. > CATEGORIES= deskutils gnome > MASTER_SITES= GNOME > DIST_SUBDIR= gnome3 >@@ -15,12 +15,13 @@ > > BUILD_DEPENDS= itstool:textproc/itstool \ > UCD>=0:textproc/UCD >+LIB_DEPENDS+= libfreetype.so:print/freetype2 This is fine. The reason gucharmap links directly to freetype2 is that the upstream developer doesn't want to see color emoji in a character map application. > > PORTSCOUT= limitw:1,even > >-USES= desktop-file-utils gmake gnome libtool localbase \ >+USES= desktop-file-utils gettext gmake gnome libtool localbase \ > pathfix pkgconfig tar:xz >-USE_GNOME= cairo gdkpixbuf2 gtk30 intltool introspection:build >+USE_GNOME= cairo gdkpixbuf2 gtk30 intltool intlhack introspection:build Is intlhack still needed? Since using GitLab tarballs will require running autoreconf, hacks on generated files will not be needed. > GNU_CONFIGURE= yes > CONFIGURE_ARGS= --with-unicode-data=${LOCALBASE}/share/unicode/ucd/ > USE_LDCONFIG= yes >@@ -28,11 +29,14 @@ > > GLIB_SCHEMAS= org.gnome.Charmap.enums.xml \ > org.gnome.Charmap.gschema.xml >+MAKE_ARGS+= ACLOCAL="${TRUE}" AUTOCONF="${TRUE}" AUTOHEADER="${TRUE}" \ >+ AUTOMAKE="${TRUE}" Please remove this. This debugging code should not appear in the ports tree. > >-OPTIONS_SUB= yes >-OPTIONS_DEFINE= NLS >+#OPTIONS_SUB= yes >+#OPTIONS_DEFINE= NLS > >-NLS_USES= gettext >-NLS_CONFIGURE_ENABLE= nls >+#NLS_USES= gettext-tools >+#NLS_CONFIGURE_ENABLE= nls >+#NLS_CONFIGURE_OFF= --disable-nls If it isn't going to work, can you simply remove them instead of commenting out?
(In reply to Ting-Wei Lan from comment #55) > (In reply to w.schwarzenfeld from comment #49) > YELP_HELP_INIT is provided by yelp-tools, so you have to put it in > BUILD_DEPENDS if you modify configure.ac. Wait a minute. Walter, are your additions in regards to comment #11 ( bug #228830 )? That bug was closed, and we've already incorporated those changes here, in files/patch-gucharmap_gen-guch-unicode-tables.pl Unless it still didn't build for you on 10.4 after applying the most recent patch I provided yesterday. I think this pr(1) should be committed at that point. It feels like we're dragging too much into this pr. We're rapidly approaching a mega-patch. Don't you think? --Chris
Freetype added Chris. I don't look at this, I thought he has a reason for this. NLS I let it only for the moment in. If Chris and Kurt agrees I put it out. => MAKE_ARGS+= ACLOCAL="${TRUE}" AUTOCONF.... ...some ports use it I was not clear about intlhack, but I also think we don't need it. ============================ Version 11.0.1 automake: error: cannot open < gtk-doc.make: No such file or directory autoreconf-2.69: automake failed with exit status: 1 *** Error code 1 ...end of the line!
Tried --disable-gtk-doc and patched it out of Makefile.am and Makefile.in. Same error message.
Ok, I overlooked an entry in reference/Makefile.am. /configure: 12811: Syntax error: word unexpected (expecting ")") ===> Script "configure" failed unexpectedly. Please report the problem to gnome@FreeBSD.org [maintainer] and attach the "/ram/home/ngorx/temp/gucharmap/work/gucharmap-master/config.log" including the output of the failure of your make command. Also, it might be a good idea to provide an overview of all packages installed on your system (e.g. a /usr/local/sbin/pkg-static info -g -Ea). *** Error code 1 I don't want spent the time to rewrite half of configure.ac.
(In reply to w.schwarzenfeld from comment #59) You have to run gtkdocize before running autoreconf, but there is an easier way. You can use 'autogen.sh' provided in the git repository instead of manually running autoreconf by putting this in port Makefile: pre-configure: cd ${WRKSRC} && NOCONFIGURE=1 ./autogen.sh
Thanks, that solves the "problem" with gtk-doc.make, but not the configure error message.
Created attachment 194685 [details] svn-diff-gucharmap-11.0.0.1 BUILD_DEPENDS=yelp-tools>=0:textproc/yelp-tools solves the problem. The only "thing" I don't know freetype or not?
(In reply to w.schwarzenfeld from comment #64) > Created attachment 194685 [details] > svn-diff-gucharmap-11.0.0.1 > > BUILD_DEPENDS=yelp-tools>=0:textproc/yelp-tools solves the problem. > > The only "thing" I don't know freetype or not? While I haven't actually looked. I'm pretty sure that the dependence on gnome sucks that in. Great work, BTW, Walter! --Chris
Created attachment 194686 [details] Update to 11.0.1 and remove NLS option
(In reply to Chris Hutchinson from comment #65) > (In reply to w.schwarzenfeld from comment #64) > > Created attachment 194685 [details] > > svn-diff-gucharmap-11.0.0.1 > > > > BUILD_DEPENDS=yelp-tools>=0:textproc/yelp-tools solves the problem. > > > > The only "thing" I don't know freetype or not? > > While I haven't actually looked. I'm pretty sure that > the dependence on gnome sucks that in. > > Great work, BTW, Walter! > > --Chris Looking closer; I think you need to leave it in. Thank again, Walter! --Chris
testbuilding 11.0.1 @work. It looks very useful to remove the NLS knob.
Created attachment 194691 [details] svn-diff-nls This is a patch against Ting-Wei Lan's patch. If I am right, this can provide a working NLS knob. (the patch-acinclude.m4 is stolen from thunar). Please, test this.
=>This is a patch against Ting-Wei Lan's patch. Was wrong. Just "normal" patch.
TODO: testbuilds for the depends: editors/gedit-plugins japanese/libtomoe-gtk www/bluefish x11/gnome3 x11/mate-applets
Ok, Kurt please take Ting-Wei Lan's patch. I think it is the correct one. My try with the knob was more "I like to know if I can work it out". I don't obsolete it maybe Chris or vas wants to test it.
A commit references this bug: Author: pi Date: Fri Jun 29 12:37:26 UTC 2018 New revision: 473543 URL: https://svnweb.freebsd.org/changeset/ports/473543 Log: deskutils/gucharmap: update 9.0.4 -> 11.0.1, remove NLS option - Update to Unicode 11.0.0 PR: 220597 Submitted by: Ting-Wei Lan <lantw44@gmail.com>, Reported by: vas@mpeks.tomsk.su Reviewed by: w.schwarzenfeld@utanet.at, Chris Hutchinson <portmaster@bsdforge.com> Relnotes: https://gitlab.gnome.org/GNOME/gucharmap/commits/master Changes: head/deskutils/gucharmap/Makefile head/deskutils/gucharmap/distinfo head/deskutils/gucharmap/files/ head/deskutils/gucharmap/pkg-descr head/deskutils/gucharmap/pkg-plist
Committed, thanks to all for the work!