Bug 221199 - [NEW PORT] audio/x42-plugins-lv2: Collection of LV2 plugins (submodules)
Summary: [NEW PORT] audio/x42-plugins-lv2: Collection of LV2 plugins (submodules)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Richard Gallamore
URL:
Keywords:
Depends on: 221193 221196
Blocks:
  Show dependency treegraph
 
Reported: 2017-08-03 06:13 UTC by Yuri Victorovich
Modified: 2017-08-11 17:24 UTC (History)
1 user (show)

See Also:


Attachments
shar (6.43 KB, text/plain)
2017-08-03 06:13 UTC, Yuri Victorovich
no flags Details
shar (6.62 KB, text/plain)
2017-08-11 06:22 UTC, Yuri Victorovich
no flags Details
shar (5.01 KB, text/plain)
2017-08-11 06:52 UTC, Yuri Victorovich
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer 2017-08-03 06:13:42 UTC
Created attachment 184981 [details]
shar

QAs:
* pourdriere
* portlint


A collection of advanced lv2 plugins, see screenshots here: https://github.com/x42/x42-plugins
Comment 1 Richard Gallamore freebsd_committer 2017-08-11 03:49:18 UTC
This one needed a little more help,


* USE_GL also needed gl for mesa-libs.
* The files/patch* are one liners, try to avoid patches with one liners if easily avoidable by using REINPLACE_CMD in post-patch target.
* Lib needed to be stripped.
* pkg-descr had two WWW:, only one is acceptable. Github was chosen, change it on next release if you rather the other one.

Overall looks good! I already added these items. Thanks for your contributions.
Comment 2 Yuri Victorovich freebsd_committer 2017-08-11 04:16:26 UTC
> * pkg-descr had two WWW:, only one is acceptable. Github was chosen, change it
on next release if you rather the other one.

This seems like a new rule. portlint allows multiple WWW items.
Comment 3 Yuri Victorovich freebsd_committer 2017-08-11 04:18:56 UTC
> * Lib needed to be stripped.

Yes. I run my system with STRIP= for the reason to allow DTrace symbols. Unfortunately, it's only a stage-qa warning therefore it's not reported by poudriere. This problem will go away for good if/when they implement my suggestion bug#221404.

Yuri
Comment 4 Yuri Victorovich freebsd_committer 2017-08-11 04:32:56 UTC
(In reply to Richard Gallamore from comment #1)

> * USE_GL also needed gl for mesa-libs.

This suggestion bug#221406, if/when implemented, will take care of the core reason why stage-qa doesn't suggest USE_GL=gl
Comment 5 Yuri Victorovich freebsd_committer 2017-08-11 06:22:27 UTC
Created attachment 185268 [details]
shar

Changes:
* Defined OPTIMIZATIONS with standard optimization flags when possible
* Added USE_GL=gl
* Stripped one dynamic library that wasn't stripped
Comment 6 Yuri Victorovich freebsd_committer 2017-08-11 06:52:54 UTC
Created attachment 185269 [details]
shar

More changes:
* Removed one-liner patches
* Patched makefiles to delete -g flags
Comment 7 commit-hook freebsd_committer 2017-08-11 17:08:06 UTC
A commit references this bug:

Author: ultima
Date: Fri Aug 11 17:07:12 UTC 2017
New revision: 447778
URL: https://svnweb.freebsd.org/changeset/ports/447778

Log:
  A collection of professional lv2 audio plugins written by Robin Gareus.

  WWW: https://github.com/x42/x42-plugins/

  PR:		221199
  Submitted by:	Yuri Victorovich (maintainer)
  Reviewed by:	matthew (mentor)
  Approved by:	matthew (mentor)
  Differential Revision:	https://reviews.freebsd.org/D11975

Changes:
  head/audio/Makefile
  head/audio/x42-plugins-lv2/
  head/audio/x42-plugins-lv2/Makefile
  head/audio/x42-plugins-lv2/distinfo
  head/audio/x42-plugins-lv2/pkg-descr
  head/audio/x42-plugins-lv2/pkg-plist
Comment 8 Richard Gallamore freebsd_committer 2017-08-11 17:11:41 UTC
I already had this queued for commit. Any changes please open a new PR for.
Comment 9 Yuri Victorovich freebsd_committer 2017-08-11 17:24:45 UTC
> I already had this queued for commit. Any changes please open a new PR for.

That's ok, nothing too important there. Will wait.

One thing that I missed first is that they supply -O3 flag in makefiles. When something other than -O2 is seen in the command lines, it needs ideally to be patched out.


Thanks for committing ports!