Bug 223434 - devel/libosmocore: update to 0.10.2
Summary: devel/libosmocore: update to 0.10.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Richard Gallamore
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-04 20:37 UTC by Nikola Kolev
Modified: 2017-12-01 20:26 UTC (History)
1 user (show)

See Also:
koue: maintainer-feedback+


Attachments
libosmocore 0.10.2 patch (645.74 KB, text/plain)
2017-11-04 20:37 UTC, Nikola Kolev
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nikola Kolev 2017-11-04 20:37:11 UTC
Created attachment 187738 [details]
libosmocore 0.10.2 patch

Update devel/libosmocore to 0.10.2

Poudriere looks OK on 10.3, 10.4 and 11.1.

On 11.0 build failed with:

undefined reference to `__cpu_model'

From the information in Internet[1] this is related to gcc compiler bug. The port is using default compiler: clang. No idea how to troubleshoot this.

EOL of FreeBSD 11.0 is November 30, 2017. I doubt the effort to solve this build issue is worthwhile.

[1] https://github.com/numpy/numpy/issues/8530
Comment 1 Richard Gallamore freebsd_committer freebsd_triage 2017-11-11 16:15:48 UTC
Everything looks in order, before this is committed can you please explain the reason all the Doxyfiles are removed? and why they were in place originally (if you know)? Normally I wouldn't be as concerned but this is a 12000 line patchfile.
Comment 2 Nikola Kolev 2017-11-14 09:47:06 UTC
Hi,

When the port was created there was problem using the current version of doxygen and @Kurt Jaeger provided those patches to be able to use it.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191877

Now I just removed them and poudriere didn't complain so I decided to remove them.
Comment 3 Richard Gallamore freebsd_committer freebsd_triage 2017-11-16 18:19:26 UTC
(In reply to Nikola Kolev from comment #2)
Thanks for the clarity, I also am glad you mentioned 11.0 being EOL. Thought it was EOL couple of months ago. Going to delay due to failing on 11.0 from the clang bug until the first of next month. Feel free to update patch if one become available before then.
Comment 4 Richard Gallamore freebsd_committer freebsd_triage 2017-12-01 02:27:19 UTC
devel/talloc has changed USES= python:2 --> python:2.7 on r454532. Which is causing issues with the port having command not found[1].

Adding python:2 to the USES should work. Do you want me to add this? Also do you know if it is only required as a build depend or is it required as a runtime depend as well?

[1] https://poudriere.ultimasbox.com/data/111amd64-test/2017-11-30_17h43m45s/logs/errors/libosmocore-0.10.2.log
Comment 5 Nikola Kolev 2017-12-01 16:48:39 UTC
Yes, please, add USES= python:2. devel/talloc is runtime dependency as well.

Thanks.
Comment 6 Richard Gallamore freebsd_committer freebsd_triage 2017-12-01 20:25:55 UTC
Committed, Thanks!
Comment 7 commit-hook freebsd_committer freebsd_triage 2017-12-01 20:26:10 UTC
A commit references this bug:

Author: ultima
Date: Fri Dec  1 20:25:41 UTC 2017
New revision: 455305
URL: https://svnweb.freebsd.org/changeset/ports/455305

Log:
  * Updated to 0.10.2
  * Removed doxygen patches, these are no longer needed
  * Added python:2 to USES,
  devel/talloc has changed USES= python:2 --> python:2.7 (r454532), this port uses the python2 command.

  PR:		223434
  Submitted by:	Nikola Kolev (maintainer)

Changes:
  head/devel/libosmocore/Makefile
  head/devel/libosmocore/distinfo
  head/devel/libosmocore/files/
  head/devel/libosmocore/pkg-plist