Created attachment 190439 [details] Proposed patch (since 457463 revision) Patch to update editors/focuswriter port from 1.6.8 to 1.6.9 version. Look following links for changes: https://github.com/gottcode/focuswriter/compare/v1.6.8...v1.6.9 https://github.com/gottcode/focuswriter/blob/v1.6.9/NEWS#L1-L5 - Fix portlint's warning about USES The build was tested on FreeBSD 10.3 amd64.
There is following portlint's warning: -8<-- % pkg info portlint | grep ^Version Version : 2.17.15 % portlint WARN: Makefile: INSTALLS_ICONS is set, but should not be. 0 fatal errors and 1 warning found. -->8- As I understood, this warning message was proposed in bug #223498. But some tests shows (e.g. with using x11-fm/caja), that in case of mixed environment (GTK+ and Qt applications), the INSTALLS_ICONS=yes maybe required, because it uses ${PREFIX}/bin/gtk-update-icon-cache to update ${LOCALBASE}/share/icons/hicolor/icon-theme.cache. Otherwise (if not use INSTALLS_ICONS=yes), the ${LOCALBASE}/share/applications/focuswriter.desktop may display ${LOCALBASE}/share/pixmaps/focuswriter.xpm, instead of what installed to ${LOCALBASE}/share/icons/hicolor/* (e.g. ${LOCALBASE}/share/icons/hicolor/scalable/apps/focuswriter.svg).
I think you can ignore the warning. Keep INSTALL_ICONS=yes in the Makefile.
(In reply to comment #2) > I think you can ignore the warning. Keep INSTALL_ICONS=yes in the Makefile. Yes, this is what attachment #190439 [details] proposes, i.e. doesn't remove INSTALLS_ICONS=yes. I just wanted to write some explanation in comment #1, in case if committer thinks otherwise. Thanks for attention.
INSTALL_ICONS is mostly needed for Gtk. Portlint does not recognize a mixed enviroment.
Committed, thanks!
A commit references this bug: Author: yuri Date: Sat Feb 10 19:53:59 UTC 2018 New revision: 461416 URL: https://svnweb.freebsd.org/changeset/ports/461416 Log: editors/focuswriter: Update to 1.6.9 Changelog: https://github.com/gottcode/focuswriter/blob/master/NEWS Additional port changes: * Changed to DISTVERSION * Moved USExx statements into one section * Removed INSTALLS_ICONS (not a gtk+ app) * Removed redundant parentheses from post-install-DOCS-on PR: 225770 Submitted by: lightside@gmx.com (maintainer) Approved by: tcberner (mentor, implicit) Changes: head/editors/focuswriter/Makefile head/editors/focuswriter/distinfo
About INSTALLS_ICONS: I have been strongly discouraged from leaving it many times before. If it is really needed, testcase should be provided, and it should be documented. But so far, Mk/ says that it is only for GTK+ apps.