Bug 225770 - editors/focuswriter: Update to 1.6.9
Summary: editors/focuswriter: Update to 1.6.9
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
Keywords: patch
Depends on:
Reported: 2018-02-08 19:19 UTC by lightside
Modified: 2018-02-10 19:57 UTC (History)
2 users (show)

See Also:

Proposed patch (since 457463 revision) (1.18 KB, patch)
2018-02-08 19:19 UTC, lightside
lightside: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description lightside 2018-02-08 19:19:25 UTC
Created attachment 190439 [details]
Proposed patch (since 457463 revision)

Patch to update editors/focuswriter port from 1.6.8 to 1.6.9 version.

Look following links for changes:

- Fix portlint's warning about USES

The build was tested on FreeBSD 10.3 amd64.
Comment 1 lightside 2018-02-08 19:22:07 UTC
There is following portlint's warning:
% pkg info portlint | grep ^Version
Version        : 2.17.15
% portlint 
WARN: Makefile: INSTALLS_ICONS is set, but should not be.
0 fatal errors and 1 warning found.

As I understood, this warning message was proposed in bug #223498. But some tests shows (e.g. with using x11-fm/caja), that in case of mixed environment (GTK+ and Qt applications), the INSTALLS_ICONS=yes maybe required, because it uses ${PREFIX}/bin/gtk-update-icon-cache to update ${LOCALBASE}/share/icons/hicolor/icon-theme.cache. Otherwise (if not use INSTALLS_ICONS=yes), the ${LOCALBASE}/share/applications/focuswriter.desktop may display ${LOCALBASE}/share/pixmaps/focuswriter.xpm, instead of what installed to ${LOCALBASE}/share/icons/hicolor/* (e.g. ${LOCALBASE}/share/icons/hicolor/scalable/apps/focuswriter.svg).
Comment 2 Walter Schwarzenfeld freebsd_triage 2018-02-08 19:37:44 UTC
I think you can ignore the warning. Keep INSTALL_ICONS=yes in the Makefile.
Comment 3 lightside 2018-02-08 19:59:43 UTC
(In reply to comment #2)
> I think you can ignore the warning. Keep INSTALL_ICONS=yes in the Makefile.
Yes, this is what attachment #190439 [details] proposes, i.e. doesn't remove INSTALLS_ICONS=yes. I just wanted to write some explanation in comment #1, in case if committer thinks otherwise.

Thanks for attention.
Comment 4 Walter Schwarzenfeld freebsd_triage 2018-02-08 20:05:14 UTC
INSTALL_ICONS is mostly needed for Gtk. Portlint does not recognize a mixed enviroment.
Comment 5 Yuri Victorovich freebsd_committer 2018-02-10 19:54:02 UTC
Committed, thanks!
Comment 6 commit-hook freebsd_committer 2018-02-10 19:54:36 UTC
A commit references this bug:

Author: yuri
Date: Sat Feb 10 19:53:59 UTC 2018
New revision: 461416
URL: https://svnweb.freebsd.org/changeset/ports/461416

  editors/focuswriter: Update to 1.6.9


  Additional port changes:
  * Changed to DISTVERSION
  * Moved USExx statements into one section
  * Removed INSTALLS_ICONS (not a gtk+ app)
  * Removed redundant parentheses from post-install-DOCS-on

  PR:		225770
  Submitted by:	lightside@gmx.com (maintainer)
  Approved by:	tcberner (mentor, implicit)

Comment 7 Yuri Victorovich freebsd_committer 2018-02-10 19:57:44 UTC
About INSTALLS_ICONS: I have been strongly discouraged from leaving it many times before.

If it is really needed, testcase should be provided, and it should be documented.
But so far, Mk/ says that it is only for GTK+ apps.