Bug 227679 - USES=compiler:c++14-lang update Clang to 6.0
Summary: USES=compiler:c++14-lang update Clang to 6.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL:
Keywords: patch
Depends on: 224591 227686
Blocks: 227682 227683 227684 230790
  Show dependency treegraph
 
Reported: 2018-04-22 05:46 UTC by Jan Beich
Modified: 2018-08-21 00:06 UTC (History)
2 users (show)

See Also:
jbeich: exp-run?


Attachments
v0 (1010 bytes, patch)
2018-04-22 05:47 UTC, Jan Beich
no flags Details | Diff
v0 (2.90 KB, patch)
2018-04-22 05:48 UTC, Jan Beich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2018-04-22 05:46:47 UTC

    
Comment 1 Jan Beich freebsd_committer 2018-04-22 05:47:52 UTC
Created attachment 192712 [details]
v0
Comment 2 Jan Beich freebsd_committer 2018-04-22 05:48:28 UTC
Created attachment 192713 [details]
v0
Comment 3 commit-hook freebsd_committer 2018-04-27 10:09:04 UTC
A commit references this bug:

Author: jbeich
Date: Fri Apr 27 10:08:33 UTC 2018
New revision: 468412
URL: https://svnweb.freebsd.org/changeset/ports/468412

Log:
  lang/solidity: unbreak with Clang 6

  In file included from libsolidity/analysis/ConstantEvaluator.cpp:23:
  In file included from ./libsolidity/analysis/ConstantEvaluator.h:25:
  In file included from ./libsolidity/ast/ASTVisitor.h:25:
  In file included from /usr/include/c++/v1/string:477:
  In file included from /usr/include/c++/v1/string_view:176:
  In file included from /usr/include/c++/v1/__string:56:
  In file included from /usr/include/c++/v1/algorithm:643:
  /usr/include/c++/v1/memory:3656:5: error: destructor called on non-final 'dev::solidity::FixedBytesType' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
      __data_.second().~_Tp();
      ^
  /usr/include/c++/v1/memory:3617:9: note: in instantiation of member function 'std::__1::__shared_ptr_emplace<dev::solidity::FixedBytesType, std::__1::allocator<dev::solidity::FixedBytesType> >::__on_zero_shared' requested here
          __shared_ptr_emplace(_Alloc __a, _Args&& ...__args)
          ^
  /usr/include/c++/v1/memory:4277:26: note: in instantiation of function template specialization 'std::__1::__shared_ptr_emplace<dev::solidity::FixedBytesType, std::__1::allocator<dev::solidity::FixedBytesType> >::__shared_ptr_emplace<int>' requested here
      ::new(__hold2.get()) _CntrlBlk(__a2, _VSTD::forward<_Args>(__args)...);
                           ^
  /usr/include/c++/v1/memory:4656:29: note: in instantiation of function template specialization 'std::__1::shared_ptr<dev::solidity::FixedBytesType>::make_shared<int>' requested here
      return shared_ptr<_Tp>::make_shared(_VSTD::forward<_Args>(__args)...);
                              ^
  ./libsolidity/ast/Types.h:623:19: note: in instantiation of function template specialization 'std::__1::make_shared<dev::solidity::FixedBytesType, int>' requested here
                  m_baseType(std::make_shared<FixedBytesType>(1))
                                  ^
  /usr/include/c++/v1/memory:3656:23: note: qualify call to silence this warning
      __data_.second().~_Tp();
                        ^
  /usr/include/c++/v1/memory:3656:5: error: destructor called on non-final 'dev::solidity::IntegerType' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
      __data_.second().~_Tp();
      ^
  /usr/include/c++/v1/memory:3617:9: note: in instantiation of member function 'std::__1::__shared_ptr_emplace<dev::solidity::IntegerType, std::__1::allocator<dev::solidity::IntegerType> >::__on_zero_shared' requested here
          __shared_ptr_emplace(_Alloc __a, _Args&& ...__args)
          ^
  /usr/include/c++/v1/memory:4277:26: note: in instantiation of function template specialization 'std::__1::__shared_ptr_emplace<dev::solidity::IntegerType, std::__1::allocator<dev::solidity::IntegerType> >::__shared_ptr_emplace<int, dev::solidity::IntegerType::Modifier>' requested here
      ::new(__hold2.get()) _CntrlBlk(__a2, _VSTD::forward<_Args>(__args)...);
                           ^
  /usr/include/c++/v1/memory:4656:29: note: in instantiation of function template specialization 'std::__1::shared_ptr<dev::solidity::IntegerType>::make_shared<int, dev::solidity::IntegerType::Modifier>' requested here
      return shared_ptr<_Tp>::make_shared(_VSTD::forward<_Args>(__args)...);
                              ^
  ./libsolidity/ast/Types.h:718:15: note: in instantiation of function template specialization 'std::__1::make_shared<dev::solidity::IntegerType, int, dev::solidity::IntegerType::Modifier>' requested here
                  return std::make_shared<IntegerType>(160, IntegerType::Modifier::Address);
                              ^
  /usr/include/c++/v1/memory:3656:23: note: qualify call to silence this warning
      __data_.second().~_Tp();
                        ^
  /usr/include/c++/v1/memory:3656:5: error: destructor called on non-final 'dev::solidity::BoolType' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
      __data_.second().~_Tp();
      ^
  /usr/include/c++/v1/memory:3612:5: note: in instantiation of member function 'std::__1::__shared_ptr_emplace<dev::solidity::BoolType, std::__1::allocator<dev::solidity::BoolType> >::__on_zero_shared' requested here
      __shared_ptr_emplace(_Alloc __a)
      ^
  /usr/include/c++/v1/memory:4277:26: note: in instantiation of member function 'std::__1::__shared_ptr_emplace<dev::solidity::BoolType, std::__1::allocator<dev::solidity::BoolType> >::__shared_ptr_emplace' requested here
      ::new(__hold2.get()) _CntrlBlk(__a2, _VSTD::forward<_Args>(__args)...);
                           ^
  /usr/include/c++/v1/memory:4656:29: note: in instantiation of function template specialization 'std::__1::shared_ptr<dev::solidity::BoolType>::make_shared<>' requested here
      return shared_ptr<_Tp>::make_shared(_VSTD::forward<_Args>(__args)...);
                              ^
  libsolidity/analysis/ConstantEvaluator.cpp:58:4: note: in instantiation of function template specialization 'std::__1::make_shared<dev::solidity::BoolType>' requested here
                          make_shared<BoolType>() :
                          ^
  /usr/include/c++/v1/memory:3656:23: note: qualify call to silence this warning
      __data_.second().~_Tp();
                        ^

  PR:		227679
  Reported by:	pkg-fallout, antoine (via exp-run)

Changes:
  head/lang/solidity/Makefile
Comment 4 Jan Beich freebsd_committer 2018-04-27 17:48:38 UTC
After ports r468476 these will be green on 10.* i386:
- cad/opencascade
- games/openmw
- www/firefox
- www/waterfox
Comment 5 commit-hook freebsd_committer 2018-04-27 23:14:54 UTC
A commit references this bug:

Author: jbeich
Date: Fri Apr 27 23:14:32 UTC 2018
New revision: 468505
URL: https://svnweb.freebsd.org/changeset/ports/468505

Log:
  Update USES=compiler:c++14-lang to Clang 6.0 on FreeBSD 10

  PR:		227679
  Exp-run by:	antoine (only 10.4)

Changes:
  head/Mk/Uses/compiler.mk
  head/devel/godot/Makefile
Comment 6 Jan Beich freebsd_committer 2018-04-28 19:00:53 UTC
According to pkg-status no new failures on 10.3.