Bug 227935 - x11/xkeyboard-config Update 2.21 -> 2.23.1 breaks polish
Summary: x11/xkeyboard-config Update 2.21 -> 2.23.1 breaks polish
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-02 19:44 UTC by jakub_lach
Modified: 2018-05-02 22:23 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (x11)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jakub_lach 2018-05-02 19:44:56 UTC 
After the update national symbols not working due to "pl" keymap not recognized in xorg.conf. Reverting to 2.21 fixes it. 


syntax error: line 500 of pl
The XKEYBOARD keymap compiler (xkbcomp) reports:
> Error:            Error interpreting include file "pl"
>                   Exiting
>                   Abandoning symbols file "default"
Errors from xkbcomp are not fatal to the X server
Comment 1 Piotr Kubaj freebsd_committer freebsd_triage 2018-05-02 19:50:25 UTC 
Seconded, I can confirm this issue.
Comment 3 jakub_lach 2018-05-02 21:24:50 UTC 
(In reply to Piotr Kubaj from comment #2)

Thanks! You were faster :)

For reference, interaction with committer -  

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227079
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2018-05-02 21:32:13 UTC 
This also should be discussed with the upstream.
Port can't protect from broken features or bugs.
We can only add patches to adopt the code so that it builds, or backport fixes that haven't yet been released.

So if the upstream fixes the problem, we can add a patch.
Comment 5 Piotr Kubaj freebsd_committer freebsd_triage 2018-05-02 21:45:55 UTC 
(In reply to Yuri Victorovich from comment #4)
Have you read the bug report I posted?

It clearly says that the patch is committed.
Comment 6 commit-hook freebsd_committer freebsd_triage 2018-05-02 22:23:25 UTC 
A commit references this bug:

Author: yuri
Date: Wed May  2 22:23:22 UTC 2018
New revision: 468890
URL: https://svnweb.freebsd.org/changeset/ports/468890

Log:
  x11/xkeyboard-config: Fix the polish keyboard bug introduced in 2.23.1

  Backport of the fix.
  Unbreaks the feature.

  PR:		227935
  Submitted by:	jakub_lach@mailplus.pl
  Approved by:	portmgr (port compliance, infrastructure)

Changes:
  head/x11/xkeyboard-config/Makefile
  head/x11/xkeyboard-config/files/patch-polish-typo-upstream-bugno104904
Comment 7 Yuri Victorovich freebsd_committer freebsd_triage 2018-05-02 22:23:31 UTC 
Committed, thanks!