Hello! Can you please do an exp-run on head w/ WITH_BSD_GREP="yes" set? I think I had fixed most of the breakage in an exp-run many moons ago, but have no idea what might have crept in since then- the fallout shouldn't be the most terrifying, though. There is some interest in flipping over to bsdgrep in -HEAD, even in its current state WITHOUT_GNU_GREP_COMPAT, while I finish up some details.
It seems print/lilypond-devel fails to configure : http://package18.nyi.freebsd.org/data/headi386bsdgrepcxx98-default/2018-06-27_05h27m54s/logs/errors/lilypond-devel-2.19.81_1.log It seems www/luakit fails to build: http://package18.nyi.freebsd.org/data/headi386bsdgrepcxx98-default/2018-06-27_05h27m54s/logs/errors/luakit-2017.08.10_1.log It seems www/mod_pagespeed fails to stage: http://package18.nyi.freebsd.org/data/headi386bsdgrepcxx98-default/2018-06-27_05h27m54s/logs/errors/ap24-mod_pagespeed-1.12.34.2_12,1.log It seems devel/icmake fails to stage: http://package18.nyi.freebsd.org/data/headi386bsdgrepcxx98-default/2018-06-27_05h27m54s/logs/errors/icmake-9.02.07.log It seems emulators/mame and emulators/mess fail to build: http://package18.nyi.freebsd.org/data/headi386bsdgrepcxx98-default/2018-06-27_05h27m54s/logs/errors/mame-0.198.log http://package18.nyi.freebsd.org/data/headi386bsdgrepcxx98-default/2018-06-27_05h27m54s/logs/errors/mess-0.198.log
Hi Antoine, Thanks! It seems my work has progressed a little bit differently than I thought, and I might be able to fix these just by re-enabling GNU extensions in our bsdgrep with the GNU-compat bits I'm about to add to libregex. I have one other patch that should get an exp-run because it inevitably will break things, maybe even in the ports framework, but then I'd like to revisit this with a patch to flip BSD_GREP and GNU_GREP_COMPAT instead.
Hi, Please re-run this now -- as of base r368358, bsdgrep will now use libregex by default and should implement all of the extensions that ports needs. WITH_BSD_GREP="yes" is still sufficient.
Exp-run looks fine
*** Bug 218385 has been marked as a duplicate of this bug. ***
A commit references this bug: Author: kevans Date: Tue Dec 8 14:05:26 UTC 2020 New revision: 368439 URL: https://svnweb.freebsd.org/changeset/base/368439 Log: src.opts.mk: switch to bsdgrep as /usr/bin/grep This has been years in the making, and we all knew it was bound to happen some day. Switch to the BSDL grep implementation now that it's been a little more thoroughly tested and theoretically supports all of the extensions that gnugrep in base had with our libregex(3). Folks shouldn't really notice much from this update; bsdgrep is slower than gnugrep, but this is currently the price to pay for fewer bugs. Those dissatisfied with the speed of grep and in need of a faster implementation should check out what textproc/ripgrep and textproc/the_silver_searcher can do for them. I have some WIP to make bsdgrep faster, but do not consider it a blocker when compared to the pros of switching now (aforementioned bugs, licensing). PR: 228798 (exp-run) PR: 128645, 156704, 166842, 166862, 180937, 193835, 201650 PR: 232565, 242308, 246000, 251081, 191086, 194397 Relnotes: yes, please Changes: head/share/mk/src.opts.mk
(In reply to Antoine Brodin from comment #4) Thanks, Antoine!