Bug 233824 - [NEW PORT] textproc/py-precis_i18n: Internationalized usernames and passwords
Summary: [NEW PORT] textproc/py-precis_i18n: Internationalized usernames and passwords
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs mailing list
URL:
Keywords: feature, needs-qa
Depends on:
Blocks: 233826
  Show dependency treegraph
 
Reported: 2018-12-06 12:01 UTC by Goran Mekić
Modified: 2018-12-12 09:07 UTC (History)
2 users (show)

See Also:
koobs: maintainer-feedback+


Attachments
py-precis_i18n.shar (1.58 KB, text/plain)
2018-12-06 12:01 UTC, Goran Mekić
no flags Details
py-precis_i18n.shar (1.70 KB, text/plain)
2018-12-11 15:55 UTC, Goran Mekić
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Goran Mekić 2018-12-06 12:01:19 UTC
Created attachment 199888 [details]
py-precis_i18n.shar
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2018-12-07 10:50:20 UTC
Review items:

- textproc is probably a better primary category for this port, leaving devel and python as secondary categories.

- Add LICENSE_FILE when one is packaged with the distribution file. This one contains a LICENSE.txt file. 

- Specify supported versions as accurately as possible without being incorrect. setup.py:classifiers specifies 3.3+ (3.3-3.6) as the supported/required Python versions, port does not specify anything (in particular leaving open 2.x as a supported version).

- Set TEST_DEPENDS and create a test (do-test:) target when a Python package supports running tests. This package packages tests and has integrated support for the python setup.py test command to run them, so add:

do-test:
  @cd ${WRKSRC} && ${PYTHON_CMD} ${PYDISTUTILS_SETUP} test
Comment 2 Goran Mekić 2018-12-11 15:55:43 UTC
Created attachment 200043 [details]
py-precis_i18n.shar

I tested in an empty jail and I didn't have to set anything in TEST_DEPENDS for "make test" to work. Thanks for the guide!