Bug 233924 - Unable to maintainer approve patches not uploaded by me
Summary: Unable to maintainer approve patches not uploaded by me
Status: Open
Alias: None
Product: Services
Classification: Unclassified
Component: Bug Tracker (show other bugs)
Version: unspecified
Hardware: Any Any
: --- Affects Some People
Assignee: Kubilay Kocak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-11 08:13 UTC by Shane
Modified: 2018-12-11 09:40 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Shane 2018-12-11 08:13:44 UTC
When I add a patch, I am able to flag it as maintainer approved but this does not work for patches that someone else has uploaded.

I can approve a bug report that others create but not individual patches.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2018-12-11 09:39:54 UTC
This is expected default Bugzilla behaviour, where objects (bugs/attachments/flags) can only be modified by the creator of those objects, not a bug.

One can modify the maintainer-feedback flag because the Auto-Assigner automatically sets maintainer-feedback value to ? with the maintainers email as the value, allowing the bugzilla account with that email to change the flags value.

We will be making changes in the future to have attachments follow the same behaviour.

In the meantime, the attachment creator can manually set maintainer-approval ? <maintainer-email>, which will then allow you to approve it.