Bug 235275 - Multiply bundled GH_TUPLE repositories result in broken links
Summary: Multiply bundled GH_TUPLE repositories result in broken links
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-28 08:34 UTC by Yuri Victorovich
Modified: 2019-07-31 23:02 UTC (History)
1 user (show)

See Also:


Attachments
Makefile (753 bytes, text/plain)
2019-01-28 08:34 UTC, Yuri Victorovich
no flags Details
patch (593 bytes, patch)
2019-07-31 22:34 UTC, Yuri Victorovich
no flags Details | Diff
testcase.shar (77.84 KB, text/plain)
2019-07-31 23:02 UTC, Yuri Victorovich
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer 2019-01-28 08:34:12 UTC
Created attachment 201474 [details]
Makefile

The port with the attached Makefile creates broken links for multiply defined GH_TUPLE elements.

How to reproduce:
1. Save the attached Makefile as /usr/ports/devel/om/Makefile
2. cd /usr/ports/devel/om
3. Run: make makesum extract
4. Observe how all 'common' links except for one are broken:
> $ ls -l ./work/OpenModelica-1.14.0-dev/OMEdit/common
> lrwxr-xr-x  1 yuri  users  41 Jan 28 00:28 ./work/OpenModelica-1.14.0-dev/OMEdit/common -> OpenModelica-1.14.0-dev/OMCompiler/common
> $ ls -l ./work/OpenModelica-1.14.0-dev/OMEdit/common/
> ls: ./work/OpenModelica-1.14.0-dev/OMEdit/common/: No such file or directory
> $ ls -l OpenModelica-1.14.0-dev/OMCompiler/common/
> ls: OpenModelica-1.14.0-dev/OMCompiler/common/: No such file or directory

Only the first instance of 'common' is usable: ./work/OpenModelica-1.14.0-dev/OMCompiler/common
All subsequent links that are supposed to link to it are broken.
Comment 1 Yuri Victorovich freebsd_committer 2019-07-31 22:34:38 UTC
Created attachment 206184 [details]
patch

The attached patch solves the problem.

It should create links with the full path to the original directory.
Comment 2 Yuri Victorovich freebsd_committer 2019-07-31 23:02:01 UTC
Created attachment 206185 [details]
testcase.shar

Attaching the sample port that is fixed by this patch.