Bug 235496 - mail/spamd: FreeBSD 12 build failure
Summary: mail/spamd: FreeBSD 12 build failure
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Olli Hauer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-04 14:56 UTC by Maxime Soulé
Modified: 2020-04-20 19:49 UTC (History)
5 users (show)

See Also:
yds: maintainer-feedback-


Attachments
Patch to correct the compilation problem (4.76 KB, patch)
2019-02-04 14:56 UTC, Maxime Soulé
no flags Details | Diff
statically link libressl to unbreak OpenSSL111 (1.28 KB, patch)
2019-02-12 22:07 UTC, yds
no flags Details | Diff
Fix spamd port (5.50 KB, patch)
2019-05-05 16:54 UTC, foudfou
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maxime Soulé 2019-02-04 14:56:58 UTC
Created attachment 201721 [details]
Patch to correct the compilation problem

Hi,

mail/spamd port does not compile anymore against FreeBSD 12.0 since some functions have been deprecated on openssl side since 1.1.0.

> openssl version
OpenSSL 1.1.1a-freebsd  20 Nov 2018
> type openssl
openssl is /usr/bin/openssl

The attached patch fixes the problem.

Best regards,

Max.
Comment 1 Morgan Wesström 2019-02-10 21:47:58 UTC
For info, I've successfully been using the patch that was attached to the same bug in mail/spamassassin. The patches seems almost identical.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228940
Comment 2 yds 2019-02-12 22:07:25 UTC
Created attachment 201967 [details]
statically link libressl to unbreak OpenSSL111

an alternate recipe to statically link libressl to unbreak OpenSSL111 shamelessly stolen from the net/openntpd port
Comment 3 foudfou 2019-05-05 16:54:59 UTC
Created attachment 204226 [details]
Fix spamd port

Didn't see this bug report prior to trying to fix. Still attaching my patch which targets the whole port.
Comment 4 daniel.engberg.lists 2020-03-16 16:44:59 UTC
Oliver, can you have at look at this?
Comment 5 yds 2020-03-16 16:58:49 UTC
yes, could someone please look at this..

I created the diff for this PR a year ago.. then forgot I did that and rolled another diff (almost a year later to the day) for PR #243963 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243963

and a few others have spent much more time than I making OpenSSL patches to fix this issue.
Comment 6 commit-hook freebsd_committer 2020-03-30 21:11:15 UTC
A commit references this bug:

Author: ohauer
Date: Mon Mar 30 21:10:10 UTC 2020
New revision: 529921
URL: https://svnweb.freebsd.org/changeset/ports/529921

Log:
  - fix build against openssl 1.x
  - do not add /etc/service entries during install
  - add helper script to add /etc/services entries
  - remove unused pkg-deinstall
  - portlint

  PR:		235496
  Submitted by:	Maxime Soule
  Reported by:	many

Changes:
  head/mail/spamd/Makefile
  head/mail/spamd/files/add-spamd-to-etc-service
  head/mail/spamd/files/patch-spamd_sync.c
  head/mail/spamd/files/pkg-install.in
  head/mail/spamd/files/pkg-message.in
  head/mail/spamd/pkg-deinstall