Bug 237822 - x11-toolkits/pango: Fails to configure with DOCS=ON X11=OFF: ERROR: Unknown variable "xft_dep". (since 1.42.4_2, ports r500960)
Summary: x11-toolkits/pango: Fails to configure with DOCS=ON X11=OFF: ERROR: Unknown v...
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-gnome mailing list
URL:
Keywords: needs-patch, regression
Depends on:
Blocks:
 
Reported: 2019-05-10 09:26 UTC by Matthias Fechner
Modified: 2019-06-12 22:42 UTC (History)
16 users (show)

See Also:
bugzilla: maintainer-feedback? (gnome)


Attachments
Pango build log (31.69 KB, text/plain)
2019-05-10 21:06 UTC, Joseph Mulloy
no flags Details
pango-1.42.4_2-DOCS=ON-X11=OFF.log (28.40 KB, text/plain)
2019-05-24 04:15 UTC, Kubilay Kocak
no flags Details
Failed to build with docs on and X11 off (31.37 KB, text/plain)
2019-05-24 05:28 UTC, Matthias Fechner
no flags Details
[patch] fix configure error if DOCS=on X11=off after ports r480951 (when DOCS was spelled GTKDOC) (873 bytes, patch)
2019-06-12 22:40 UTC, John Hein
jcfyecrayz: maintainer-approval? (gnome)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Fechner freebsd_committer 2019-05-10 09:26:24 UTC
I get the following error:
DEPRECATION: Project targetting '>= 0.43.0' but tried to use feature deprecated since '0.48.0': python3 module
Configuring gtkdocentities.ent using configuration
Configuring version.xml using configuration

docs/meson.build:71:11: ERROR: Unknown variable "xft_dep".

A full log can be found at /wrkdirs/usr/ports/x11-toolkits/pango/work/pango-1.42.4/_build/meson-logs/meson-log.txt

Full build log is here:
https://pkg.fechner.net/data/120amd64-default/2019-05-10_10h42m45s/logs/errors/pango-1.42.4_2.log
Comment 1 Dani 2019-05-10 15:01:53 UTC
Same here..

Happens since ports r500960
Comment 2 w.schwarzenfeld freebsd_triage 2019-05-10 20:46:31 UTC
If I set X11 option to on in compiles fine.
Comment 3 Joseph Mulloy 2019-05-10 20:56:06 UTC
I'm also getting this. I build in Poudriere. As a workaround I turned off the DOCS option on the port and it builds fine.
Comment 4 Joseph Mulloy 2019-05-10 21:06:05 UTC
Created attachment 204315 [details]
Pango build log

wrkdir is slightly too large to attach so here's a link https://files.jdmulloy.com/freebsd_bugs/237822/pango-1.42.4_2.tbz
Comment 5 Stephan Muhs 2019-05-11 03:32:10 UTC
(In reply to Joseph Mulloy from comment #3)

Same here, build fails with DOCS enabled, works with DOCs disabled
Comment 6 w.schwarzenfeld freebsd_triage 2019-05-12 10:26:21 UTC
I have tried an update to 1.43.0. This seems to work.

But I think this has to be tested for ports are depend on pango.
Comment 7 Greg Cunningham 2019-05-13 06:09:58 UTC
I'm getting the same error on several 12.0-RELEASE instances.  Un-selecting 

[ ] DOCS ...

allowed it to build.
Comment 8 Palle Girgensohn freebsd_committer 2019-05-13 10:44:13 UTC
Same problem here...

Smells like the dependency on X11 is the real problem though? I build with

OPTIONS_UNSET= X11 NLS

Probably the docs expect som X11 stuff to build as well?

Palle
Comment 9 w.schwarzenfeld freebsd_triage 2019-05-13 12:03:03 UTC
Seems pkgconfig is the problem. In the new version there is no meson.build in the workdirectory and no *.pc.in files. Also no Makefile.am and Makefile.in. Seems they changed a lot of the configuration.
Comment 10 Leon Dietrich 2019-05-20 08:56:32 UTC
I just tried to compile it with X11 and DOCS turned off. It also failed.
Comment 11 Palle Girgensohn freebsd_committer 2019-05-20 09:00:18 UTC
(In reply to Leon Dietrich from comment #10)

you mean that

OPTIONS_UNSET= X11 NLS

and it still failed. That is the opposite of my experience?
Comment 12 Leon Dietrich 2019-05-20 09:05:32 UTC
My failing configuration:

$ cat /usr/local/etc/poudriere.d/server-12_0-HEAD-options/x11-toolkits_pango/options

# This file is auto-generated by 'make config'.
# Options for pango-1.42.4
_OPTIONS_READ=pango-1.42.4
_FILE_COMPLETE_OPTIONS_LIST=GTKDOC X11
OPTIONS_FILE_UNSET+=GTKDOC
OPTIONS_FILE_UNSET+=X11
Comment 13 Rogg 2019-05-21 19:04:24 UTC
Had the same problem, disabling DOCS helped. My actual options:

cat /usr/local/etc/poudriere.d/11_2-amd64-server-options/x11-toolkits_pango/options 
# This file is auto-generated by 'make config'.
# Options for pango-1.42.4_2
_OPTIONS_READ=pango-1.42.4_2
_FILE_COMPLETE_OPTIONS_LIST=DOCS X11
OPTIONS_FILE_UNSET+=DOCS
OPTIONS_FILE_UNSET+=X11
Comment 14 Kubilay Kocak freebsd_committer freebsd_triage 2019-05-24 04:15:21 UTC
Created attachment 204585 [details]
pango-1.42.4_2-DOCS=ON-X11=OFF.log
Comment 15 Kubilay Kocak freebsd_committer freebsd_triage 2019-05-24 04:17:12 UTC
Test matrix:

DOCS=ON X11=ON - OK
DOCS=ON X11=OFF - FAIL
DOCS=OFF X11=ON - OK
DOCS=OFF X11=OFF - OK

@triage: CC committer of ports r500960
Comment 16 Kubilay Kocak freebsd_committer freebsd_triage 2019-05-24 04:17:59 UTC
@Matthias Could you please include your failure log as an attachment, as external URL references can become stale/go missing over time. Thanks!
Comment 17 Matthias Fechner freebsd_committer 2019-05-24 05:28:00 UTC
Created attachment 204586 [details]
Failed to build with docs on and X11 off

(In reply to Kubilay Kocak from comment #16)

sure, here it is.
Comment 18 John Hein 2019-06-12 21:17:13 UTC
I think the problem existed before ports r500960 if you had the GTKDOC option on (which is now named the DOCS option).

Did anyone test with GTKDOC on (and X11 off) after ports r480951 (which added the conditional xft_dep change)?

It looks like ports r480951 was missing this patch:

--- work/pango-1.42.4/docs/meson.build.orig     2019-06-12 21:06:45 UTC
+++ work/pango-1.42.4/docs/meson.build
@@ -68,8 +68,10 @@
   docdeps += libpangoft2_dep
 endif
 
-if xft_dep.found()
-  docdeps += libpangoxft_dep
+if get_option('xft')
+  if xft_dep.found()
+    docdeps += libpangoxft_dep
+  endif
 endif
 
 if cairo_dep.found()
Comment 19 John Hein 2019-06-12 22:40:16 UTC
Created attachment 205022 [details]
[patch] fix configure error if DOCS=on X11=off after ports r480951 (when DOCS was spelled GTKDOC)

Attached is a patch to resolve the configure-time bug when DOCS=on and X11=off.  This should have been applied when ports r480951 was committed.  It was exposed more widely when ports r500960 turned renamed GTKDOC (which was off by default) to DOCS which is on by default (i.e., on for most users).
Comment 20 John Hein 2019-06-12 22:42:32 UTC
Comment on attachment 205022 [details]
[patch] fix configure error if DOCS=on X11=off after ports r480951 (when DOCS was spelled GTKDOC)

Asking for maintainer-approval (gnome@) for the patch - start the timer.