Bug 244541 - devel/py-zope.testbrowser: Correct USES-python:<version-spec> (Allow python3 support)
Summary: devel/py-zope.testbrowser: Correct USES-python:<version-spec> (Allow python3 ...
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Ruslan Makhmatkhanov
URL:
Keywords: needs-qa
Depends on:
Blocks: 244540 244542 249337
  Show dependency treegraph
 
Reported: 2020-03-01 12:18 UTC by Christopher May-Townsend
Modified: 2020-10-13 22:03 UTC (History)
5 users (show)

See Also:
bugzilla: maintainer-feedback? (zope)
koobs: merge-quarterly?


Attachments
python3 support (733 bytes, patch)
2020-03-01 12:18 UTC, Christopher May-Townsend
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher May-Townsend 2020-03-01 12:18:58 UTC
Created attachment 212075 [details]
python3 support

In getting searx running on python3, I need this to be python 3 compatible, installs fine during testing. So not sure of any downsides to this?
Comment 1 Christopher May-Townsend 2020-03-01 12:19:33 UTC
do we need to add a revision line to this for a python version change?
Comment 2 Zane C. Bowers-Hadley 2020-03-09 05:31:55 UTC
Just stumbled across this as I was about to submit the same thing for getting searx working with python3.

I can confirm that this works.

Don't see any need to dump port revision. Will automatically get built for 3 when something that needs it for 3 uses it.
Comment 3 Ruslan Makhmatkhanov freebsd_committer 2020-05-04 08:19:04 UTC
Hello, 

there are problems with making py3 package, see poudriere testport excerpt below [2]. And splinter requires zope.testbrowser >= 5.2.4 according to it's setup.py. New zope.testbrowser 5.2.4 requires WSGIProxy2 [1], that we haven't in ports. So just removing the python limit will not do the thing, imho.

 

[1] https://pypi.org/project/WSGIProxy2/

[2] writing byte-compilation script '/tmp/tmp9039bbav.py'
/usr/local/bin/python3.7 /tmp/tmp9039bbav.py
  File "/usr/local/lib/python3.7/site-packages/zope/testbrowser/browser.py", line 65
    def control_form_tuple_repr((ctrl, form)):
                                ^
SyntaxError: invalid syntax

  File "/usr/local/lib/python3.7/site-packages/zope/testbrowser/tests/test_browser.py", line 79
    print request_string.replace('\r', '')
                       ^
SyntaxError: invalid syntax

  File "/usr/local/lib/python3.7/site-packages/zope/testbrowser/ftests/wsgitestapp.py", line 51
    except Exception, exc:
                    ^
SyntaxError: invalid syntax

removing /tmp/tmp9039bbav.py
running install_egg_info
Copying src/zope.testbrowser.egg-info to /wrkdirs/usr/ports/devel/py-zope.testbrowser/work-py37/stage/usr/local/lib/python3.7/site-packages/zope.testbrowser-4.0.4-py3.7.egg-info
Installing /wrkdirs/usr/ports/devel/py-zope.testbrowser/work-py37/stage/usr/local/lib/python3.7/site-packages/zope.testbrowser-4.0.4-py3.7-nspkg.pth
running install_scripts
writing list of installed files to '/wrkdirs/usr/ports/devel/py-zope.testbrowser/work-py37/.PLIST.pymodtmp'
  File "/usr/local/lib/python3.7/site-packages/zope/testbrowser/browser.py", line 65
    def control_form_tuple_repr((ctrl, form)):
                                ^
SyntaxError: invalid syntax

  File "/usr/local/lib/python3.7/site-packages/zope/testbrowser/tests/test_browser.py", line 79
    print request_string.replace('\r', '')
                       ^
SyntaxError: invalid syntax

  File "/usr/local/lib/python3.7/site-packages/zope/testbrowser/ftests/wsgitestapp.py", line 51
    except Exception, exc:
                    ^
SyntaxError: invalid syntax
Comment 4 Ruslan Makhmatkhanov freebsd_committer 2020-08-10 08:43:50 UTC
I'll take it.