On behalf of a user on -ports: Yesterday, I updated gitea on my FreeBSD server. I updated using pkg. While `pkg info gitea` claims that the installed version is 1.11.2, the command `gitea -v` claims that I'm running 1.9.0-dev. At the same time, my instance does have the new features that have been released in 1.11.2.
The version number reported by the gitea binary is wrong. I'll check the build to see why the VERSION file is not picked up properly.
Created attachment 212311 [details] Fix version string Ok, the problem here is that we're passing LDFLAGS in MAKE_ARGS, which winds up clobbering the LDFLAGS that WRKSRC/Makefile sets (which includes the version string). Passing the LDFLAGS in MAKE_ENV fixes that. Doing so, however, exposes another problem whereby the '-fstack-protector-string' from Mk/bsd.ssp.mk breaks the build. I have no idea whether golang supports stack protection, but disabling it (as appears in the patch) makes the build work. If you're aware of golang supporting stack protection, then we need to do something else (possibly allowing the ssp LDFLAGS to be overridden as the SSP_CFLAGS are).
Hi, do you have input here on what approach you'd like to take?
Should be fixed by bug 244898. Thanks adamw!
^Triage: Re-open until dependent bug(s) are closed
Ideally this bug fix can land prior to the version update in bug 244898, so that the bugfix can be merged to the quarterly branch, unless the version update is also a bugfix only release, in which case all of bug 244898 can be committed to head and merged to quarterly
(In reply to Kubilay Kocak from comment #6) Release 1.11.3 (in bug 244898) is a pure bug fix release.
I'm a little confused. Does something in this PR need to be fixed? Or can we close it?
(In reply to Adam Weinberger from comment #8) No, with the current version of the port, everything is fine. I think this can be closed.
Thanks, Stefan.