Bug 244898 - www/gitea: Update to 1.11.3
Summary: www/gitea: Update to 1.11.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Adam Weinberger
URL: https://blog.gitea.io/2020/03/gitea-1...
Keywords: buildisok
Depends on:
Blocks: 244671 244710
  Show dependency treegraph
 
Reported: 2020-03-18 21:03 UTC by Stefan Bethke
Modified: 2020-03-19 17:39 UTC (History)
1 user (show)

See Also:


Attachments
Patch to update the port to Gitea 1.10.2 (1.45 KB, patch)
2020-03-18 21:13 UTC, Stefan Bethke
no flags Details | Diff
Patch to update the port to Gitea 1.11.3 (1.45 KB, patch)
2020-03-18 21:13 UTC, Stefan Bethke
no flags Details | Diff
Patch to update the port to Gitea 1.11.3 (3.13 KB, patch)
2020-03-18 21:14 UTC, Stefan Bethke
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Bethke 2020-03-18 21:03:09 UTC
Update gitea port to 1.11.13

This release fixes three bugs.

Release notes: https://blog.gitea.io/2020/03/gitea-1.11.3-and-1.10.6-released/

Also fix LDFLAGS so that the version number (among other things) is built into the binary correctly, and make the regexp used in the Makefile work with bsdgrep (both thanks to adamw).
Comment 1 Stefan Bethke 2020-03-18 21:13:09 UTC
Created attachment 212512 [details]
Patch to update the port to Gitea 1.10.2
Comment 2 Stefan Bethke 2020-03-18 21:13:49 UTC
Created attachment 212513 [details]
Patch to update the port to Gitea 1.11.3
Comment 3 Stefan Bethke 2020-03-18 21:14:41 UTC
Created attachment 212514 [details]
Patch to update the port to Gitea 1.11.3
Comment 4 Stefan Bethke 2020-03-18 21:16:21 UTC
This closes bug 244671 and bug 244710.
Comment 5 Automation User 2020-03-18 21:39:48 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/127573466
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2020-03-19 01:37:06 UTC
For future reference, its desirable and preferable to separate bug fixes from version updates, so that the former can be merged to the quarterly branch
Comment 7 Adam Weinberger freebsd_committer freebsd_triage 2020-03-19 16:08:08 UTC
The upstream regex is just ludicrous. The original one (in addition to bring broken) will match the 64 in amd64. The go version appears right after the word "go". I'm going to change the regex to just look for that. If you want me to change it back please just send me an email or attach a note here.

The regex in the patch looks like it was copied from the NODE_VERSION regex, which is problematic (it'll fail on, for example, 2.0).
Comment 8 commit-hook freebsd_committer freebsd_triage 2020-03-19 16:17:01 UTC
A commit references this bug:

Author: adamw
Date: Thu Mar 19 16:16:36 UTC 2020
New revision: 528729
URL: https://svnweb.freebsd.org/changeset/ports/528729

Log:
  gitea: Update to 1.11.3

  This release fixes three bugs.

  Release notes: https://blog.gitea.io/2020/03/gitea-1.11.3-and-1.10.6-released/

  Also fix LDFLAGS so that the version number (among other things) is built into
  the binary correctly, and make the regexp used in the Makefile work with
  bsdgrep (both thanks to adamw).

  Will MFH due to bsdgrep build failure and stopwatch panic fix.

  PR:		244898
  Submitted by:	maintainer
  MFH:		2020Q1

Changes:
  head/www/gitea/Makefile
  head/www/gitea/distinfo
  head/www/gitea/files/patch-Makefile
Comment 9 commit-hook freebsd_committer freebsd_triage 2020-03-19 16:19:02 UTC
A commit references this bug:

Author: adamw
Date: Thu Mar 19 16:18:48 UTC 2020
New revision: 528731
URL: https://svnweb.freebsd.org/changeset/ports/528731

Log:
  MFH: r528631 r528729

  www/gitea: Use OPTIONS_SUB

  gitea: Update to 1.11.3

  This release fixes three bugs.

  Release notes: https://blog.gitea.io/2020/03/gitea-1.11.3-and-1.10.6-released/

  Also fix LDFLAGS so that the version number (among other things) is built into
  the binary correctly, and make the regexp used in the Makefile work with
  bsdgrep (both thanks to adamw).

  Will MFH due to bsdgrep build failure and stopwatch panic fix.

  PR:		244898
  Submitted by:	maintainer

  Approved by:	portmgr (with hat)

Changes:
_U  branches/2020Q1/
  branches/2020Q1/www/gitea/Makefile
  branches/2020Q1/www/gitea/distinfo
  branches/2020Q1/www/gitea/files/patch-Makefile
  branches/2020Q1/www/gitea/pkg-plist
Comment 10 Stefan Bethke 2020-03-19 16:29:06 UTC
(In reply to Adam Weinberger from comment #7)

Absolutely fine by me.  I#ve had quite the discussion upstream, let's see where that leads.
https://github.com/go-gitea/gitea/pull/10765
Comment 11 Adam Weinberger freebsd_committer freebsd_triage 2020-03-19 17:39:23 UTC
This is all committed. I'll keep an eye on that upstream discussion though I suspect there will be a hilariously overengineered solution coming.