Bug 248885 - security/openvpn-auth-ldap: breaks under future -fno-common defaults
Summary: security/openvpn-auth-ldap: breaks under future -fno-common defaults
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Matthias Andree
URL:
Keywords:
Depends on:
Blocks: 248756
  Show dependency tree / graph
 
Reported: 2020-08-24 17:39 UTC by Matthias Andree
Modified: 2020-08-24 17:41 UTC (History)
0 users

See Also:
mandree: maintainer-feedback+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Andree freebsd_committer freebsd_triage 2020-08-24 17:39:01 UTC 
+++ This bug was initially created as a clone of Bug #248845 +++

pkg-fallout reported duplicate symbols in the link stage for security/openvpn-auth-ldap, such as:

--- openvpn-auth-ldap.so ---

ld: error: duplicate symbol: objc_method_cache_version
>>> defined at auth-ldap.m
>>>            auth-ldap.o:(objc_method_cache_version)
>>> defined at TRConfig.m
>>>            TRConfig.o:(.bss+0x30) in archive ./libauth-ldap.a

ld: error: duplicate symbol: objc_method_cache_version
>>> defined at auth-ldap.m
>>>            auth-ldap.o:(objc_method_cache_version)
>>> defined at TRAuthLDAPConfig.m
>>>            TRAuthLDAPConfig.o:(.bss+0x48) in archive ./libauth-ldap.a
--- testplugin ---

ld: error: duplicate symbol: objc_method_cache_version
>>> defined at auth-ldap.m
>>>            auth-ldap.o:(objc_method_cache_version)
>>> defined at TRAuthLDAPConfig.m
>>>            TRAuthLDAPConfig.o:(.bss+0x48) in archive ./libauth-ldap.a



Since openvpn-auth-ldap is old code and Objective-C (libobjc2) may need more fixing, for the time being, add CFLAGS+=-fcommon to openvpn-auth-ldap.
Comment 1 commit-hook freebsd_committer freebsd_triage 2020-08-24 17:41:33 UTC 
A commit references this bug:

Author: mandree
Date: Mon Aug 24 17:40:54 UTC 2020
New revision: 546102
URL: https://svnweb.freebsd.org/changeset/ports/546102

Log:
  security/openvpn-auth-ldap: add -fcommon to future-proof

  libobjc2 may need some love, but I'm not too acquainted with
  Objective-C to do that... so limit my effort to my own port

  PR:		248885
  Reported by:	pkg-fallout@ on FreeBSD -head

Changes:
  head/security/openvpn-auth-ldap/Makefile