Bug 252767 - Making graphics/mirtk depend on onetbb
Summary: Making graphics/mirtk depend on onetbb
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Yuri Victorovich
URL: https://github.com/BioMedIA/MIRTK/iss...
Keywords:
Depends on:
Blocks: 252648
  Show dependency tree / graph
 
Reported: 2021-01-17 08:07 UTC by Ganael LAPLANCHE
Modified: 2021-01-18 11:39 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (yuri)
martymac: maintainer-feedback? (yuri)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ganael LAPLANCHE freebsd_committer freebsd_triage 2021-01-17 08:07:19 UTC 
Hello,

As a maintainer of graphics/mirtk, could you have a look at PR #252648:

  https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252648

In short, TBB version 2021 will soon be available as devel/onetbb but the port you maintain does not build correctly with it, see the following Poudriere run:

  http://box.martymac.org/FreeBSD-Packages/build.html?mastername=FBSD122amd64-tbb-migr&build=2021-01-13_22h35m17s

and error logs:

http://box.martymac.org/FreeBSD-Packages/data/FBSD122amd64-tbb-migr/2021-01-15_15h54m22s/logs/errors/mirtk-2.0.0.122_1.log

-- Looking for TBB [tbb] (optional)... - not found
[...]

Could you try to provide a patch (important: *by replying to this PR*) to facilitate the migration to devel/onetbb ?

To help you modifying your port, expected patches to devel/tbb and devel/onetbb are available in PR #252648.

You will also need suitesparse patches from PR #252651 as suitesparse does not build with oneTbb.

Thanks for your contribution,
Best regards,

Ganael.
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2021-01-17 17:16:46 UTC 
Optional dependency on TBB is now OFF by default.
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-01-17 17:16:57 UTC 
A commit references this bug:

Author: yuri
Date: Sun Jan 17 17:16:41 UTC 2021
New revision: 561837
URL: https://svnweb.freebsd.org/changeset/ports/561837

Log:
  graphics/mirtk: Change the default of the TBB option to OFF until the upstream makes iy oneTBB-compatible.

  PR:		252767
  Reported by:	martymac

Changes:
  head/graphics/mirtk/Makefile
Comment 3 Ganael LAPLANCHE freebsd_committer freebsd_triage 2021-01-18 11:39:16 UTC 
Thanks!