Bug 256558 - lang/python3[89]: fix build WITH_DEBUG
Summary: lang/python3[89]: fix build WITH_DEBUG
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-python (Nobody)
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2021-06-11 19:10 UTC by Dmitry Marakasov
Modified: 2021-07-14 20:32 UTC (History)
3 users (show)

See Also:
koobs: maintainer-feedback? (python)


Attachments
Patch (19.80 KB, patch)
2021-06-11 19:10 UTC, Dmitry Marakasov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer 2021-06-11 19:10:04 UTC
Created attachment 225746 [details]
Patch

For python >= 3.8, names of installed .so files are different for DEBUG builds. Cope with that in the plists.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2021-06-11 22:28:44 UTC
ABIFLAGS was added to handled these cases and worked correctly at the time. What happened?
Comment 2 Dmitry Marakasov freebsd_committer 2021-06-15 10:57:51 UTC
(In reply to Kubilay Kocak from comment #1)
I have no idea. Why are you asking me? You are python@.
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2021-06-15 12:00:00 UTC
(In reply to Dmitry Marakasov from comment #2)

I'm sorry Dmitry but the proposed patch added a new variable, hence the question/review.
Comment 4 Dmitry Marakasov freebsd_committer 2021-06-15 14:39:02 UTC
(In reply to Kubilay Kocak from comment #3)
The addition of a new variable is well explained in the first comment. The questions of why ABIFLAGS is no longer sufficient and when the breakage happened should be directed to python@.
Comment 5 Dmitry Marakasov freebsd_committer 2021-07-14 20:32:10 UTC
Note that python310 now needs the similar change. I've marked DEBUG options BROKEN for the time being.
Comment 6 commit-hook freebsd_committer 2021-07-14 20:32:20 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2d2c2821bca5933475c6c418057f1480b85ded9b

commit 2d2c2821bca5933475c6c418057f1480b85ded9b
Author:     Dmitry Marakasov <amdmi3@FreeBSD.org>
AuthorDate: 2021-07-14 20:27:00 +0000
Commit:     Dmitry Marakasov <amdmi3@FreeBSD.org>
CommitDate: 2021-07-14 20:28:01 +0000

    lang/python{38,39,310}: mark DEBUG option BROKEN (incorrect plist)

    PR:             256558
    Approved by:    portmgr blanket

 lang/python310/Makefile | 1 +
 lang/python38/Makefile  | 1 +
 lang/python39/Makefile  | 1 +
 3 files changed, 3 insertions(+)