Bug 258107 - audio/audacity: Upgrade to 3.0.4
Summary: audio/audacity: Upgrade to 3.0.4
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL: https://wiki.audacityteam.org/wiki/Re...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-27 23:02 UTC by Jack
Modified: 2021-09-15 10:24 UTC (History)
4 users (show)

See Also:
xxjack12xx: maintainer-feedback+


Attachments
Patch to upgrade audacity from 3.0.2 to 3.0.4 (20.78 KB, patch)
2021-08-27 23:02 UTC, Jack
xxjack12xx: maintainer-approval+
Details | Diff
Patch to upgrade audacity from 3.0.2 to 3.0.4 (21.41 KB, patch)
2021-09-06 06:09 UTC, Jack
xxjack12xx: maintainer-approval+
Details | Diff
Upgrade to audacity 3.0.4 from 3.0.2 (21.45 KB, patch)
2021-09-14 19:17 UTC, Jack
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jack 2021-08-27 23:02:12 UTC
Created attachment 227497 [details]
Patch to upgrade audacity from 3.0.2 to 3.0.4

Audacity 3.0.4 minsrc is gone and now uses conan. Contains some patches from the next release to make 3.0.4 compile on FreeBSD.
Comment 1 Jack 2021-09-02 21:21:07 UTC
Hi, is this ok to upgrade?
Comment 2 Daniel Engberg freebsd_committer 2021-09-04 20:37:12 UTC
Since upstream doesn't generate static source archives use USE_GITHUB instead of MASTER_SITES
https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github-description

Should users be aware of any changes due the recent forks (Telemetry etc)?
Comment 3 Neel Chauhan freebsd_committer 2021-09-05 01:07:24 UTC
Build fails:

-- Added inteface expat::expat /usr/local/include /usr/local/lib/libexpat.sowxWidgets_LIBRARIES=general;-L/usr/local/lib;general;-pthread;general;-lwx_baseu-3.1;general;-lwx_gtk3u_core-3.1;general;-lwx_gtk3u_html-3.1;general;-lwx_gtk3u_qa-3.1;general;-lwx_baseu_xml-3.1;general;-lwx_baseu_net-3.1
wxWidgets_LIBRARY_DIRS=/usr/local/lib
-- Using 'wxWidgets' system library
CMake Error at cmake-proxies/cmake-modules/AudacityFunctions.cmake:133 (message):                                       
  Invalid value "local" for option audacity_use_libmp3lame.  Valid values
  are: system                           
Call Stack (most recent call first):
  cmake-proxies/cmake-modules/AudacityDependencies.cmake:129 (cmd_option)
  cmake-proxies/CMakeLists.txt:84 (add_conan_lib)


-- Configuring incomplete, errors occurred!
Comment 4 Jack 2021-09-06 01:48:00 UTC
(In reply to Daniel Engberg from comment #2)
I'll change to USE_GITHUB. I think the only additional feature is the auto check for update that can be disabled in the app preferences after install.
Comment 5 Jack 2021-09-06 01:48:43 UTC
(In reply to Neel Chauhan from comment #3)
Will check, the patch for system lame detection probably broke non system lame.
Comment 6 Jack 2021-09-06 06:09:18 UTC
Created attachment 227702 [details]
Patch to upgrade audacity from 3.0.2 to 3.0.4

Change to USE_GITHUB
Fix lame checking
midi support is required to compile
Comment 7 Jack 2021-09-12 22:57:22 UTC
How does this look now?
Comment 8 Neel Chauhan freebsd_committer 2021-09-12 23:16:18 UTC
Sorry for the delay. I will test and hopefully commit the port today.
Comment 9 Tatsuki Makino 2021-09-14 07:06:49 UTC
I will write here that when it shows the print preview, if evince is not installed, it will not run with the message
exec: evince: not found
Comment 10 Jack 2021-09-14 07:29:50 UTC
Ok, I will check and add dependency for evince
Comment 11 Jack 2021-09-14 19:17:33 UTC
Created attachment 227903 [details]
Upgrade to audacity 3.0.4 from 3.0.2

Added dependency on evince.
Comment 12 Tatsuki Makino 2021-09-15 06:59:59 UTC
(In reply to Jack from comment #11)

Thank you for taking action on my comment.
However, I'm sorry.

It was libgtk-3.so.0 that was emitting exec: evince: not found.
So audacity has nothing to do with it.

Additionally, this can be suppressed with ~/.config/gtk-3.0/settings.ini such as
[Settings]
gtk-print-preview-command="true"

Therefore, let's change the attachment to commit from 227903 back to attachment 227702 [details].
Comment 13 Jack 2021-09-15 07:11:13 UTC
(In reply to Tatsuki Makino from comment #12)

ok sounds good, less dependencies the better, although i did get that error when i did print preview too but maybe the other port needs that dep?
Comment 14 Tatsuki Makino 2021-09-15 10:21:42 UTC
(In reply to Jack from comment #13)

If the gnome3 metaport is installed and GNOME 3 is used as a desktop, evince will also be installed.
I am using GTK applications (audacity, etc.) without GNOME desktop, so evince was missing.

And as per my previous comment #12, the command used for print preview can be changed, so there is no need to depend on evince for print preview.

Another example configuration:
gtk-print-preview-command = "xmessage" "%s" "%f"
Comment 15 Jack 2021-09-15 10:22:51 UTC
Ok sounds good, let's use the patch before the evince dependency, thanks