Bug 259552 - security/libgcrypt: optionalize INFO
Summary: security/libgcrypt: optionalize INFO
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Cy Schubert
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2021-10-30 15:44 UTC by Val Packett
Modified: 2022-01-27 05:09 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (cy)


Attachments
0001-security-libgcrypt-optionalize-INFO.patch (3.08 KB, patch)
2021-10-30 15:44 UTC, Val Packett
no flags Details | Diff
0001-security-libgcrypt-optionalize-INFO.patch (3.11 KB, patch)
2021-10-31 10:54 UTC, Val Packett
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Val Packett 2021-10-30 15:44:09 UTC
Created attachment 229148 [details]
0001-security-libgcrypt-optionalize-INFO.patch

makeinfo is an annoying dependency that is often introduced by libxslt → libgcrypt. info pages aren't popular in the BSD world anyway. Maybe let's make them optional here, and disable by default even, like in this patch?
Comment 1 dewayne 2021-10-30 23:03:14 UTC
(In reply to Greg V from comment #0)
Thanks Greg, I like the patch and haven't had use of any "info" files since 2004.  Its better to not include from the outset.  

A few years ago I appended to /usr/ports/Mk/bsd.port.mk
RUN_DEPENDS:=${RUN_DEPENDS:Nindexinfo*}
LIB_DEPENDS:=${LIB_DEPENDS:Nindexinfo*}
BUILD_DEPENDS:=${BUILD_DEPENDS:Nindexinfo*}
only a half measure  ;)

Pity we can't just 'exit' out of "/usr/ports/Mk/Uses/makeinfo.mk"
Comment 2 Cy Schubert freebsd_committer freebsd_triage 2021-10-31 01:50:39 UTC
Disable by default is not FreeBSD policy. Optional disable is certainly doable.
Comment 3 Val Packett 2021-10-31 10:54:42 UTC
Created attachment 229169 [details]
0001-security-libgcrypt-optionalize-INFO.patch
Comment 4 Cy Schubert freebsd_committer freebsd_triage 2022-01-27 04:57:56 UTC
Committed locally. Will be pushed the next time I push.
Comment 5 Cy Schubert freebsd_committer freebsd_triage 2022-01-27 05:09:47 UTC
Committed. Thanks for the patch.
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-01-27 05:09:52 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=fe14cd83dad652fbccffcdcaa81f73637f008c15

commit fe14cd83dad652fbccffcdcaa81f73637f008c15
Author:     Greg V <greg@unrelenting.technology>
AuthorDate: 2021-10-30 15:38:41 +0000
Commit:     Cy Schubert <cy@FreeBSD.org>
CommitDate: 2022-01-27 05:08:40 +0000

    security/libgcrypt: optionalize INFO

    Allow the user to optionally exclude INFO files, allowing the space
    conscious user the ability to install a minimual package. The default
    remains to install INOF files as before.

    PR:             259552
    Reported by:    Greg V <greg@unrelenting.technology>
    Submitted by:   Greg V <greg@unrelenting.technology>

 security/libgcrypt/Makefile                        | 13 ++++++++-----
 security/libgcrypt/files/extra-patch-no-info (new) | 20 ++++++++++++++++++++
 2 files changed, 28 insertions(+), 5 deletions(-)