Bug 259715 - graphics/gifsicle: Install gifview by default
Summary: graphics/gifsicle: Install gifview by default
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mateusz Piotrowski
URL:
Keywords:
Depends on:
Blocks: 269274
  Show dependency treegraph
 
Reported: 2021-11-08 14:35 UTC by Mateusz Piotrowski
Modified: 2023-02-15 00:22 UTC (History)
3 users (show)

See Also:
tagattie: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mateusz Piotrowski freebsd_committer freebsd_triage 2021-11-08 14:35:40 UTC
Hey, I wonder if we could enable the X11 option by default so that users may enjoy availability of the gifview command in binary packages. This seems to be what other distributions are doing. 

I'll be happy to commit a patch if you give a green light to do it.

Cheers!
Comment 1 Hiroki Tagato freebsd_committer freebsd_triage 2021-11-10 11:43:46 UTC
(In reply to Mateusz Piotrowski from comment #0)

Thanks for the proposal. I agree that X11 option ON by default will be beneficial for users.

Go forward.
Comment 2 Mateusz Piotrowski freebsd_committer freebsd_triage 2021-11-10 15:26:40 UTC
Thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-11-10 15:30:38 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4698c6bc00b6c6b2f574b9e8e070473e456f2940

commit 4698c6bc00b6c6b2f574b9e8e070473e456f2940
Author:     Mateusz Piotrowski <0mp@FreeBSD.org>
AuthorDate: 2021-11-10 15:26:20 +0000
Commit:     Mateusz Piotrowski <0mp@FreeBSD.org>
CommitDate: 2021-11-10 15:29:33 +0000

    graphics/gifsicle: Enable option X11 by default

    This way the default package is going to provide gifview.

    PR:             259715
    Approved by:    tagattie (maintainer)

 graphics/gifsicle/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Comment 4 kennedy.greg 2023-02-01 05:41:36 UTC
Funny to see that this was changed back, as it was discussed on the mailing list before to _remove_ X11 (which obvs pulls in a dependency on X11 in a lot of places that don't need it, e.g. Wordpress plugins running on a headless server that simply want to do image optimization)

"gifview" isn't a terribly useful app and not central to the purpose of the port itself, i.e. the `gifsicle` cli program.

The removal was done at the same time as bumping version 1.90 to 1.91:

https://github.com/freebsd/freebsd-ports/commit/8e0d15e2191ac107abbfca8a6b3e6b19884cb869
Comment 5 Mateusz Piotrowski freebsd_committer freebsd_triage 2023-02-01 12:53:34 UTC
(In reply to kennedy.greg from comment #4)

Hey! Thank you for your message. I wasn't aware of this discussion and use case.

The way forward is to create a clone of this port so that there are 2 packages available: one for the desktop users and one for the server users.

I won't have the time to work on it anytime soon, however. So, I'll open another bug report so that we have an open ticket for that.

Cheers!
Mateusz
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-02-15 00:17:15 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9fa9c432290140ad4668da46934b93767a53bf07

commit 9fa9c432290140ad4668da46934b93767a53bf07
Author:     Hiroki Tagato <tagattie@FreeBSD.org>
AuthorDate: 2023-02-15 00:11:06 +0000
Commit:     Hiroki Tagato <tagattie@FreeBSD.org>
CommitDate: 2023-02-15 00:17:05 +0000

    graphics/gifsicle: flavorize (x11 as default and nox11)

    It turns out there are conflicting interests between desktop and
    server users of this port. Flavoring the port will solve the issue by
    creating packages with x11 dependency and without.

    PR:             259715, 269274
    Reported by:    kennedy.greg@gmail.com, 0mp
    Reviewed by:    0mp
    MFH:            2023Q1

 graphics/gifsicle/Makefile | 29 +++++++++++++++++++----------
 1 file changed, 19 insertions(+), 10 deletions(-)
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-02-15 00:19:18 UTC
A commit in branch 2023Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=246d74ac73f92320514e87bb3c0d77ba21ed58fd

commit 246d74ac73f92320514e87bb3c0d77ba21ed58fd
Author:     Hiroki Tagato <tagattie@FreeBSD.org>
AuthorDate: 2023-02-15 00:11:06 +0000
Commit:     Hiroki Tagato <tagattie@FreeBSD.org>
CommitDate: 2023-02-15 00:18:22 +0000

    graphics/gifsicle: flavorize (x11 as default and nox11)

    It turns out there are conflicting interests between desktop and
    server users of this port. Flavoring the port will solve the issue by
    creating packages with x11 dependency and without.

    PR:             259715, 269274
    Reported by:    kennedy.greg@gmail.com, 0mp
    Reviewed by:    0mp
    MFH:            2023Q1

    (cherry picked from commit 9fa9c432290140ad4668da46934b93767a53bf07)

 graphics/gifsicle/Makefile | 29 +++++++++++++++++++----------
 1 file changed, 19 insertions(+), 10 deletions(-)
Comment 8 Hiroki Tagato freebsd_committer freebsd_triage 2023-02-15 00:22:01 UTC
(In reply to kennedy.greg from comment #4)

This port has been flavorized (x11 as default and nox11). If you don't want x11 dependency, please use the package gifsicle-nox11.