Bug 269274 - graphics/gifsicle: Create packages with and without the X11 option
Summary: graphics/gifsicle: Create packages with and without the X11 option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Hiroki Tagato
URL:
Keywords:
Depends on: 259715
Blocks:
  Show dependency tree / graph
 
Reported: 2023-02-01 12:55 UTC by Mateusz Piotrowski
Modified: 2023-02-15 00:19 UTC (History)
1 user (show)

See Also:
tagattie: maintainer-feedback+

Attachments
Patch (1.42 KB, patch)
2023-02-08 06:26 UTC, Hiroki Tagato 		tagattie: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mateusz Piotrowski freebsd_committer freebsd_triage 2023-02-01 12:55:51 UTC 
It turns out that graphics/gifsicle is used by both desktop and server users. As a result, there is a conflict of interest whether the X11 option should be enabled or not. The best solution is probably to provide both packages.

Refer to 259715 for more details.
Comment 1 Hiroki Tagato freebsd_committer freebsd_triage 2023-02-08 05:05:58 UTC 
(In reply to Mateusz Piotrowski from comment #0)

Flavorizing the port (x11 as default and nox11) seems a solution. I will make changes accordingly.

Thanks!
Comment 2 Hiroki Tagato freebsd_committer freebsd_triage 2023-02-08 06:26:09 UTC 
Created attachment 239982 [details]
Patch

graphics/gifsicle: flavorize (x11 as default and nox11)
    
It turns out there are conflicting interests between desktop and server users of this port. Flavoring the port will solve the issue by creating packages with x11 dependency and without.
Comment 3 Hiroki Tagato freebsd_committer freebsd_triage 2023-02-14 10:53:52 UTC 
Hi Mateusz,

Are you comfortable with the patch I proposed? If so, I will push the change. Let me know your opinion.

Thanks.
Comment 4 Mateusz Piotrowski freebsd_committer freebsd_triage 2023-02-14 11:57:18 UTC 
(In reply to Hiroki Tagato from comment #3)

From what I read in the patch, it looks alright to me :) Thanks a lot!
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-02-15 00:18:16 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9fa9c432290140ad4668da46934b93767a53bf07

commit 9fa9c432290140ad4668da46934b93767a53bf07
Author:     Hiroki Tagato <tagattie@FreeBSD.org>
AuthorDate: 2023-02-15 00:11:06 +0000
Commit:     Hiroki Tagato <tagattie@FreeBSD.org>
CommitDate: 2023-02-15 00:17:05 +0000

    graphics/gifsicle: flavorize (x11 as default and nox11)

    It turns out there are conflicting interests between desktop and
    server users of this port. Flavoring the port will solve the issue by
    creating packages with x11 dependency and without.

    PR:             259715, 269274
    Reported by:    kennedy.greg@gmail.com, 0mp
    Reviewed by:    0mp
    MFH:            2023Q1

 graphics/gifsicle/Makefile | 29 +++++++++++++++++++----------
 1 file changed, 19 insertions(+), 10 deletions(-)
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-02-15 00:19:18 UTC 
A commit in branch 2023Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=246d74ac73f92320514e87bb3c0d77ba21ed58fd

commit 246d74ac73f92320514e87bb3c0d77ba21ed58fd
Author:     Hiroki Tagato <tagattie@FreeBSD.org>
AuthorDate: 2023-02-15 00:11:06 +0000
Commit:     Hiroki Tagato <tagattie@FreeBSD.org>
CommitDate: 2023-02-15 00:18:22 +0000

    graphics/gifsicle: flavorize (x11 as default and nox11)

    It turns out there are conflicting interests between desktop and
    server users of this port. Flavoring the port will solve the issue by
    creating packages with x11 dependency and without.

    PR:             259715, 269274
    Reported by:    kennedy.greg@gmail.com, 0mp
    Reviewed by:    0mp
    MFH:            2023Q1

    (cherry picked from commit 9fa9c432290140ad4668da46934b93767a53bf07)

 graphics/gifsicle/Makefile | 29 +++++++++++++++++++----------
 1 file changed, 19 insertions(+), 10 deletions(-)
Comment 7 Hiroki Tagato freebsd_committer freebsd_triage 2023-02-15 00:19:45 UTC 
Committed, thanks!