Bug 265390 - www/onionshare traceback
Summary: www/onionshare traceback
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vinícius Zavam
URL:
Keywords:
Depends on: 248438 248712
Blocks:
  Show dependency treegraph
 
Reported: 2022-07-22 19:26 UTC by chris
Modified: 2022-08-07 15:26 UTC (History)
1 user (show)

See Also:
egypcio: maintainer-feedback+


Attachments
[PATCH] www/onionshare: fix DEPRECATED, and update pluggable transports (2.02 KB, patch)
2022-08-06 17:31 UTC, Vinícius Zavam
no flags Details | Diff
[PATCH] www/onionshare: fix DEPRECATED, and update pluggable transports (2.02 KB, patch)
2022-08-06 17:42 UTC, Vinícius Zavam
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description chris 2022-07-22 19:26:55 UTC
Attempting to start onionshare-gui, which fails with the following:

[~]$ onionshare-gui
Traceback (most recent call last):
  File "/usr/local/bin/onionshare-gui", line 21, in <module>
    import onionshare_gui
  File "/usr/local/lib/python3.9/site-packages/onionshare_gui/__init__.py", line 29, in <module>
    from onionshare.common import Common
  File "/usr/local/lib/python3.9/site-packages/onionshare/__init__.py", line 26, in <module>
    from .web import Web
  File "/usr/local/lib/python3.9/site-packages/onionshare/web/__init__.py", line 21, in <module>
    from .web import Web
  File "/usr/local/lib/python3.9/site-packages/onionshare/web/web.py", line 22, in <module>
    from flask_httpauth import HTTPBasicAuth
  File "/usr/local/lib/python3.9/site-packages/flask_httpauth.py", line 16, in <module>
    from werkzeug.security import safe_str_cmp
ImportError: cannot import name 'safe_str_cmp' from 'werkzeug.security' (/usr/local/lib/python3.9/site-packages/werkzeug/security.py)
[~]$
Comment 1 Vinícius Zavam freebsd_committer freebsd_triage 2022-07-27 14:37:12 UTC
thanks for flagging that! appreciated.

onionshare is under my radar for quite a few time already, and it must be updated to a newer version -- which requires new additions to the ports tree itself before getting further with its update support.
Comment 2 chris 2022-07-29 12:37:58 UTC
Thanks for your reply.
Comment 3 Vinícius Zavam freebsd_committer freebsd_triage 2022-08-06 11:16:18 UTC
(In reply to chris from comment #2)

while we are working here to get recent versions of OnionShare (GUI) to be fully functional, the CLI version just landed in our ports tree:

  * https://cgit.freebsd.org/ports/commit?id=2bc1986c8c9992b9e60a3832392d01cfbb5a4b2a

hope that can help you to 'workaround' any need you might have til the GUI version is fixed.
Comment 4 chris 2022-08-06 13:32:59 UTC
Many thanks for the heads-up on this. The CLI version will be fine until you get the GUI working.

Cheers

Chris
Comment 5 Vinícius Zavam freebsd_committer freebsd_triage 2022-08-06 17:07:36 UTC
added a reference to the PR which fixes the root-cause of this issue, and also linked a different PR. that second one is sadly a dependency which is blocking me to update OnionShare for quite a while - talking about Bug #248712 here.
Comment 6 Vinícius Zavam freebsd_committer freebsd_triage 2022-08-06 17:31:14 UTC
Created attachment 235723 [details]
[PATCH] www/onionshare: fix DEPRECATED, and update pluggable transports

adding the patch which aim to fix this issue;

  * fix DEPRECATED flag, by using a more reliable module instead of pycrypto;
  * update pluggable transports support, by adding snowflake.
Comment 7 Vinícius Zavam freebsd_committer freebsd_triage 2022-08-06 17:42:13 UTC
Created attachment 235724 [details]
[PATCH] www/onionshare: fix DEPRECATED, and update pluggable transports
Comment 8 commit-hook freebsd_committer freebsd_triage 2022-08-07 15:24:30 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d0aab7f46df1ee2494ac09858fd903330f785d43

commit d0aab7f46df1ee2494ac09858fd903330f785d43
Author:     Vinícius Zavam <egypcio@FreeBSD.org>
AuthorDate: 2022-08-07 15:17:20 +0000
Commit:     Vinícius Zavam <egypcio@FreeBSD.org>
CommitDate: 2022-08-07 15:24:17 +0000

    www/onionshare: fix DEPRECATED deps, and update pluggable transports

      * fix DEPRECATED flag, by using a more reliable Python module;
      * used pycryptodome instead of cryptography to keep compatibility;
      * update pluggable transports support by adding snowflake.

    PR:             260897, 262503, 265390
    Reported by:    yuri@, ruben <ruben % verweg.com>, chris <chris % crvintel.com>
    Sponsored by:   TorBSD Diversity Project, TDP
    Sponsored by:   The Tor Project

 www/onionshare/Makefile | 17 ++++++++---------
 www/onionshare/distinfo |  6 +++---
 2 files changed, 11 insertions(+), 12 deletions(-)